Skip to content

Reland: Updates flutter_localizations/test to stop using TestWindow - #122564

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
pdblasi-google:issues/122237
Mar 14, 2023
Merged

Reland: Updates flutter_localizations/test to stop using TestWindow#122564
auto-submit[bot] merged 1 commit into
flutter:masterfrom
pdblasi-google:issues/122237

Conversation

@pdblasi-google

@pdblasi-google pdblasi-google commented Mar 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Updates flutter_localizations/test to stop using TestWindow.

Resolves #122237

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added a: internationalization Supporting other languages or locales. (aka i18n) p: material_ui material_ui package in flutter/packages labels Mar 13, 2023
goderbauer
goderbauer approved these changes Mar 13, 2023
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2023
@auto-submit
auto-submit Bot merged commit 45c94ec into flutter:master Mar 14, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2023
@engine-flutter-autoroll
45c94ec Updates flutter_localizations/test to stop using `TestWindo…
10552ad 
…w` (flutter/flutter#122564)
@pdblasi-google
pdblasi-google deleted the issues/122237 branch March 15, 2023 18:08
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
45c94ec Updates flutter_localizations/test to stop using `TestWindo…
891b16d 
…w` (flutter/flutter#122564)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
45c94ec Updates flutter_localizations/test to stop using `TestWindo…
7949ff2 
…w` (flutter/flutter#122564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) autosubmit Merge PR when tree becomes green via auto submit App p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update flutter_localizations/test to stop using TestWindow

2 participants

@pdblasi-google @goderbauer