Create CupertinoRadio Widget by MitchellGoodwin · Pull Request #123296 · flutter/flutter

MitchellGoodwin · 2023-03-22T22:54:56Z

Addresses #102813. Adds a radio widget to Cupertino. Like the checkbox, this will be made adaptable with the Material radio widget.

Here's the radio buttons in the macOS settings:

And here's the Cupertino version in action, including keyboard focus/ interaction:

Screen.Recording.2023-03-22.at.3.49.57.PM.mov

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gspencergoog

Both of the examples will need tests. See some of the other tests under examples/api/test to see how they're written. They're pretty simple tests just to make sure that the example displays the expected components of the example.

gspencergoog · 2023-03-27T17:37:40Z

You should give this a more specific name: (e.g. 'CuptertinoRadio Example').

gspencergoog · 2023-03-27T17:38:09Z

Try naming the app something like "CupertinoRadioApp" or something to make it match the example.

gspencergoog · 2023-03-27T17:38:59Z

Suggested change

// Flutter code sample for [CupertinoRadio].

/// Flutter code sample for [CupertinoRadio].

This should be a doc comment so that IDE users can click on the link to get back to the class the example is attached to.

You might need to move this below the import if the analyzer complains.

gspencergoog · 2023-03-27T17:39:49Z

You can probably get rid of this. The title is not really used on iOS, I don't think. On Android it's used when you pull down the window shade, but that's all.

gspencergoog · 2023-03-27T17:42:45Z

Name this something specific to this example: CupertinoRadioExample or something.

gspencergoog · 2023-03-27T17:52:54Z

Suggested change

/// radio button with the new [groupValue].

/// radio button with a new [groupValue].

gspencergoog · 2023-03-27T17:56:03Z

Suggested change

/// ** See code in examples/api/lib/cupertino/radio/radio.toggleable.0.dart **

/// ** See code in examples/api/lib/cupertino/radio/cupertino_radio.toggleable.0.dart **

gspencergoog · 2023-03-27T17:58:10Z

Is it really a "shadow"? I think I'd call it just a border.

gspencergoog · 2023-03-27T17:58:37Z

You might move this to a named constant at the top of the file.

gspencergoog

Create CupertinoRadio Widget

MitchellGoodwin marked this pull request as ready for review March 24, 2023 17:31

MitchellGoodwin requested a review from gspencergoog March 27, 2023 17:34

gspencergoog reviewed Mar 27, 2023

View reviewed changes

MitchellGoodwin force-pushed the create-cupertino-radio branch from 29f8af3 to 783cf86 Compare March 27, 2023 21:47

MitchellGoodwin added 10 commits March 29, 2023 11:32

Beginning of cupertino radio

2c7393a

Continue radio

2d3fc5f

Update radio painter

08cd78b

Connect with focus events

297f485

Add tests

5cced8a

Add examples

b77ccc2

Update documentation

86bf704

Fix example

fea9083

Refactor test

e27a5af

Add tests to examples and update docs

815fbe3

MitchellGoodwin force-pushed the create-cupertino-radio branch from 783cf86 to 815fbe3 Compare March 29, 2023 18:32

gspencergoog approved these changes Mar 29, 2023

View reviewed changes

MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 30, 2023

auto-submit Bot merged commit 84078c8 into flutter:master Mar 30, 2023

engine-flutter-autoroll mentioned this pull request Mar 30, 2023

Roll Flutter from 12b36de8f7ac to 302c087738a4 (46 revisions) flutter/packages#3593

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

29e6d6b

engine-flutter-autoroll mentioned this pull request Mar 30, 2023

Roll Flutter from 12b36de8f7ac to 8c5d223bab70 (49 revisions) flutter/packages#3594

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

76bfab7

engine-flutter-autoroll mentioned this pull request Mar 30, 2023

Roll Flutter from 12b36de8f7ac to 5f7117948072 (50 revisions) flutter/packages#3595

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

428323e

engine-flutter-autoroll mentioned this pull request Mar 30, 2023

Roll Flutter from 12b36de8f7ac to a28aae918eae (51 revisions) flutter/packages#3597

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

02aaa39

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to d940f60b4680 (70 revisions) flutter/packages#3605

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

b338176

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to f6c2b10e1a98 (71 revisions) flutter/packages#3606

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

c34692b

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to f5415a42d342 (72 revisions) flutter/packages#3607

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

0d5d210

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to 63e30480cd51 (74 revisions) flutter/packages#3608

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

e7f6491

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to 9a344c2604ec (75 revisions) flutter/packages#3609

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

62d3ea4

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to a8117bf18778 (76 revisions) flutter/packages#3610

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

4998699

engine-flutter-autoroll mentioned this pull request Mar 31, 2023

Roll Flutter from 12b36de8f7ac to 9d820aa35a22 (77 revisions) flutter/packages#3611

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

ea09f1d

HansMuller mentioned this pull request Mar 31, 2023

Flutter Framework Team: Notable Commits #121415

Closed

reidbaker mentioned this pull request Apr 1, 2023

Add Java-Gradle-AGP validation to flutter analyze #123916

Merged

7 of 8 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

fada723

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

cbb9aea

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

02b9d41

reidbaker mentioned this pull request Apr 5, 2023

Update getGradleVersion to ignore commented out lines #124260

Merged

8 tasks done

exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023

Create CupertinoRadio Widget (flutter#123296)

e49b61b

Create CupertinoRadio Widget

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

297550c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

84078c8 Create CupertinoRadio Widget (flutter/flutter#123296)

a1833db

Navigation Menu

Repository navigation

Create CupertinoRadio Widget - #123296

Create CupertinoRadio Widget#123296
auto-submit[bot] merged 10 commits into
flutter:masterfrom
MitchellGoodwin:create-cupertino-radio

MitchellGoodwin commented Mar 22, 2023 •

edited

Loading

Uh oh!

gspencergoog left a comment

Uh oh!

gspencergoog Mar 27, 2023

Uh oh!

gspencergoog Mar 27, 2023

Uh oh!

gspencergoog Mar 27, 2023

Uh oh!

gspencergoog Mar 27, 2023

Uh oh!

gspencergoog Mar 27, 2023

Uh oh!

gspencergoog Mar 27, 2023

Uh oh!

Uh oh!

gspencergoog Mar 27, 2023

Uh oh!

gspencergoog Mar 27, 2023

Uh oh!

gspencergoog Mar 27, 2023

Uh oh!

gspencergoog left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	// Flutter code sample for [CupertinoRadio].
	/// Flutter code sample for [CupertinoRadio].

	/// radio button with the new [groupValue].
	/// radio button with a new [groupValue].

	/// See code in examples/api/lib/cupertino/radio/radio.toggleable.0.dart
	/// See code in examples/api/lib/cupertino/radio/cupertino_radio.toggleable.0.dart

Conversation

MitchellGoodwin commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MitchellGoodwin commented Mar 22, 2023 •

edited

Loading