Skip to content

Revert "Fix divider width in scrollable TabBar for Material 3 and add dividerHeight parameter" - #123616

Merged
auto-submit[bot] merged 1 commit into
masterfrom
revert-123127-fix_tab_bar_divider_m3
Mar 28, 2023
Merged

Revert "Fix divider width in scrollable TabBar for Material 3 and add dividerHeight parameter"#123616
auto-submit[bot] merged 1 commit into
masterfrom
revert-123127-fix_tab_bar_divider_m3

Conversation

@Piinks

@Piinks Piinks commented Mar 28, 2023

Copy link
Copy Markdown
Contributor

Reverts #123127

This broke many customer tests, most are ok, but some look unexpected.

FYI @TahaTesser

@Piinks
Revert "Fix divider width in scrollable TabBar for Material 3 and a…
30286af 
…dd `dividerHeight` parameter (#123127)"

This reverts commit 3512c2c.
@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 28, 2023
HansMuller
HansMuller approved these changes Mar 28, 2023
View reviewed changes

@HansMuller HansMuller left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

jonahwilliams
jonahwilliams approved these changes Mar 28, 2023
View reviewed changes

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 28, 2023
@auto-submit
auto-submit Bot merged commit 3dfc60c into master Mar 28, 2023
@auto-submit
auto-submit Bot deleted the revert-123127-fix_tab_bar_divider_m3 branch March 28, 2023 16:45
@auto-submit auto-submit Bot mentioned this pull request Mar 28, 2023
Closed
@reidbaker reidbaker mentioned this pull request Mar 28, 2023
Merged
8 tasks done
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
87ca472 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
f1e17ca 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
a524df5 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
cbccb9c 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
36169ad 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
811d188 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
8736cbd 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
f835bfd 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
683c26b 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
a5344cb 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
f37dd91 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
dda8a98 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
611b5a0 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
dbf8752 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
8d70b50 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
0ce7b78 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
3acae9e 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
@reidbaker reidbaker mentioned this pull request Apr 1, 2023
Merged
7 of 8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
2b7e677 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
c722842 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
f1e7057 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
@reidbaker reidbaker mentioned this pull request Apr 5, 2023
Merged
8 tasks done
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
b48eb38 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
3dfc60c Revert "Fix divider width in scrollable TabBar for Material…
178ec2c 
… 3 and add `dividerHeight` parameter (#123127)" (flutter/flutter#123616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes
+2 more reviewers
@HansMuller HansMuller HansMuller approved these changes
@jonahwilliams jonahwilliams jonahwilliams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Piinks @HansMuller @jonahwilliams @fluttergithubbot