Skip to content

Add adaptive constructor to Radio and RadioListTile - #123816

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
MitchellGoodwin:adaptive-radio
Apr 4, 2023
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
MitchellGoodwin:adaptive-radio

Conversation

@MitchellGoodwin

@MitchellGoodwin MitchellGoodwin commented Mar 30, 2023 •

Copy link
Copy Markdown
Contributor

Fixes #102809. Adds an adaptive constructor to the Radio and RadioListTile widgets.

Screenshot 2023-03-30 at 1 46 30 PM

Screenshot 2023-03-30 at 1 46 15 PM

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Mar 30, 2023
@MitchellGoodwin
MitchellGoodwin marked this pull request as ready for review March 30, 2023 22:08

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:) !

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe we don't need this StateBuilder because there's no state change?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:)

@MitchellGoodwin MitchellGoodwin added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@auto-submit
auto-submit Bot merged commit c8a3dba into flutter:master Apr 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2023
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
Add adaptive constructor to Radio and RadioListTile
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .adaptive constructor for single-selection

2 participants