Skip to content

Always use the canvaskit path from the web sdk. - #123915

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
eyebrowsoffire:canvaskit_path
Apr 4, 2023
Merged

auto-submit[bot] merged 4 commits into
flutter:masterfrom
eyebrowsoffire:canvaskit_path

Conversation

@eyebrowsoffire

@eyebrowsoffire eyebrowsoffire commented Apr 1, 2023 •

Copy link
Copy Markdown
Contributor

This artifact was previously populated from CIPD. We don't use CIPD anymore, local canvaskit is bundled with the web sdk, so we should just source the artifact directly from that.

Also I updated the outputs of the static assets target, which was suggested in a post-merge review by @mdebbar

This should fix #123737

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2023
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2023
@auto-submit

auto-submit Bot commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 123915, due to - The status or check suite Windows build_tests_3_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2023
@auto-submit

auto-submit Bot commented Apr 4, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 123915, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@eyebrowsoffire eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 4, 2023
@auto-submit
auto-submit Bot merged commit 37d4e7d into flutter:master Apr 4, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2023
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
Always use the canvaskit path from the web sdk.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@eyebrowsoffire
eyebrowsoffire deleted the canvaskit_path branch December 12, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

framework canvaskit cache is not being cleared with engine rolls

3 participants