Skip to content

Revert "Fix scrolling in the Drawer and NavigationDrawer triggers AppBar's scrolledUnderElevation" - #124226

Merged
auto-submit[bot] merged 1 commit into
masterfrom
revert-122600-fix_drawers_scrollUnderElevation
Apr 5, 2023
Merged

auto-submit[bot] merged 1 commit into
masterfrom
revert-122600-fix_drawers_scrollUnderElevation

Conversation

@Piinks

@Piinks Piinks commented Apr 5, 2023 •

Copy link
Copy Markdown
Contributor

Reverts #122600

Replaces #124187

Closes #123782

… AppBar's scrolledUnderElevation (#122600)"

This reverts commit 6e04bdd.
@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Apr 5, 2023

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert LGTM 👍

@Piinks Piinks added revert Autorevert PR (with "Reason for revert:" comment) autosubmit Merge PR when tree becomes green via auto submit App labels Apr 5, 2023
@auto-submit
auto-submit Bot merged commit 0cfcdee into master Apr 5, 2023
@auto-submit
auto-submit Bot deleted the revert-122600-fix_drawers_scrollUnderElevation branch April 5, 2023 16:10
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 5, 2023
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
… AppBar's scrolledUnderElevation" (flutter#124226)

Revert "Fix scrolling in the  `Drawer` and `NavigationDrawer` triggers AppBar's scrolledUnderElevation"
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

~10% regression in stock layout iteration microbenchmark

3 participants