Skip to content

[Docs] Fix Typos - #124249

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
piedcipher:docs/typos
Apr 6, 2023
Merged

[Docs] Fix Typos#124249
auto-submit[bot] merged 4 commits into
flutter:masterfrom
piedcipher:docs/typos

Conversation

@piedcipher

@piedcipher piedcipher commented Apr 5, 2023

Copy link
Copy Markdown
Member

Fix Some Typos in the comments.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added a: text input Entering text in a text field or keyboard related problems p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Apr 5, 2023
goderbauer
goderbauer approved these changes Apr 5, 2023
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

QuncCccccc
QuncCccccc approved these changes Apr 5, 2023
View reviewed changes

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 5, 2023
@auto-submit

auto-submit Bot commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 124249, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@piedcipher

piedcipher commented Apr 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

auto label is removed for flutter/flutter, pr: 124249, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

This check is failing on all PRs at the moment.

@goderbauer

goderbauer commented Apr 5, 2023

Copy link
Copy Markdown
Member

Yeah, it is busted currently. People are working on fixing it. Sorry about the inconvenience.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit
auto-submit Bot merged commit 743fcf7 into flutter:master Apr 6, 2023
@piedcipher
piedcipher deleted the docs/typos branch April 6, 2023 15:44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2023
@engine-flutter-autoroll
743fcf7 [Docs] Fix Typos (flutter/flutter#124249)
1c50859
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@piedcipher @exaby73
[Docs] Fix Typos (flutter#124249)
451a6b7 
[Docs] Fix Typos
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
743fcf7 [Docs] Fix Typos (flutter/flutter#124249)
59b8f9c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
743fcf7 [Docs] Fix Typos (flutter/flutter#124249)
352aaf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes
@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@piedcipher @goderbauer @QuncCccccc @CaseyHillers