Skip to content

flutter tool: make FlutterOptions abstract final - #124335

Merged
auto-submit[bot] merged 1 commit into
masterfrom
flutter_opt_abstract_final
Apr 6, 2023
Merged

auto-submit[bot] merged 1 commit into
masterfrom
flutter_opt_abstract_final

Conversation

@kevmoo

@kevmoo kevmoo commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

Relands #124178 - d062bfa
Unlands #124303 - 419c1eb

flutter tool: make FlutterOptions abstract final

Relands #124178 - d062bfa
Unlands #124303 - 419c1eb

flutter tool: make FlutterOptions abstract final
@flutter-dashboard flutter-dashboard Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 6, 2023
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2023
@auto-submit
auto-submit Bot merged commit e625730 into master Apr 6, 2023
@auto-submit
auto-submit Bot deleted the flutter_opt_abstract_final branch April 6, 2023 19:58
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 7, 2023
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
flutter tool: make FlutterOptions abstract final
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants