Skip to content

Adds dart_fix support to flutter_test - #124347

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
pdblasi-google:issues/123154
Apr 11, 2023
Merged

Adds dart_fix support to flutter_test#124347
auto-submit[bot] merged 3 commits into
flutter:masterfrom
pdblasi-google:issues/123154

Conversation

@pdblasi-google

@pdblasi-google pdblasi-google commented Apr 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves #123154

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on [Discord].

@pdblasi-google
pdblasi-google requested a review from Piinks April 6, 2023 20:09
@flutter-dashboard flutter-dashboard Bot added a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Apr 6, 2023
goderbauer
goderbauer reviewed Apr 6, 2023
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fly-by comment. I am so excited to have this! Also, thank you soo much for adding all these fixes for existing deprecated properties!

Comment thread packages/flutter_test/lib/fix_data/README.md Outdated
Comment thread packages/flutter_test/lib/fix_data/README.md Outdated
Comment thread packages/flutter_test/lib/fix_data/README.md Outdated
Comment thread packages/flutter_test/lib/fix_data/README.md Outdated
Comment thread packages/flutter_test/lib/fix_data/fix_flutter_test/fix_animation_sheet_builder.yaml Outdated
Comment thread ...st/lib/fix_data/fix_flutter_test/fix_binding/fix_automated_test_widgets_flutter_binding.yaml Outdated
Comment thread packages/flutter_test/test_fixes/flutter_test/animation_sheet_builder.dart Outdated
Comment thread ...ges/flutter_test/test_fixes/flutter_test/binding/automated_test_widgets_flutter_binding.dart Outdated
Piinks
Piinks reviewed Apr 6, 2023
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is AWESOME! Thank you! 🎉

Comment thread packages/flutter_test/lib/fix_data/README.md Outdated
Comment thread packages/flutter_test/lib/fix_data/fix_flutter_test/fix_animation_sheet_builder.yaml Outdated
Comment thread packages/flutter_test/lib/fix_data/README.md Outdated
Comment thread packages/flutter_test/lib/fix_data/fix_flutter_test/fix_animation_sheet_builder.yaml Outdated
Comment thread packages/flutter_test/lib/fix_data/fix_flutter_test/fix_animation_sheet_builder.yaml Outdated
Comment thread ...er_test/lib/fix_data/fix_flutter_test/fix_binding/fix_live_test_widgets_flutter_binding.yaml Outdated
Comment thread ...flutter_test/lib/fix_data/fix_flutter_test/fix_binding/fix_test_widgets_flutter_binding.yaml Outdated
Comment thread ...flutter_test/lib/fix_data/fix_flutter_test/fix_binding/fix_test_widgets_flutter_binding.yaml Outdated
Comment thread packages/flutter_test/test_fixes/flutter_test/animation_sheet_builder.dart Outdated
Comment thread ...ges/flutter_test/test_fixes/flutter_test/binding/automated_test_widgets_flutter_binding.dart Outdated
@Piinks

Piinks commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

LOL I am too slow for @goderbauer

goderbauer
goderbauer reviewed Apr 6, 2023
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Deferring to @Piinks for final approval!

Comment thread packages/flutter_test/test_fixes/flutter_test/binding/test_widgets_flutter_binding.dart Outdated
Piinks
Piinks approved these changes Apr 10, 2023
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flutter_LGTM

@pdblasi-google
Adds dart_fix support to flutter_test
3a8e18d 
* Adds fixes for the first round of deprecations listed in flutter#122323
* Adds tests for all new fixes
* Adds a note for the `runTest(timeout)` deprecations to prevent them from being removed before `integration_test` also has `dart fix` support
@pdblasi-google
Remove flutter_test fixes from analysis.
a1ff3fa
@pdblasi-google
Updates from PR
7d242f1 
* Fixed typos in README.md
* Updated examples in `flutter_test`'s README.md to relate better to `flutter_test`'s codebase
* Updated various fix titles
* Simplified some of the fix tests
* Added "Changes added" comments to lines in fix tests
* Added missing newlines for ends of files
@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 11, 2023
@auto-submit
auto-submit Bot merged commit 6839b3c into flutter:master Apr 11, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 12, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2023
@engine-flutter-autoroll
6839b3c Adds dart_fix support to flutter_test (flutter/flutter#12…
a794697 
…4347)
exaby73 pushed a commit to NevercodeHQ/flutter that referenced this pull request Apr 17, 2023
@pdblasi-google @exaby73
Adds dart_fix support to flutter_test (flutter#124347)
d6f8604 
Adds `dart_fix` support to `flutter_test`
@HansMuller HansMuller mentioned this pull request Apr 20, 2023
Closed
@pdblasi-google
pdblasi-google deleted the issues/123154 branch May 18, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer left review comments
@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

a: animation Animation APIs a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add dart fix capabilities to flutter_test

3 participants

@pdblasi-google @Piinks @goderbauer