Skip to content

Remove deprecations from TextSelectionHandleControls instances - #124611

Merged
justinmc merged 1 commit into
flutter:masterfrom
justinmc:undeprecate-handle-controls-instances
Apr 11, 2023
Merged

justinmc merged 1 commit into
flutter:masterfrom
justinmc:undeprecate-handle-controls-instances

Conversation

@justinmc

Copy link
Copy Markdown
Contributor

Similar to #124262, this undeprecates code that should wait for a round of deprecation removal. In that PR I only undeprecated the class, but I should have undeprecated these instances as well.

This should be deprecated again after TextSelectionControls.buildToolbar has been deleted.

@justinmc
justinmc requested a review from Renzo-Olivares April 11, 2023 18:19
@justinmc justinmc self-assigned this Apr 11, 2023
@flutter-dashboard flutter-dashboard Bot added a: text input Entering text in a text field or keyboard related problems p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Apr 11, 2023
@justinmc
justinmc marked this pull request as ready for review April 11, 2023 18:55

@Renzo-Olivares Renzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinmc
justinmc merged commit f5c1fb1 into flutter:master Apr 11, 2023
@justinmc
justinmc deleted the undeprecate-handle-controls-instances branch April 11, 2023 23:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2023
exaby73 pushed a commit to exaby73/flutter_nevercode that referenced this pull request Apr 17, 2023
…er#124611)

Moves to a two-step deprecation process for context menus, avoiding immediate breaking changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants