Dismiss the docked search view when the window size is changed by QuncCccccc · Pull Request #125071 · flutter/flutter

QuncCccccc · 2023-04-18T22:18:32Z

Fixes #125073

This PR is to make an improvement for SearchAnchor. When the window size changes, the search view route should:

be popped, if search view is docked(not full-screen).
stay open, if it is a full-screen search view.

PR_desktop_demo.mov

PR_mobile_demo.mov

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

HansMuller · 2023-04-19T00:12:13Z

-            _viewRect = topLeft & updatedViewSize;
-        }
-      });
+      assert(_screenSize != null);


It looks like the previous line be

_screenSize = updatedScreenSize!;

Ah yes. Removed the assert check. Thanks!

HansMuller

LGTM

flutter/flutter#125071)

Dissmiss docked search view when window size is changed

cfeeaab

flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Apr 18, 2023

QuncCccccc added 3 commits April 18, 2023 15:44

Update API doc

287d327

Update doc and test message

1f087ab

Update tests

40328f7

QuncCccccc marked this pull request as ready for review April 18, 2023 22:51

QuncCccccc requested a review from HansMuller April 18, 2023 22:51

HansMuller reviewed Apr 19, 2023

View reviewed changes

Remove unnecessary assert check

3c43201

HansMuller approved these changes Apr 19, 2023

View reviewed changes

QuncCccccc merged commit 4c6929d into flutter:master Apr 19, 2023

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to 9f2e7088310d (19 revisions) flutter/packages#3771

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

4c6929d Dismiss the docked search view when the window size is changed (

269a619

flutter/flutter#125071)

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to 64591356b968 (20 revisions) flutter/packages#3773

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

4c6929d Dismiss the docked search view when the window size is changed (

5b01a2f

flutter/flutter#125071)

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to 70ca469792ce (21 revisions) flutter/packages#3775

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

4c6929d Dismiss the docked search view when the window size is changed (

3f2bba2

flutter/flutter#125071)

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to 0d023144d993 (25 revisions) flutter/packages#3777

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

4c6929d Dismiss the docked search view when the window size is changed (

d0c21ca

flutter/flutter#125071)

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to 13f4fe409158 (26 revisions) flutter/packages#3778

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

4c6929d Dismiss the docked search view when the window size is changed (

11c9f4a

flutter/flutter#125071)

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to 5764404f5c97 (27 revisions) flutter/packages#3779

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

4c6929d Dismiss the docked search view when the window size is changed (

2636d33

flutter/flutter#125071)

engine-flutter-autoroll mentioned this pull request Apr 20, 2023

Roll Flutter from 3476b966524f to d85e2fb810b6 (28 revisions) flutter/packages#3781

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2023

4c6929d Dismiss the docked search view when the window size is changed (

3ec03b7

flutter/flutter#125071)

This was referenced Apr 20, 2023

i123636 android embedding v2 agp gradle kotlin update #125256

Closed

[integration_test] add support for agp8.0 #125310

Closed

engine-flutter-autoroll mentioned this pull request Apr 21, 2023

Roll Flutter from 3476b966524f to 8784eb1d8e30 (46 revisions) flutter/packages#3788

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023

4c6929d Dismiss the docked search view when the window size is changed (

0be48bd

flutter/flutter#125071)

HansMuller mentioned this pull request Apr 21, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll mentioned this pull request Apr 21, 2023

Roll Flutter from 3476b966524f to c9004ff822cf (47 revisions) flutter/packages#3790

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023

4c6929d Dismiss the docked search view when the window size is changed (

1924199

flutter/flutter#125071)

reidbaker mentioned this pull request Apr 21, 2023

Test AGP 8.0 using java 17 #125323

Merged

8 tasks done

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023

4c6929d Dismiss the docked search view when the window size is changed (

dd55076

flutter/flutter#125071)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023

4c6929d Dismiss the docked search view when the window size is changed (

4cfdca9

flutter/flutter#125071)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023

4c6929d Dismiss the docked search view when the window size is changed (

1832a61

flutter/flutter#125071)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023

4c6929d Dismiss the docked search view when the window size is changed (

7336753

flutter/flutter#125071)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023

4c6929d Dismiss the docked search view when the window size is changed (

3ce858b

flutter/flutter#125071)

engine-flutter-autoroll mentioned this pull request Apr 24, 2023

Manual roll Flutter from 3476b966524f to d85e2fb810b6 (28 revisions) flutter/packages#3807

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023

4c6929d Dismiss the docked search view when the window size is changed (

bbb09f7

flutter/flutter#125071)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023

4c6929d Dismiss the docked search view when the window size is changed (

eee0541

flutter/flutter#125071)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023

4c6929d Dismiss the docked search view when the window size is changed (

a2bfb5e

flutter/flutter#125071)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023

4c6929d Dismiss the docked search view when the window size is changed (

ba33ded

flutter/flutter#125071)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

4c6929d Dismiss the docked search view when the window size is changed (

6864ba5

flutter/flutter#125071)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

4c6929d Dismiss the docked search view when the window size is changed (

808f629

flutter/flutter#125071)

Navigation Menu

Repository navigation

Dismiss the docked search view when the window size is changed - #125071

Dismiss the docked search view when the window size is changed#125071
QuncCccccc merged 5 commits into
flutter:masterfrom
QuncCccccc:dissmiss_view_if_window_changes

QuncCccccc commented Apr 18, 2023 •

edited

Loading

Uh oh!

HansMuller Apr 19, 2023

Uh oh!

QuncCccccc Apr 19, 2023

Uh oh!

HansMuller left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

QuncCccccc commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

HansMuller Apr 19, 2023

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Apr 19, 2023

Choose a reason for hiding this comment

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

QuncCccccc commented Apr 18, 2023 •

edited

Loading