Skip to content

Toolbar should re-appear on drag end - #125165

Merged
auto-submit[bot] merged 6 commits into
flutter:masterfrom
Renzo-Olivares:ios-drag-fix
Apr 20, 2023
Merged

Toolbar should re-appear on drag end#125165
auto-submit[bot] merged 6 commits into
flutter:masterfrom
Renzo-Olivares:ios-drag-fix

Conversation

@Renzo-Olivares

@Renzo-Olivares Renzo-Olivares commented Apr 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

#125151 introduced the magnifier on touch drag gestures, but when showing the magnifier the toolbar is implicitly hidden, this change makes the toolbar re-appear on drag end for double tap + drag.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added a: text input Entering text in a text field or keyboard related problems p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Apr 19, 2023
@Renzo-Olivares Renzo-Olivares changed the title Toolbar should hide when dragging on text Toolbar should re-appear on drag end Apr 20, 2023
@flutter-dashboard flutter-dashboard Bot added the p: cupertino_ui cupertino_ui package in flutter/packages label Apr 20, 2023
@Renzo-Olivares
Renzo-Olivares marked this pull request as ready for review April 20, 2023 06:21
@Renzo-Olivares
Renzo-Olivares requested a review from justinmc April 20, 2023 16:22
justinmc
justinmc approved these changes Apr 20, 2023
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch, thanks for fixing this so quick. LGTM 👍

@Renzo-Olivares Renzo-Olivares added autosubmit Merge PR when tree becomes green via auto submit App and removed autosubmit Merge PR when tree becomes green via auto submit App labels Apr 20, 2023
@auto-submit
auto-submit Bot merged commit 01b4dd5 into flutter:master Apr 20, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
01b4dd5 Toolbar should re-appear on drag end (flutter/flutter#125165)
f5eaa0f
@HansMuller HansMuller mentioned this pull request Apr 21, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 21, 2023
@engine-flutter-autoroll
01b4dd5 Toolbar should re-appear on drag end (flutter/flutter#125165)
cf9514a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
01b4dd5 Toolbar should re-appear on drag end (flutter/flutter#125165)
0ad96db
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 22, 2023
@engine-flutter-autoroll
01b4dd5 Toolbar should re-appear on drag end (flutter/flutter#125165)
cd33922
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
01b4dd5 Toolbar should re-appear on drag end (flutter/flutter#125165)
81491c1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 23, 2023
@engine-flutter-autoroll
01b4dd5 Toolbar should re-appear on drag end (flutter/flutter#125165)
51ef038
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
01b4dd5 Toolbar should re-appear on drag end (flutter/flutter#125165)
ea3e43b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
01b4dd5 Toolbar should re-appear on drag end (flutter/flutter#125165)
15c622e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
01b4dd5 Toolbar should re-appear on drag end (flutter/flutter#125165)
c7f9b03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 24, 2023
@engine-flutter-autoroll
01b4dd5 Toolbar should re-appear on drag end (flutter/flutter#125165)
ccd99bc
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
01b4dd5 Toolbar should re-appear on drag end (flutter/flutter#125165)
8df70d0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023
@engine-flutter-autoroll
01b4dd5 Toolbar should re-appear on drag end (flutter/flutter#125165)
e5fbc85
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Renzo-Olivares @justinmc