Add backend texture support (eg video, camera) by mravn-google · Pull Request #12525 · flutter/flutter

mravn-google · 2017-10-13T09:43:26Z

Adds support for mapping a backend texture to a rectangular widget. This enables the creation of plugins for inline video, camera, OpenGL, etc.

Corresponding flutter/engine PR: flutter-team-archive/engine/pull/4159.

An end-to-end test is wip.

Hixie · 2017-10-18T21:33:19Z

+  final Rect rect;
+
+  /// Identity of the backend texture.
+  final int textureId;


what's the namespace of the textureIds? If a developer starts passing random values here, or walks up all the values possible, what are the implications?

Hixie · 2017-10-18T21:33:50Z


+/// A composited layer that maps a backend texture to a rectangle.
+///
+/// Texture layers are always leaves in the layer tree.


this should discuss where you get a "backend texture" and what it means.

Hixie · 2017-10-18T21:33:57Z

+  /// Bounding rectangle of this layer.
+  final Rect rect;
+
+  /// Identity of the backend texture.


this should document where you get this number.

Done (in the class-level documentation on all three classes).

Hixie · 2017-10-18T21:34:04Z

@@ -0,0 +1,66 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.


Hixie · 2017-10-18T21:34:48Z

+  int _textureId;
+
+  /// Sets the identity of the backend texture to map.
+  set textureId(int value) {


can this value be null?

looks like yes; please document that it can be null and define what this means

A null texture ID is now considered an error.

Done.

Hixie · 2017-10-18T21:35:23Z

+  }
+
+  /// The identity of the backend texture.
+  int get textureId => _textureId;


please order these as follows:

/// documentation getter; final _field; /// documentation (if it is meaningfully different than the getter's) setter;

(without blank lines)

Hixie · 2017-10-18T21:35:52Z

+  void paint(PaintingContext context, Offset offset) {
+    if (_textureId == null) {
+      return;
+    }


Hixie · 2017-10-18T21:36:54Z

+  void updateRenderObject(BuildContext context, TextureBox renderObject) {
+    renderObject.textureId = textureId;
+  }
+}


(remember to propagate documentation updates to this class too)

Hixie · 2017-10-18T21:37:04Z

tests?

Hixie · 2017-10-18T21:37:16Z

sroddy · 2017-10-23T11:34:02Z

Sorry to bother,
is there an ETA for this, and the corresponding engine counterpart?
It's quite a road blocker for our adoption of the Flutter platform...

Thank you a lot.

mravn-google · 2017-10-23T12:15:40Z

@sroddy Thanks for your interest. We're actively working on it; hoping to land within a week or so.

MichaelSowah · 2017-10-24T06:13:22Z

that would be a lifesaver because its a big road blocker in mine and quite a number of other apps on my table (which I will use flutter at all cost) too so I have been waiting like forever...if this is done does that help with maps too? @mravn-google

mravn-google

Thanks for the review. PTAL.

mravn-google · 2017-10-24T09:04:22Z

@@ -0,0 +1,66 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.


mravn-google · 2017-10-24T09:11:38Z

+  }
+
+  /// The identity of the backend texture.
+  int get textureId => _textureId;


mravn-google · 2017-10-24T09:15:13Z

+  int _textureId;
+
+  /// Sets the identity of the backend texture to map.
+  set textureId(int value) {


A null texture ID is now considered an error.

Done.

mravn-google · 2017-10-24T09:43:02Z


+/// A composited layer that maps a backend texture to a rectangle.
+///
+/// Texture layers are always leaves in the layer tree.


mravn-google · 2017-10-24T09:43:46Z

+  void paint(PaintingContext context, Offset offset) {
+    if (_textureId == null) {
+      return;
+    }


mravn-google · 2017-10-24T10:24:32Z

+  void updateRenderObject(BuildContext context, TextureBox renderObject) {
+    renderObject.textureId = textureId;
+  }
+}


mravn-google · 2017-10-24T10:24:54Z

+  /// Bounding rectangle of this layer.
+  final Rect rect;
+
+  /// Identity of the backend texture.


Done (in the class-level documentation on all three classes).

mravn-google · 2017-10-26T08:40:54Z

+  final Rect rect;
+
+  /// Identity of the backend texture.
+  final int textureId;


mravn-google · 2017-10-26T09:40:10Z

@MichaelSowah I do not yet know what it would take to have native map components render into a provided texture. On top of that, we'd have to relay gestures to the native component, probably allowing Flutter to filter those gestures (in case Flutter has added overlays). Experiments will begin once this PR lands.

MichaelSowah · 2017-10-26T11:44:02Z

Thanks, For starters videos and camera, as you are trying to do here will be a great start for me to be able to lunch the apps for my clients...I hope and pray it lands soon like within the week as you or so as you said , just keeping my fingers crossed for this week and next week @mravn-google

googlebot added the cla: yes label Oct 13, 2017

chinmaygarde mentioned this pull request Oct 13, 2017

Add texture support (eg video, camera) flutter-team-archive/engine#4159

Merged

Hixie reviewed Oct 18, 2017

View reviewed changes

mravn-google commented Oct 26, 2017

View reviewed changes

mravn-google force-pushed the video branch from 549ac1b to 9c44e3d Compare October 27, 2017 13:38

mravn-google added 6 commits November 2, 2017 11:40

Add video support

96468c8

Add placeholder dartdoc to public members

f8b989d

Rename to texture

a0c1b82

Add dart doc

6e6308f

Review comments

c53f25c

Roll engine to get texture support

b8cdf8e

mravn-google force-pushed the video branch from 2e07c27 to b8cdf8e Compare November 2, 2017 10:43

mravn-google added 2 commits November 2, 2017 12:38

Fix import or @required

462c784

Roll engine

c9ea69f

mravn-google merged commit 005a8e4 into master Nov 2, 2017

mravn-google mentioned this pull request Nov 2, 2017

Flutter needs a way to play inline video #2319

Closed

Hixie deleted the video branch November 24, 2017 23:30

DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018

Add backend texture support (eg video, camera) (flutter#12525)

8773dac

github-actions Bot locked as resolved and limited conversation to collaborators Aug 12, 2021

		@@ -0,0 +1,66 @@
		// Copyright 2015 The Chromium Authors. All rights reserved.

Conversation

mravn-google commented Oct 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Hixie commented Oct 18, 2017

Uh oh!

Hixie commented Oct 18, 2017

Uh oh!

sroddy commented Oct 23, 2017

Uh oh!

mravn-google commented Oct 23, 2017

Uh oh!

MichaelSowah commented Oct 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mravn-google left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mravn-google commented Oct 26, 2017

Uh oh!

MichaelSowah commented Oct 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

mravn-google commented Oct 13, 2017 •

edited

Loading

MichaelSowah commented Oct 24, 2017 •

edited

Loading