Skip to content

Add namespace to Android plugin templates - #126354

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
stuartmorgan-g:plugin-template-android-namespace
May 12, 2023
Merged

Add namespace to Android plugin templates#126354
auto-submit[bot] merged 3 commits into
flutter:masterfrom
stuartmorgan-g:plugin-template-android-namespace

Conversation

@stuartmorgan-g

@stuartmorgan-g stuartmorgan-g commented May 9, 2023

Copy link
Copy Markdown
Contributor

Adds the namespace property necessary for AGP 8 compatibility to the plugin templates, with the conditional logic to ensure that it doesn't break AGP <4.2, so that new plugins will be maximally compatible.

Part of #125181

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g
Add namespace to Android plugin templates
419a891 
Adds the `namespace` property necessary for AGP 8 compatibility to the
plugin templates, with the conditional logic to ensure that it doesn't
break AGP <4.2, so that new plugins will be maximally compatible.

Part of flutter#125181
@stuartmorgan-g
stuartmorgan-g requested a review from reidbaker May 9, 2023 18:13
@flutter-dashboard flutter-dashboard Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 9, 2023
@reidbaker reidbaker mentioned this pull request May 10, 2023
Closed
2 tasks done
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 12, 2023
@auto-submit
auto-submit Bot merged commit aa23014 into flutter:master May 12, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
23b49f4 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
f7ce5ce 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
59ad43d 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
cd374e2 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
6cbb727 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
f694344 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
733e49e 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
0edd842 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
70a1fff 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 15, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
43a28d3 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
cf9b9d9 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
fde449e 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
b5f8417 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
2744ad5 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
64a82ce 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
e6ad3c6 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
1c95492 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
aa9ac02 
…6354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
98e1953 
…6354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
232f92c 
…6354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
1fa5ac8 
…6354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
ae902bf 
…6354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
976537b 
…6354)
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@stuartmorgan-g Casey Hillers
Add namespace to Android plugin templates (flutter#126354)
1ade14e 
Adds the `namespace` property necessary for AGP 8 compatibility to the plugin templates, with the conditional logic to ensure that it doesn't break AGP <4.2, so that new plugins will be maximally compatible.

Part of flutter#125181
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
71b754d 
…6354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
7bb0b15 
…6354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
9547e69 
…6354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
aa23014 Add namespace to Android plugin templates (flutter/flutter#12…
c679df2 
…6354)
@deckerst deckerst mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g @reidbaker