Skip to content

Remove outdated comment - #126927

Merged
auto-submit[bot] merged 1 commit into
masterfrom
goderbauer-patch-1
May 16, 2023
Merged

auto-submit[bot] merged 1 commit into
masterfrom
goderbauer-patch-1

Conversation

@goderbauer

Copy link
Copy Markdown
Member

Follow-up to #126647 (comment).

@goderbauer
goderbauer requested a review from Hixie May 16, 2023 16:30
@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label May 16, 2023
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie

Hixie commented May 16, 2023

Copy link
Copy Markdown
Contributor

test-exempt: removes comment

@Hixie Hixie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2023
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2023
@auto-submit

auto-submit Bot commented May 16, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 126927, Mergeability of pull request flutter/flutter/126927 could not be determined at time of merge..

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2023
@auto-submit
auto-submit Bot merged commit 1ca183d into master May 16, 2023
@auto-submit
auto-submit Bot deleted the goderbauer-patch-1 branch May 16, 2023 17:39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants