Repository navigation
Support value announcement for increase/decrease - #12741
Merged
Merged
Conversation
This was referenced Oct 26, 2017
| /// If non-null, sets the [SemanticsNode.increasedValue] semantic to the given | ||
| /// value. | ||
| /// | ||
| /// The text's reading direction is given by [textDirection]. |
Contributor
There was a problem hiding this comment.
"The reading direction is given by [textDirection]."
(yours is grammatically correct, just awkward to read)
Fix here and in packages/flutter/lib/src/rendering/semantics.dart, it seems to have replicated itself in a bunch of places.
| /// | ||
| /// This must not be null if [label], [hint], or [value] is not null. | ||
| /// This must not be null if [label], [hint], [value], [increasedValue], or | ||
| /// [decreasedValue] is not null. |
| /// | ||
| /// If a value is provided, [onIncrease] must also be set and there must | ||
| /// either be an ambient [Directionality] or an explicit [textDirection] | ||
| /// has to be provided. |
Contributor
There was a problem hiding this comment.
"has to be" --> "must be"
and below.
| semantics.dispose(); | ||
| }); | ||
|
|
||
| testWidgets('Increased/decreased values are annotated', (WidgetTester tester) async { |
Contributor
There was a problem hiding this comment.
If it's possible to test, it would be good to test that some of the complex assertions are in place. For example, trying to give null to increasedValue, or supply one and not the other, etc.
Contributor
|
|
gspencergoog
approved these changes
Oct 31, 2017
goderbauer
added
the
a: accessibility
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Support value announcment for increase/decrease * ++ * review comments about docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engine changes in flutter-team-archive/engine#4282.