Skip to content

Revised Floating Action Button examples - #128058

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
HansMuller:update_fab_examples
Jun 1, 2023
Merged

Revised Floating Action Button examples#128058
auto-submit[bot] merged 4 commits into
flutter:masterfrom
HansMuller:update_fab_examples

Conversation

@HansMuller

@HansMuller HansMuller commented Jun 1, 2023

Copy link
Copy Markdown
Contributor

Of the original 4 examples, the first 3 mostly covered the same API features and occupied quite a bit of real-estate at the top of https://api.flutter.dev/flutter/material/FloatingActionButton-class.html. Additionally the illustrations and the code samples didn't match in some cases.

Replaced examples 0,1,2 with one example that changes attributes of the FAB when it's pushed.

Fixes #128048

@flutter-dashboard flutter-dashboard Bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jun 1, 2023
@HansMuller
HansMuller requested a review from QuncCccccc June 1, 2023 17:15
@CaseyHillers CaseyHillers mentioned this pull request Jun 1, 2023
Closed
@HansMuller
HansMuller force-pushed the update_fab_examples branch from e927522 to 98e8fe4 Compare June 1, 2023 17:28
@HansMuller
HansMuller force-pushed the update_fab_examples branch from a866954 to 3f946ce Compare June 1, 2023 18:20
QuncCccccc
QuncCccccc approved these changes Jun 1, 2023
View reviewed changes

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

Comment thread packages/flutter/lib/src/material/floating_action_button.dart
/// [Scaffold], with a pink [backgroundColor] and a thumbs up [Icon].
///
/// ![](https://flutter.github.io/assets-for-api-docs/assets/material/floating_action_button.png)
/// This example shows a [FloatingActionButton] in its usual position within a

@QuncCccccc QuncCccccc Jun 1, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to mention this example is showing the Material 3 FAB?

@HansMuller HansMuller Jun 1, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we'll be updating all the examples to say that when we make M3 the default, so I think it's OK to leave that qualification out here.

@QuncCccccc QuncCccccc Jun 1, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see!

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 1, 2023
@auto-submit
auto-submit Bot merged commit 1a098ae into flutter:master Jun 1, 2023
@HansMuller
HansMuller deleted the update_fab_examples branch June 1, 2023 22:21
@HansMuller HansMuller mentioned this pull request Jun 2, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2023
@engine-flutter-autoroll
1a098ae Revised Floating Action Button examples (flutter/flutter#128058)
2272836
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jun 5, 2023
@engine-flutter-autoroll
Roll Flutter from 3db9504 to 0b74153 (108 revisions) (#4135)
db4e5c2 
Roll Flutter from 3db9504 to 0b74153 (108 revisions)

flutter/flutter@3db9504...0b74153

2023-06-03 [email protected] Roll Flutter Engine from 54293721816a to c838a1b05924 (2 revisions) (flutter/flutter#128161)
2023-06-03 [email protected] Roll Flutter Engine from 8769e9ce3a90 to 54293721816a (8 revisions) (flutter/flutter#128158)
2023-06-03 [email protected] Prefix for dart:ui multiview change (flutter/flutter#128152)
2023-06-02 [email protected] Roll dds dependency to 2.8.3 for expression evaluation upcoming fixes. (flutter/flutter#128124)
2023-06-02 [email protected] Roll Flutter Engine from f3f6a020595d to 8769e9ce3a90 (3 revisions) (flutter/flutter#128149)
2023-06-02 [email protected] Roll Flutter Engine from b4250acbf3ca to f3f6a020595d (3 revisions) (flutter/flutter#128147)
2023-06-02 [email protected] Reland "Remove obsolete drawShadow bounds workaround (#127052)" (flutter/flutter#127231)
2023-06-02 [email protected] Roll Flutter Engine from c6e9383f2143 to b4250acbf3ca (8 revisions) (flutter/flutter#128142)
2023-06-02 [email protected] Pre-migration for dart:ui multi view changes (flutter/flutter#128092)
2023-06-02 [email protected] Remove LiveTestRenderView (flutter/flutter#127882)
2023-06-02 [email protected] Roll Flutter Engine from 02d6fbb68b69 to c6e9383f2143 (15 revisions) (flutter/flutter#128119)
2023-06-02 [email protected] Tiny remove unnecessary method in text_selection.dart (flutter/flutter#127480)
2023-06-02 [email protected] Workaround for Dart VM timeout (flutter/flutter#127875)
2023-06-02 [email protected] Make --flutter-repo analyze whole repo (flutter/flutter#127990)
2023-06-02 [email protected] Roll Packages from f0513ae to 75085ed (3 revisions) (flutter/flutter#128121)
2023-06-02 [email protected] [Refactor] fix quote style in template (flutter/flutter#127762)
2023-06-02 [email protected] Roll Flutter Engine from 3a453f2ccb77 to 02d6fbb68b69 (14 revisions) (flutter/flutter#128089)
2023-06-02 [email protected] Fix typos in labels (flutter/flutter#128093)
2023-06-02 [email protected] Revert "Fix issue where DevTools would not be immediately available when using --start-paused" (flutter/flutter#128117)
2023-06-02 [email protected] Sync Lints (flutter/flutter#127976)
2023-06-02 [email protected] Updated TabBar and ToggleButtons examples (flutter/flutter#128088)
2023-06-02 [email protected] Text should still be centered when search bar height is less than 48 (flutter/flutter#128068)
2023-06-02 [email protected] Roll pub packages (flutter/flutter#128053)
2023-06-01 [email protected] Add `FilterChip.elevated`, `ChoiceChip.elevated`, & `ActionChip.elevated` variants (flutter/flutter#128049)
2023-06-01 [email protected] Updated custom ListTile examples (flutter/flutter#128071)
2023-06-01 [email protected] Fix issue where DevTools would not be immediately available when using --start-paused (flutter/flutter#126698)
2023-06-01 [email protected] Add error message when sliver overlap absorber is missing (flutter/flutter#128075)
2023-06-01 [email protected] Updated Menu examples (flutter/flutter#128080)
2023-06-01 [email protected] Add retry flag to flutter_test (flutter/flutter#125851)
2023-06-01 [email protected] [flutter_tools] Use process matcher for multidex test (flutter/flutter#127996)
2023-06-01 [email protected] Updated InputDecoratorExamples for M3 (flutter/flutter#128065)
2023-06-01 [email protected] Roll Flutter Engine from 7c0a639efd0a to 3a453f2ccb77 (1 revision) (flutter/flutter#128064)
2023-06-01 [email protected] migrate the package_autoroller from querying by label to title (flutter/flutter#128066)
2023-06-01 [email protected] Revised Floating Action Button examples (flutter/flutter#128058)
2023-06-01 [email protected] Roll Flutter Engine from fdd39c421fb9 to 7c0a639efd0a (2 revisions) (flutter/flutter#128056)
2023-06-01 [email protected] Roll Flutter Engine from c8e1a8d6fb57 to fdd39c421fb9 (1 revision) (flutter/flutter#128050)
2023-06-01 [email protected] [labeler] Remove use of any (flutter/flutter#128011)
2023-06-01 [email protected] [framework] remove reference to closed issue. (flutter/flutter#128007)
2023-06-01 [email protected] Roll Packages from 95bb793 to f0513ae (3 revisions) (flutter/flutter#128045)
2023-06-01 [email protected] Add fallback font to IconData class (flutter/flutter#127269)
2023-06-01 [email protected] [web] Assert route names start with / if using PathUrlStrategy (flutter/flutter#127986)
2023-06-01 [email protected] [tool] In `flutter doctor -v`, warn when Android Studio version could not be detected. (flutter/flutter#126395)
2023-06-01 [email protected] Roll Flutter Engine from 8339c71a963c to c8e1a8d6fb57 (1 revision) (flutter/flutter#128035)
2023-06-01 [email protected] Roll Flutter Engine from bc81133892a6 to 8339c71a963c (1 revision) (flutter/flutter#128034)
2023-06-01 [email protected] Roll Flutter Engine from e235f47164fa to bc81133892a6 (1 revision) (flutter/flutter#128026)
2023-06-01 [email protected] Fixes in Cupertino translations (flutter/flutter#127872)
...
@HansMuller HansMuller mentioned this pull request May 18, 2023
Closed
25 tasks done
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
1a098ae Revised Floating Action Button examples (flutter/flutter#128058)
51486dd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
1a098ae Revised Floating Action Button examples (flutter/flutter#128058)
b58fd5c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
1a098ae Revised Floating Action Button examples (flutter/flutter#128058)
0f489cb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
1a098ae Revised Floating Action Button examples (flutter/flutter#128058)
e3dacc4
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from 3db9504 to 0b74153 (108 revisions) (flutter#4135)
311610f 
Roll Flutter from 3db9504 to 0b74153 (108 revisions)

flutter/flutter@3db9504...0b74153

2023-06-03 [email protected] Roll Flutter Engine from 54293721816a to c838a1b05924 (2 revisions) (flutter/flutter#128161)
2023-06-03 [email protected] Roll Flutter Engine from 8769e9ce3a90 to 54293721816a (8 revisions) (flutter/flutter#128158)
2023-06-03 [email protected] Prefix for dart:ui multiview change (flutter/flutter#128152)
2023-06-02 [email protected] Roll dds dependency to 2.8.3 for expression evaluation upcoming fixes. (flutter/flutter#128124)
2023-06-02 [email protected] Roll Flutter Engine from f3f6a020595d to 8769e9ce3a90 (3 revisions) (flutter/flutter#128149)
2023-06-02 [email protected] Roll Flutter Engine from b4250acbf3ca to f3f6a020595d (3 revisions) (flutter/flutter#128147)
2023-06-02 [email protected] Reland "Remove obsolete drawShadow bounds workaround (#127052)" (flutter/flutter#127231)
2023-06-02 [email protected] Roll Flutter Engine from c6e9383f2143 to b4250acbf3ca (8 revisions) (flutter/flutter#128142)
2023-06-02 [email protected] Pre-migration for dart:ui multi view changes (flutter/flutter#128092)
2023-06-02 [email protected] Remove LiveTestRenderView (flutter/flutter#127882)
2023-06-02 [email protected] Roll Flutter Engine from 02d6fbb68b69 to c6e9383f2143 (15 revisions) (flutter/flutter#128119)
2023-06-02 [email protected] Tiny remove unnecessary method in text_selection.dart (flutter/flutter#127480)
2023-06-02 [email protected] Workaround for Dart VM timeout (flutter/flutter#127875)
2023-06-02 [email protected] Make --flutter-repo analyze whole repo (flutter/flutter#127990)
2023-06-02 [email protected] Roll Packages from f0513ae to 75085ed (3 revisions) (flutter/flutter#128121)
2023-06-02 [email protected] [Refactor] fix quote style in template (flutter/flutter#127762)
2023-06-02 [email protected] Roll Flutter Engine from 3a453f2ccb77 to 02d6fbb68b69 (14 revisions) (flutter/flutter#128089)
2023-06-02 [email protected] Fix typos in labels (flutter/flutter#128093)
2023-06-02 [email protected] Revert "Fix issue where DevTools would not be immediately available when using --start-paused" (flutter/flutter#128117)
2023-06-02 [email protected] Sync Lints (flutter/flutter#127976)
2023-06-02 [email protected] Updated TabBar and ToggleButtons examples (flutter/flutter#128088)
2023-06-02 [email protected] Text should still be centered when search bar height is less than 48 (flutter/flutter#128068)
2023-06-02 [email protected] Roll pub packages (flutter/flutter#128053)
2023-06-01 [email protected] Add `FilterChip.elevated`, `ChoiceChip.elevated`, & `ActionChip.elevated` variants (flutter/flutter#128049)
2023-06-01 [email protected] Updated custom ListTile examples (flutter/flutter#128071)
2023-06-01 [email protected] Fix issue where DevTools would not be immediately available when using --start-paused (flutter/flutter#126698)
2023-06-01 [email protected] Add error message when sliver overlap absorber is missing (flutter/flutter#128075)
2023-06-01 [email protected] Updated Menu examples (flutter/flutter#128080)
2023-06-01 [email protected] Add retry flag to flutter_test (flutter/flutter#125851)
2023-06-01 [email protected] [flutter_tools] Use process matcher for multidex test (flutter/flutter#127996)
2023-06-01 [email protected] Updated InputDecoratorExamples for M3 (flutter/flutter#128065)
2023-06-01 [email protected] Roll Flutter Engine from 7c0a639efd0a to 3a453f2ccb77 (1 revision) (flutter/flutter#128064)
2023-06-01 [email protected] migrate the package_autoroller from querying by label to title (flutter/flutter#128066)
2023-06-01 [email protected] Revised Floating Action Button examples (flutter/flutter#128058)
2023-06-01 [email protected] Roll Flutter Engine from fdd39c421fb9 to 7c0a639efd0a (2 revisions) (flutter/flutter#128056)
2023-06-01 [email protected] Roll Flutter Engine from c8e1a8d6fb57 to fdd39c421fb9 (1 revision) (flutter/flutter#128050)
2023-06-01 [email protected] [labeler] Remove use of any (flutter/flutter#128011)
2023-06-01 [email protected] [framework] remove reference to closed issue. (flutter/flutter#128007)
2023-06-01 [email protected] Roll Packages from 95bb793 to f0513ae (3 revisions) (flutter/flutter#128045)
2023-06-01 [email protected] Add fallback font to IconData class (flutter/flutter#127269)
2023-06-01 [email protected] [web] Assert route names start with / if using PathUrlStrategy (flutter/flutter#127986)
2023-06-01 [email protected] [tool] In `flutter doctor -v`, warn when Android Studio version could not be detected. (flutter/flutter#126395)
2023-06-01 [email protected] Roll Flutter Engine from 8339c71a963c to c8e1a8d6fb57 (1 revision) (flutter/flutter#128035)
2023-06-01 [email protected] Roll Flutter Engine from bc81133892a6 to 8339c71a963c (1 revision) (flutter/flutter#128034)
2023-06-01 [email protected] Roll Flutter Engine from e235f47164fa to bc81133892a6 (1 revision) (flutter/flutter#128026)
2023-06-01 [email protected] Fixes in Cupertino translations (flutter/flutter#127872)
...
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Roll Flutter from 3db9504 to 0b74153 (108 revisions) (flutter#4135)
2332caa 
Roll Flutter from 3db9504 to 0b74153 (108 revisions)

flutter/flutter@3db9504...0b74153

2023-06-03 [email protected] Roll Flutter Engine from 54293721816a to c838a1b05924 (2 revisions) (flutter/flutter#128161)
2023-06-03 [email protected] Roll Flutter Engine from 8769e9ce3a90 to 54293721816a (8 revisions) (flutter/flutter#128158)
2023-06-03 [email protected] Prefix for dart:ui multiview change (flutter/flutter#128152)
2023-06-02 [email protected] Roll dds dependency to 2.8.3 for expression evaluation upcoming fixes. (flutter/flutter#128124)
2023-06-02 [email protected] Roll Flutter Engine from f3f6a020595d to 8769e9ce3a90 (3 revisions) (flutter/flutter#128149)
2023-06-02 [email protected] Roll Flutter Engine from b4250acbf3ca to f3f6a020595d (3 revisions) (flutter/flutter#128147)
2023-06-02 [email protected] Reland "Remove obsolete drawShadow bounds workaround (#127052)" (flutter/flutter#127231)
2023-06-02 [email protected] Roll Flutter Engine from c6e9383f2143 to b4250acbf3ca (8 revisions) (flutter/flutter#128142)
2023-06-02 [email protected] Pre-migration for dart:ui multi view changes (flutter/flutter#128092)
2023-06-02 [email protected] Remove LiveTestRenderView (flutter/flutter#127882)
2023-06-02 [email protected] Roll Flutter Engine from 02d6fbb68b69 to c6e9383f2143 (15 revisions) (flutter/flutter#128119)
2023-06-02 [email protected] Tiny remove unnecessary method in text_selection.dart (flutter/flutter#127480)
2023-06-02 [email protected] Workaround for Dart VM timeout (flutter/flutter#127875)
2023-06-02 [email protected] Make --flutter-repo analyze whole repo (flutter/flutter#127990)
2023-06-02 [email protected] Roll Packages from b9ed0d6 to 087ad08 (3 revisions) (flutter/flutter#128121)
2023-06-02 [email protected] [Refactor] fix quote style in template (flutter/flutter#127762)
2023-06-02 [email protected] Roll Flutter Engine from 3a453f2ccb77 to 02d6fbb68b69 (14 revisions) (flutter/flutter#128089)
2023-06-02 [email protected] Fix typos in labels (flutter/flutter#128093)
2023-06-02 [email protected] Revert "Fix issue where DevTools would not be immediately available when using --start-paused" (flutter/flutter#128117)
2023-06-02 [email protected] Sync Lints (flutter/flutter#127976)
2023-06-02 [email protected] Updated TabBar and ToggleButtons examples (flutter/flutter#128088)
2023-06-02 [email protected] Text should still be centered when search bar height is less than 48 (flutter/flutter#128068)
2023-06-02 [email protected] Roll pub packages (flutter/flutter#128053)
2023-06-01 [email protected] Add `FilterChip.elevated`, `ChoiceChip.elevated`, & `ActionChip.elevated` variants (flutter/flutter#128049)
2023-06-01 [email protected] Updated custom ListTile examples (flutter/flutter#128071)
2023-06-01 [email protected] Fix issue where DevTools would not be immediately available when using --start-paused (flutter/flutter#126698)
2023-06-01 [email protected] Add error message when sliver overlap absorber is missing (flutter/flutter#128075)
2023-06-01 [email protected] Updated Menu examples (flutter/flutter#128080)
2023-06-01 [email protected] Add retry flag to flutter_test (flutter/flutter#125851)
2023-06-01 [email protected] [flutter_tools] Use process matcher for multidex test (flutter/flutter#127996)
2023-06-01 [email protected] Updated InputDecoratorExamples for M3 (flutter/flutter#128065)
2023-06-01 [email protected] Roll Flutter Engine from 7c0a639efd0a to 3a453f2ccb77 (1 revision) (flutter/flutter#128064)
2023-06-01 [email protected] migrate the package_autoroller from querying by label to title (flutter/flutter#128066)
2023-06-01 [email protected] Revised Floating Action Button examples (flutter/flutter#128058)
2023-06-01 [email protected] Roll Flutter Engine from fdd39c421fb9 to 7c0a639efd0a (2 revisions) (flutter/flutter#128056)
2023-06-01 [email protected] Roll Flutter Engine from c8e1a8d6fb57 to fdd39c421fb9 (1 revision) (flutter/flutter#128050)
2023-06-01 [email protected] [labeler] Remove use of any (flutter/flutter#128011)
2023-06-01 [email protected] [framework] remove reference to closed issue. (flutter/flutter#128007)
2023-06-01 [email protected] Roll Packages from 4429c34 to b9ed0d6 (3 revisions) (flutter/flutter#128045)
2023-06-01 [email protected] Add fallback font to IconData class (flutter/flutter#127269)
2023-06-01 [email protected] [web] Assert route names start with / if using PathUrlStrategy (flutter/flutter#127986)
2023-06-01 [email protected] [tool] In `flutter doctor -v`, warn when Android Studio version could not be detected. (flutter/flutter#126395)
2023-06-01 [email protected] Roll Flutter Engine from 8339c71a963c to c8e1a8d6fb57 (1 revision) (flutter/flutter#128035)
2023-06-01 [email protected] Roll Flutter Engine from bc81133892a6 to 8339c71a963c (1 revision) (flutter/flutter#128034)
2023-06-01 [email protected] Roll Flutter Engine from e235f47164fa to bc81133892a6 (1 revision) (flutter/flutter#128026)
2023-06-01 [email protected] Fixes in Cupertino translations (flutter/flutter#127872)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Floating Action Button sample doesn't match its description

2 participants

@HansMuller @QuncCccccc