Skip to content

[labeler] Set sync labels to false to stop removing labels - #128446

Merged
auto-submit[bot] merged 1 commit into
masterfrom
CaseyHillers-patch-2
Jun 8, 2023
Merged

auto-submit[bot] merged 1 commit into
masterfrom
CaseyHillers-patch-2

Conversation

@CaseyHillers

Copy link
Copy Markdown
Contributor

#128440

The current version of the action has a bug where the sync-labels default value is not read correctly. Explicitly setting to see if that stops the removals.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@CaseyHillers
CaseyHillers requested review from Piinks and keyonghan June 7, 2023 18:04
@github-actions github-actions Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jun 7, 2023

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM - thanks for the quick fix!

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2023
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2023
@auto-submit

auto-submit Bot commented Jun 7, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 128446, due to - The status or check suite Windows build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2023
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023
@auto-submit

auto-submit Bot commented Jun 8, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 128446, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023
@auto-submit
auto-submit Bot merged commit 6e254a3 into master Jun 8, 2023
@auto-submit
auto-submit Bot deleted the CaseyHillers-patch-2 branch June 8, 2023 15:44
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 8, 2023
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jun 8, 2023
flutter/flutter@8a5c22e...6e254a3

2023-06-08 [email protected] [labeler] Set sync labels to false to stop removing labels (flutter/flutter#128446)
2023-06-08 [email protected] Update Chrome version for testing (flutter/flutter#128447)
2023-06-08 [email protected] Revert "Redo make inspector weakly referencing the inspected objects." (flutter/flutter#128506)
2023-06-08 [email protected] Use `--target-os` for appropriate precompiled targets. (flutter/flutter#127567)
2023-06-08 [email protected] Redo make inspector weakly referencing the inspected objects. (flutter/flutter#128471)
2023-06-07 [email protected] Roll Flutter Engine from 1089ce6874cf to a5f7d5d75ff2 (11 revisions) (flutter/flutter#128473)
2023-06-07 [email protected] Disable context menu (flutter/flutter#128365)
2023-06-07 [email protected] Adds vmservices to retrieve android applink settings (flutter/flutter#125998)
2023-06-07 [email protected] Roll Flutter Engine from 4f4486b00be2 to 1089ce6874cf (20 revisions) (flutter/flutter#128460)
2023-06-07 [email protected] Fix typos 'wether' -> 'whether' (flutter/flutter#128392)
2023-06-07 [email protected] Roll engine, patch expression evaluation (flutter/flutter#128255)
2023-06-07 [email protected] Roll Packages from da72219 to a84b2c2 (1 revision) (flutter/flutter#128444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@8a5c22e...6e254a3

2023-06-08 [email protected] [labeler] Set sync labels to false to stop removing labels (flutter/flutter#128446)
2023-06-08 [email protected] Update Chrome version for testing (flutter/flutter#128447)
2023-06-08 [email protected] Revert "Redo make inspector weakly referencing the inspected objects." (flutter/flutter#128506)
2023-06-08 [email protected] Use `--target-os` for appropriate precompiled targets. (flutter/flutter#127567)
2023-06-08 [email protected] Redo make inspector weakly referencing the inspected objects. (flutter/flutter#128471)
2023-06-07 [email protected] Roll Flutter Engine from 1089ce6874cf to a5f7d5d75ff2 (11 revisions) (flutter/flutter#128473)
2023-06-07 [email protected] Disable context menu (flutter/flutter#128365)
2023-06-07 [email protected] Adds vmservices to retrieve android applink settings (flutter/flutter#125998)
2023-06-07 [email protected] Roll Flutter Engine from 4f4486b00be2 to 1089ce6874cf (20 revisions) (flutter/flutter#128460)
2023-06-07 [email protected] Fix typos 'wether' -> 'whether' (flutter/flutter#128392)
2023-06-07 [email protected] Roll engine, patch expression evaluation (flutter/flutter#128255)
2023-06-07 [email protected] Roll Packages from da72219 to a84b2c2 (1 revision) (flutter/flutter#128444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter/flutter@8a5c22e...6e254a3

2023-06-08 [email protected] [labeler] Set sync labels to false to stop removing labels (flutter/flutter#128446)
2023-06-08 [email protected] Update Chrome version for testing (flutter/flutter#128447)
2023-06-08 [email protected] Revert "Redo make inspector weakly referencing the inspected objects." (flutter/flutter#128506)
2023-06-08 [email protected] Use `--target-os` for appropriate precompiled targets. (flutter/flutter#127567)
2023-06-08 [email protected] Redo make inspector weakly referencing the inspected objects. (flutter/flutter#128471)
2023-06-07 [email protected] Roll Flutter Engine from 1089ce6874cf to a5f7d5d75ff2 (11 revisions) (flutter/flutter#128473)
2023-06-07 [email protected] Disable context menu (flutter/flutter#128365)
2023-06-07 [email protected] Adds vmservices to retrieve android applink settings (flutter/flutter#125998)
2023-06-07 [email protected] Roll Flutter Engine from 4f4486b00be2 to 1089ce6874cf (20 revisions) (flutter/flutter#128460)
2023-06-07 [email protected] Fix typos 'wether' -> 'whether' (flutter/flutter#128392)
2023-06-07 [email protected] Roll engine, patch expression evaluation (flutter/flutter#128255)
2023-06-07 [email protected] Roll Packages from 2be05f5 to ac06bf0 (1 revision) (flutter/flutter#128444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants