Skip to content

Change the default forThemeData.useMaterial3 to true - #129724

Merged
HansMuller merged 2 commits into
flutter:masterfrom
HansMuller:test_m3_default_update
Jul 13, 2023
Merged

Change the default forThemeData.useMaterial3 to true#129724
HansMuller merged 2 commits into
flutter:masterfrom
HansMuller:test_m3_default_update

Conversation

@HansMuller

@HansMuller HansMuller commented Jun 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes the default for ThemeData.useMaterial3 to true.

See #127064

@flutter-dashboard

flutter-dashboard Bot commented Jun 28, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@HansMuller HansMuller mentioned this pull request Jun 28, 2023
Closed
25 tasks done
@HansMuller
HansMuller force-pushed the test_m3_default_update branch from 3d74d44 to 8ef4eb6 Compare June 30, 2023 16:48
@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Jun 30, 2023
@HansMuller
HansMuller force-pushed the test_m3_default_update branch from d6c1a28 to 8db954e Compare July 10, 2023 15:48
@HansMuller
HansMuller force-pushed the test_m3_default_update branch from 8db954e to 9f6981d Compare July 11, 2023 18:26
@HansMuller HansMuller changed the title (WIP) Verify that making useMaterial3:true is safe Change the default forThemeData.useMaterial3 to true Jul 12, 2023
@HansMuller
HansMuller requested a review from QuncCccccc July 12, 2023 16:23
QuncCccccc
QuncCccccc approved these changes Jul 12, 2023
View reviewed changes

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HansMuller
HansMuller merged commit 157660a into flutter:master Jul 13, 2023
@HansMuller
HansMuller deleted the test_m3_default_update branch July 13, 2023 20:06
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
637e856 
…er/flutter#129724)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
a5e1a60 
…er/flutter#129724)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
9ce4891 
…er/flutter#129724)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
96c98c0 
…er/flutter#129724)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
e7ae7ea 
…er/flutter#129724)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
e1dccfb 
…er/flutter#129724)
@zanderso zanderso mentioned this pull request Jul 14, 2023
Open
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
884fd87 
…er/flutter#129724)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
0132835 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
64d8b81 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
c679fe7 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
edddde2 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
c294418 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
dc01303 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
bf5140d 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
7ccccb0 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
b2bd79e 
…er/flutter#129724)
@chrisbobbe

chrisbobbe commented Jul 17, 2023

Copy link
Copy Markdown
Contributor

I've opened #130761 for updating the doc to reflect this change.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
094fa37 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
e24c937 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
bcc1602 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
ac1c173 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
ccfdd93 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
86f4aae 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
56f4d15 
…er/flutter#129724)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
157660a Change the default forThemeData.useMaterial3 to true (flutt…
cce669b 
…er/flutter#129724)
@gnprice gnprice mentioned this pull request Jul 19, 2023
Closed
3 of 7 tasks
This was referenced Jul 21, 2023
Closed
Merged
auto-submit Bot pushed a commit that referenced this pull request Jul 28, 2023
@HansMuller
Updated integration_tests/platform_interaction test_step.dart (#131301)
c61f07c 
Force the line height of the TextStyle used in test_step.dart to be 1.0 for all Text widgets.

The test started failing after #129724 landed. Assuming that the vertical layout of the test was tight and that the change in the default font's line height is the source of the problem (see #130732 (comment)).

Fixes #130732
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@HansMuller @LouiseHsu
Change the default forThemeData.useMaterial3 to true (flutter#129724)
4f4c2db 
Changes the default for `ThemeData.useMaterial3` to true.

See flutter#127064
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@HansMuller @LouiseHsu
Updated integration_tests/platform_interaction test_step.dart (flutte…
ae111b0 
…r#131301)

Force the line height of the TextStyle used in test_step.dart to be 1.0 for all Text widgets.

The test started failing after flutter#129724 landed. Assuming that the vertical layout of the test was tight and that the change in the default font's line height is the source of the problem (see flutter#130732 (comment)).

Fixes flutter#130732
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
@HansMuller @vashworth
Updated integration_tests/platform_interaction test_step.dart (flutte…
c22e733 
…r#131301)

Force the line height of the TextStyle used in test_step.dart to be 1.0 for all Text widgets.

The test started failing after flutter#129724 landed. Assuming that the vertical layout of the test was tight and that the change in the default font's line height is the source of the problem (see flutter#130732 (comment)).

Fixes flutter#130732
@LongCatIsLooong LongCatIsLooong mentioned this pull request Aug 4, 2023
Closed
2 tasks done
@Abestanis Abestanis mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HansMuller @chrisbobbe @QuncCccccc