Skip to content

Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..." - #130144

Merged
auto-submit[bot] merged 1 commit into
masterfrom
revert-114303-hotfix/page-transitions-theme-2
Jul 7, 2023
Merged

Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..."#130144
auto-submit[bot] merged 1 commit into
masterfrom
revert-114303-hotfix/page-transitions-theme-2

Conversation

@HansMuller

@HansMuller HansMuller commented Jul 7, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #114303

The breaking API change in #114303 broke internal tests/apps (Google internal link b/290154304) as well as external dependents: #130062.

Fixes #130062

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Jul 7, 2023
@HansMuller HansMuller mentioned this pull request Jul 7, 2023
Closed
2 tasks done
@HansMuller
HansMuller requested a review from chunhtai July 7, 2023 15:27
chunhtai
chunhtai approved these changes Jul 7, 2023
View reviewed changes

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2023
@HansMuller HansMuller mentioned this pull request Jul 7, 2023
Merged
6 of 8 tasks
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2023
@auto-submit

auto-submit Bot commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 130144, due to - The status or check suite Linux web_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Jasguerrero Jasguerrero added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2023
@auto-submit
auto-submit Bot merged commit d55a7d8 into master Jul 7, 2023
@auto-submit
auto-submit Bot deleted the revert-114303-hotfix/page-transitions-theme-2 branch July 7, 2023 16:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 7, 2023
@engine-flutter-autoroll
d55a7d8 Revert "fix a bug when android uses CupertinoPageTransitionsB…
10145b1 
…uilder..." (flutter/flutter#130144)
Jasguerrero pushed a commit to Jasguerrero/flutter that referenced this pull request Jul 7, 2023
@HansMuller @Jasguerrero
Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..…
92888fd 
…." (flutter#130144)

Reverts flutter#114303

The breaking API change in flutter#114303 broke internal tests/apps (Google internal link b/290154304) as well as external dependents: flutter#130062. 

Fixes flutter#130062
@Jasguerrero Jasguerrero mentioned this pull request Jul 7, 2023
Merged
CaseyHillers pushed a commit that referenced this pull request Jul 7, 2023
@Jasguerrero @HansMuller
Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..… (
761810a 
#130155)

…." (#130144)

Reverts #114303

The breaking API change in #114303 broke internal
tests/apps (Google internal link b/290154304) as well as external
dependents: #130062.

Co-authored-by: Hans Muller <[email protected]>
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jul 7, 2023
@engine-flutter-autoroll
Roll Flutter from bc49cd1 to d55a7d8 (17 revisions) (#4403)
9914683 
flutter/flutter@bc49cd1...d55a7d8

2023-07-07 [email protected] Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..." (flutter/flutter#130144)
2023-07-07 [email protected] Roll Packages from 771ec9b to 9bcf4bf (12 revisions) (flutter/flutter#130143)
2023-07-07 [email protected] Roll Flutter Engine from 650ff096488a to 8aa2e6516af1 (1 revision) (flutter/flutter#130116)
2023-07-07 [email protected] Roll Flutter Engine from 1fa222fae283 to 650ff096488a (3 revisions) (flutter/flutter#130114)
2023-07-07 [email protected] Roll Flutter Engine from 491f317978f4 to 1fa222fae283 (1 revision) (flutter/flutter#130110)
2023-07-07 [email protected] Roll Flutter Engine from 48bf7ac59254 to 491f317978f4 (2 revisions) (flutter/flutter#130107)
2023-07-06 [email protected] Roll Flutter Engine from 42df55a9e63e to 48bf7ac59254 (1 revision) (flutter/flutter#130106)
2023-07-06 [email protected] Super tiny code optimization: No need to redundantly check whether value has changed (flutter/flutter#130050)
2023-07-06 [email protected] Roll Flutter Engine from 06c936205d96 to 42df55a9e63e (3 revisions) (flutter/flutter#130100)
2023-07-06 [email protected] Manual roll Flutter Engine from bd2e42b203e1 to 06c936205d96 (27 revisions) (flutter/flutter#130097)
2023-07-06 [email protected] Marks Linux firebase_oriol33_abstract_method_smoke_test to be unflaky (flutter/flutter#128398)
2023-07-06 [email protected] Next attempt to make inspector weakly referencing the inspected objects. (flutter/flutter#129962)
2023-07-06 [email protected] [a11y] CupertinoSwitch On/Off labels (flutter/flutter#127776)
2023-07-06 [email protected] Add option for flexible space on material SearchDelegate (flutter/flutter#128132)
2023-07-06 [email protected] Roll Packages from 7042079 to 771ec9b (12 revisions) (flutter/flutter#130077)
2023-07-06 [email protected] [framework] Add textField OCR support for framework side (flutter/flutter#96637)
2023-07-06 [email protected] [flutter_tools] modify Skeleton template to use ListenableBuilder instead of AnimatedBuilder (flutter/flutter#128810)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from bc49cd1 to d55a7d8 (17 revisions) (flutter#4403)
83eaec8 
flutter/flutter@bc49cd1...d55a7d8

2023-07-07 [email protected] Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..." (flutter/flutter#130144)
2023-07-07 [email protected] Roll Packages from 771ec9b to 9bcf4bf (12 revisions) (flutter/flutter#130143)
2023-07-07 [email protected] Roll Flutter Engine from 650ff096488a to 8aa2e6516af1 (1 revision) (flutter/flutter#130116)
2023-07-07 [email protected] Roll Flutter Engine from 1fa222fae283 to 650ff096488a (3 revisions) (flutter/flutter#130114)
2023-07-07 [email protected] Roll Flutter Engine from 491f317978f4 to 1fa222fae283 (1 revision) (flutter/flutter#130110)
2023-07-07 [email protected] Roll Flutter Engine from 48bf7ac59254 to 491f317978f4 (2 revisions) (flutter/flutter#130107)
2023-07-06 [email protected] Roll Flutter Engine from 42df55a9e63e to 48bf7ac59254 (1 revision) (flutter/flutter#130106)
2023-07-06 [email protected] Super tiny code optimization: No need to redundantly check whether value has changed (flutter/flutter#130050)
2023-07-06 [email protected] Roll Flutter Engine from 06c936205d96 to 42df55a9e63e (3 revisions) (flutter/flutter#130100)
2023-07-06 [email protected] Manual roll Flutter Engine from bd2e42b203e1 to 06c936205d96 (27 revisions) (flutter/flutter#130097)
2023-07-06 [email protected] Marks Linux firebase_oriol33_abstract_method_smoke_test to be unflaky (flutter/flutter#128398)
2023-07-06 [email protected] Next attempt to make inspector weakly referencing the inspected objects. (flutter/flutter#129962)
2023-07-06 [email protected] [a11y] CupertinoSwitch On/Off labels (flutter/flutter#127776)
2023-07-06 [email protected] Add option for flexible space on material SearchDelegate (flutter/flutter#128132)
2023-07-06 [email protected] Roll Packages from 7042079 to 771ec9b (12 revisions) (flutter/flutter#130077)
2023-07-06 [email protected] [framework] Add textField OCR support for framework side (flutter/flutter#96637)
2023-07-06 [email protected] [flutter_tools] modify Skeleton template to use ListenableBuilder instead of AnimatedBuilder (flutter/flutter#128810)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Roll Flutter from bc49cd1 to d55a7d8 (17 revisions) (flutter#4403)
03216c9 
flutter/flutter@bc49cd1...d55a7d8

2023-07-07 [email protected] Revert "fix a bug when android uses CupertinoPageTransitionsBuilder..." (flutter/flutter#130144)
2023-07-07 [email protected] Roll Packages from cedd34c to 1b6f41e (12 revisions) (flutter/flutter#130143)
2023-07-07 [email protected] Roll Flutter Engine from 650ff096488a to 8aa2e6516af1 (1 revision) (flutter/flutter#130116)
2023-07-07 [email protected] Roll Flutter Engine from 1fa222fae283 to 650ff096488a (3 revisions) (flutter/flutter#130114)
2023-07-07 [email protected] Roll Flutter Engine from 491f317978f4 to 1fa222fae283 (1 revision) (flutter/flutter#130110)
2023-07-07 [email protected] Roll Flutter Engine from 48bf7ac59254 to 491f317978f4 (2 revisions) (flutter/flutter#130107)
2023-07-06 [email protected] Roll Flutter Engine from 42df55a9e63e to 48bf7ac59254 (1 revision) (flutter/flutter#130106)
2023-07-06 [email protected] Super tiny code optimization: No need to redundantly check whether value has changed (flutter/flutter#130050)
2023-07-06 [email protected] Roll Flutter Engine from 06c936205d96 to 42df55a9e63e (3 revisions) (flutter/flutter#130100)
2023-07-06 [email protected] Manual roll Flutter Engine from bd2e42b203e1 to 06c936205d96 (27 revisions) (flutter/flutter#130097)
2023-07-06 [email protected] Marks Linux firebase_oriol33_abstract_method_smoke_test to be unflaky (flutter/flutter#128398)
2023-07-06 [email protected] Next attempt to make inspector weakly referencing the inspected objects. (flutter/flutter#129962)
2023-07-06 [email protected] [a11y] CupertinoSwitch On/Off labels (flutter/flutter#127776)
2023-07-06 [email protected] Add option for flexible space on material SearchDelegate (flutter/flutter#128132)
2023-07-06 [email protected] Roll Packages from 8b9ce45 to cedd34c (12 revisions) (flutter/flutter#130077)
2023-07-06 [email protected] [framework] Add textField OCR support for framework side (flutter/flutter#96637)
2023-07-06 [email protected] [flutter_tools] modify Skeleton template to use ListenableBuilder instead of AnimatedBuilder (flutter/flutter#128810)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Undue breaking change in buildTransitions breaks dependencies

3 participants

@HansMuller @chunhtai @Jasguerrero