Repository navigation
Fix default icon color constants reversed brightness documentation - #130231
Merged
auto-submit[bot] merged 2 commits intoJul 10, 2023
Merged
auto-submit[bot] merged 2 commits into
auto-submit[bot] merged 2 commits into
Conversation
github-actions
Bot
added
framework
2 tasks done
TahaTesser
added
autosubmit
Contributor
|
This'll need a secondary review from @HansMuller for the |
HansMuller
approved these changes
Jul 10, 2023
HansMuller
left a comment
HansMuller
left a comment
Contributor
There was a problem hiding this comment.
Nice catch, thanks for the fix!
LGTM
HansMuller
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 12, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 12, 2023
gbtb16
pushed a commit
to gbtb16/flutter
that referenced
this pull request
Nov 6, 2023
…lutter#130231) Fixes the reversed default icon color constants brightness documentation for `kDefaultIconLightColor` and `kDefaultIconDarkColor`. FIX: flutter#130230
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the reversed default icon color constants brightness documentation for
kDefaultIconLightColorandkDefaultIconDarkColor.FIX: #130230
Pre-launch Checklist
///).