Skip to content

Use the new rounding hack migration flag in TextPainter - #130548

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
LongCatIsLooong:textpainter-shouldDidableRoundingHack
Jul 14, 2023
Merged

Use the new rounding hack migration flag in TextPainter#130548
auto-submit[bot] merged 1 commit into
flutter:masterfrom
LongCatIsLooong:textpainter-shouldDidableRoundingHack

Conversation

@LongCatIsLooong

@LongCatIsLooong LongCatIsLooong commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages p: cupertino_ui cupertino_ui package in flutter/packages labels Jul 14, 2023
goderbauer
goderbauer approved these changes Jul 14, 2023
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/flutter/lib/src/painting/text_painter.dart
// remove this hack as well as the flooring in `layout`.
@pragma('vm:prefer-inline')
static double _applyFloatingPointHack(double layoutValue) => _shouldApplyFloatingPointHack ? layoutValue.ceilToDouble() : layoutValue;
static double _applyFloatingPointHack(double layoutValue) => ui.ParagraphBuilder.shouldDisableRoundingHack ? layoutValue : layoutValue.ceilToDouble();

@goderbauer goderbauer Jul 14, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These double negative properties make my brain hurt and are also against our style guide: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-double-negatives-in-apis

(probably too late to fix now since the property wasn't introduced in this PR?)

@LongCatIsLooong LongCatIsLooong Jul 14, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well the good news is the flag won't be here for long hopefully.

@LongCatIsLooong LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 14, 2023
@auto-submit
auto-submit Bot merged commit f2574ba into flutter:master Jul 14, 2023
@LongCatIsLooong
LongCatIsLooong deleted the textpainter-shouldDidableRoundingHack branch July 14, 2023 22:20
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
26561ab 
…ter/flutter#130548)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
ffe62ca 
…ter/flutter#130548)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
04f1292 
…ter/flutter#130548)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
e604e49 
…ter/flutter#130548)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
cb3eb03 
…ter/flutter#130548)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
64df851 
…ter/flutter#130548)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
8418647 
…ter/flutter#130548)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
bc7c94c 
…ter/flutter#130548)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
e339623 
…ter/flutter#130548)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
228ae5f 
…ter/flutter#130548)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
1767b23 
…ter/flutter#130548)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
88bb94b 
…ter/flutter#130548)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
5aee029 
…ter/flutter#130548)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
53385e5 
…ter/flutter#130548)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
9b25197 
…ter/flutter#130548)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
af26863 
…ter/flutter#130548)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
057225b 
…ter/flutter#130548)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
955a91f 
…ter/flutter#130548)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
d53808e 
…ter/flutter#130548)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
4c1c0d1 
…ter/flutter#130548)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
f2574ba Use the new rounding hack migration flag in TextPainter (flut…
b8dfaa7 
…ter/flutter#130548)
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
@LongCatIsLooong @LouiseHsu
Use the new rounding hack migration flag in TextPainter (flutter#130548)
38ae0b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LongCatIsLooong @goderbauer