Skip to content

Remove unused imports - #130603

Merged
goderbauer merged 1 commit into
flutter:masterfrom
goderbauer:removeImports
Jul 14, 2023
Merged

goderbauer merged 1 commit into
flutter:masterfrom
goderbauer:removeImports

Conversation

@goderbauer

Copy link
Copy Markdown
Member

No description provided.

@github-actions github-actions Bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 14, 2023
@goderbauer

Copy link
Copy Markdown
Member Author

@pq or @srawlins: Wondering if you have a hunch as to why these were not caught by the unnecessary import diagnostics?

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 14, 2023
@srawlins

Copy link
Copy Markdown
Contributor

It's an awkward implementation detail, but we have "unnecessary imports" (checked with a warning) and "redundant imports". The latter has no check yet.

The difference is basically that two import directives are "redundant" if the "used element set" from each is identical. It is not clear which import to report, or to fix. One import "unnecessary" if it's "used element set" is strictly a subset of another import directive, and so its easy to see which one to report on, and to fix.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 14, 2023
@auto-submit

auto-submit Bot commented Jul 14, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter, pr: 130603, due to - The status or check suite Mac build_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 14, 2023
@goderbauer
goderbauer merged commit d5c724e into flutter:master Jul 14, 2023
@goderbauer
goderbauer deleted the removeImports branch July 14, 2023 20:36
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants