Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor` for Material 3 by TahaTesser · Pull Request #131253 · flutter/flutter

TahaTesser · 2023-07-25T11:27:34Z

fixes TimePicker color and visual issues

Description

fixes default text style for TimePickers hourMinuteTextStyle and added a todo for TimePicker's hourMinuteTextStyle Material 3 token is incorrect #131247
fixes correct default color not being accessed for dayPeriodTextColor
Updates tests

Code sample

expand to view the code sample

import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(useMaterial3: true),
      home: const Example(),
    );
  }
}

class Example extends StatelessWidget {
  const Example({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: const Text('Sample'),
      ),
      body: Center(
        child: ElevatedButton(
          onPressed: () {
            showTimePicker(
              context: context,
              orientation: Orientation.portrait,
              initialEntryMode: TimePickerEntryMode.input,
              initialTime: TimeOfDay.now(),
              builder: (BuildContext context, Widget? child) {
                return MediaQuery(
                  data: MediaQuery.of(context)
                      .copyWith(alwaysUse24HourFormat: true),
                  child: child!,
                );
              },
            );
          },
          child: const Text('Open Time Picker'),
        ),
      ),
    );
  }
}

Before

After

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gspencergoog

Thanks! This may require some changes to the Google test golden files, but I'll look out for that.

TahaTesser · 2023-07-27T19:01:47Z

Ping @gspencergoog

gspencergoog · 2023-07-27T19:14:00Z

Sorry, @TahaTesser what did you need from me here? It seems like the Google test is still pending.

TahaTesser · 2023-07-27T19:22:38Z

Sorry, @TahaTesser what did you need from me here? It seems like the Google test is still pending.

In case you need to check golden images, I didn't rebase. Let me try that.

…tColor`

…eriodTextColor` for Material 3 (flutter/flutter#131253)

flutter/flutter@dd9764e...e81907e 2023-07-28 [email protected] Update Chrome to 115, and remove `bringup: true` from skwasm benchmarks. (flutter/flutter#131430) 2023-07-28 [email protected] Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor` for Material 3 (flutter/flutter#131253) 2023-07-28 [email protected] Roll Flutter Engine from cfa5427dc452 to e97014c71014 (3 revisions) (flutter/flutter#131477) 2023-07-28 [email protected] Roll Flutter Engine from dc8618da9eb0 to cfa5427dc452 (3 revisions) (flutter/flutter#131464) 2023-07-28 [email protected] Roll Flutter Engine from b0d97ba45f46 to dc8618da9eb0 (3 revisions) (flutter/flutter#131460) 2023-07-28 [email protected] Updated integration_tests/platform_interaction test_step.dart (flutter/flutter#131301) 2023-07-28 [email protected] Roll Flutter Engine from 0713d91c2e64 to b0d97ba45f46 (1 revision) (flutter/flutter#131453) 2023-07-28 [email protected] Roll Flutter Engine from 01bb0a3ef922 to 0713d91c2e64 (2 revisions) (flutter/flutter#131451) 2023-07-28 [email protected] Roll Flutter Engine from 196474bd96b0 to 01bb0a3ef922 (3 revisions) (flutter/flutter#131447) 2023-07-27 [email protected] Roll Flutter Engine from 284771da323c to 196474bd96b0 (3 revisions) (flutter/flutter#131443) 2023-07-27 [email protected] [framework] clean up image provider documentation. (flutter/flutter#131416) 2023-07-27 [email protected] Fix template app documentation (flutter/flutter#131125) 2023-07-27 [email protected] Roll Flutter Engine from 9a935ecbf73a to 284771da323c (3 revisions) (flutter/flutter#131439) 2023-07-27 [email protected] â�¡ï¸� Add `ssh://[email protected]/flutter/flutter.git` as a standard remote (flutter/flutter#131333) 2023-07-27 [email protected] Roll Flutter Engine from f3317dbab388 to 9a935ecbf73a (1 revision) (flutter/flutter#131437) 2023-07-27 [email protected] ð�� Only format Dart files for `gen-l10n` (flutter/flutter#131232) 2023-07-27 [email protected] Roll Flutter Engine from 08050cdecf94 to f3317dbab388 (1 revision) (flutter/flutter#131432) 2023-07-27 [email protected] Preliminary PR for engine changes for Expanded/Collapsed Submenu button (flutter/flutter#131359) 2023-07-27 [email protected] Roll Flutter Engine from 9b14c382eebf to 08050cdecf94 (22 revisions) (flutter/flutter#131426) 2023-07-27 [email protected] Roll Packages from a99fc87 to f4ae933 (3 revisions) (flutter/flutter#131422) 2023-07-27 [email protected] Manual roll to engine commit 9b14c382 using Dart SDK version 3.2.x (flutter/flutter#131371) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@OverRide

…tColor` for Material 3 (flutter#131253) fixes [`TimePicker` color and visual issues](flutter#127035) ## Description - fixes default text style for `TimePicker`s `hourMinuteTextStyle` and added a todo for flutter#131247 - fixes correct default color not being accessed for `dayPeriodTextColor` - Updates tests ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, theme: ThemeData(useMaterial3: true), home: const Example(), ); } } class Example extends StatelessWidget { const Example({super.key}); @OverRide Widget build(BuildContext context) { return Scaffold( appBar: AppBar( title: const Text('Sample'), ), body: Center( child: ElevatedButton( onPressed: () { showTimePicker( context: context, orientation: Orientation.portrait, initialEntryMode: TimePickerEntryMode.input, initialTime: TimeOfDay.now(), builder: (BuildContext context, Widget? child) { return MediaQuery( data: MediaQuery.of(context) .copyWith(alwaysUse24HourFormat: true), child: child!, ); }, ); }, child: const Text('Open Time Picker'), ), ), ); } } ``` </details> ### Before ![ezgif com-video-to-gif](https://github.com/flutter/flutter/assets/48603081/b791501f-aed3-44f3-8f75-70a1e28038c6) ### After ![ezgif com-video-to-gif (1)](https://github.com/flutter/flutter/assets/48603081/1bb32064-a9b1-416d-8290-7d22b0d4fdb9)

@OverRide

…tColor` for Material 3 (flutter#131253) fixes [`TimePicker` color and visual issues](flutter#127035) ## Description - fixes default text style for `TimePicker`s `hourMinuteTextStyle` and added a todo for flutter#131247 - fixes correct default color not being accessed for `dayPeriodTextColor` - Updates tests ### Code sample <details> <summary>expand to view the code sample</summary> ```dart import 'package:flutter/material.dart'; void main() => runApp(const MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @OverRide Widget build(BuildContext context) { return MaterialApp( debugShowCheckedModeBanner: false, theme: ThemeData(useMaterial3: true), home: const Example(), ); } } class Example extends StatelessWidget { const Example({super.key}); @OverRide Widget build(BuildContext context) { return Scaffold( appBar: AppBar( title: const Text('Sample'), ), body: Center( child: ElevatedButton( onPressed: () { showTimePicker( context: context, orientation: Orientation.portrait, initialEntryMode: TimePickerEntryMode.input, initialTime: TimeOfDay.now(), builder: (BuildContext context, Widget? child) { return MediaQuery( data: MediaQuery.of(context) .copyWith(alwaysUse24HourFormat: true), child: child!, ); }, ); }, child: const Text('Open Time Picker'), ), ), ); } } ``` </details> ### Before ![ezgif com-video-to-gif](https://github.com/flutter/flutter/assets/48603081/b791501f-aed3-44f3-8f75-70a1e28038c6) ### After ![ezgif com-video-to-gif (1)](https://github.com/flutter/flutter/assets/48603081/1bb32064-a9b1-416d-8290-7d22b0d4fdb9)

Fix issue reference for #131247 (it was added in the bug fix PR #131253)

flutter/flutter@dd9764e...e81907e 2023-07-28 [email protected] Update Chrome to 115, and remove `bringup: true` from skwasm benchmarks. (flutter/flutter#131430) 2023-07-28 [email protected] Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor` for Material 3 (flutter/flutter#131253) 2023-07-28 [email protected] Roll Flutter Engine from cfa5427dc452 to e97014c71014 (3 revisions) (flutter/flutter#131477) 2023-07-28 [email protected] Roll Flutter Engine from dc8618da9eb0 to cfa5427dc452 (3 revisions) (flutter/flutter#131464) 2023-07-28 [email protected] Roll Flutter Engine from b0d97ba45f46 to dc8618da9eb0 (3 revisions) (flutter/flutter#131460) 2023-07-28 [email protected] Updated integration_tests/platform_interaction test_step.dart (flutter/flutter#131301) 2023-07-28 [email protected] Roll Flutter Engine from 0713d91c2e64 to b0d97ba45f46 (1 revision) (flutter/flutter#131453) 2023-07-28 [email protected] Roll Flutter Engine from 01bb0a3ef922 to 0713d91c2e64 (2 revisions) (flutter/flutter#131451) 2023-07-28 [email protected] Roll Flutter Engine from 196474bd96b0 to 01bb0a3ef922 (3 revisions) (flutter/flutter#131447) 2023-07-27 [email protected] Roll Flutter Engine from 284771da323c to 196474bd96b0 (3 revisions) (flutter/flutter#131443) 2023-07-27 [email protected] [framework] clean up image provider documentation. (flutter/flutter#131416) 2023-07-27 [email protected] Fix template app documentation (flutter/flutter#131125) 2023-07-27 [email protected] Roll Flutter Engine from 9a935ecbf73a to 284771da323c (3 revisions) (flutter/flutter#131439) 2023-07-27 [email protected] â�¡ï¸� Add `ssh://[email protected]/flutter/flutter.git` as a standard remote (flutter/flutter#131333) 2023-07-27 [email protected] Roll Flutter Engine from f3317dbab388 to 9a935ecbf73a (1 revision) (flutter/flutter#131437) 2023-07-27 [email protected] ð�� Only format Dart files for `gen-l10n` (flutter/flutter#131232) 2023-07-27 [email protected] Roll Flutter Engine from 08050cdecf94 to f3317dbab388 (1 revision) (flutter/flutter#131432) 2023-07-27 [email protected] Preliminary PR for engine changes for Expanded/Collapsed Submenu button (flutter/flutter#131359) 2023-07-27 [email protected] Roll Flutter Engine from 9b14c382eebf to 08050cdecf94 (22 revisions) (flutter/flutter#131426) 2023-07-27 [email protected] Roll Packages from a99fc87 to f4ae933 (3 revisions) (flutter/flutter#131422) 2023-07-27 [email protected] Manual roll to engine commit 9b14c382 using Dart SDK version 3.2.x (flutter/flutter#131371) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter@dd9764e...e81907e 2023-07-28 [email protected] Update Chrome to 115, and remove `bringup: true` from skwasm benchmarks. (flutter/flutter#131430) 2023-07-28 [email protected] Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor` for Material 3 (flutter/flutter#131253) 2023-07-28 [email protected] Roll Flutter Engine from cfa5427dc452 to e97014c71014 (3 revisions) (flutter/flutter#131477) 2023-07-28 [email protected] Roll Flutter Engine from dc8618da9eb0 to cfa5427dc452 (3 revisions) (flutter/flutter#131464) 2023-07-28 [email protected] Roll Flutter Engine from b0d97ba45f46 to dc8618da9eb0 (3 revisions) (flutter/flutter#131460) 2023-07-28 [email protected] Updated integration_tests/platform_interaction test_step.dart (flutter/flutter#131301) 2023-07-28 [email protected] Roll Flutter Engine from 0713d91c2e64 to b0d97ba45f46 (1 revision) (flutter/flutter#131453) 2023-07-28 [email protected] Roll Flutter Engine from 01bb0a3ef922 to 0713d91c2e64 (2 revisions) (flutter/flutter#131451) 2023-07-28 [email protected] Roll Flutter Engine from 196474bd96b0 to 01bb0a3ef922 (3 revisions) (flutter/flutter#131447) 2023-07-27 [email protected] Roll Flutter Engine from 284771da323c to 196474bd96b0 (3 revisions) (flutter/flutter#131443) 2023-07-27 [email protected] [framework] clean up image provider documentation. (flutter/flutter#131416) 2023-07-27 [email protected] Fix template app documentation (flutter/flutter#131125) 2023-07-27 [email protected] Roll Flutter Engine from 9a935ecbf73a to 284771da323c (3 revisions) (flutter/flutter#131439) 2023-07-27 [email protected] â�¡ï¸� Add `ssh://[email protected]/flutter/flutter.git` as a standard remote (flutter/flutter#131333) 2023-07-27 [email protected] Roll Flutter Engine from f3317dbab388 to 9a935ecbf73a (1 revision) (flutter/flutter#131437) 2023-07-27 [email protected] ð�� Only format Dart files for `gen-l10n` (flutter/flutter#131232) 2023-07-27 [email protected] Roll Flutter Engine from 08050cdecf94 to f3317dbab388 (1 revision) (flutter/flutter#131432) 2023-07-27 [email protected] Preliminary PR for engine changes for Expanded/Collapsed Submenu button (flutter/flutter#131359) 2023-07-27 [email protected] Roll Flutter Engine from 9b14c382eebf to 08050cdecf94 (22 revisions) (flutter/flutter#131426) 2023-07-27 [email protected] Roll Packages from 20cff72 to 2265a78 (3 revisions) (flutter/flutter#131422) 2023-07-27 [email protected] Manual roll to engine commit 9b14c382 using Dart SDK version 3.2.x (flutter/flutter#131371) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Jul 25, 2023

TahaTesser mentioned this pull request Jul 25, 2023

TimePicker color and visual issues #127035

Closed

TahaTesser requested a review from gspencergoog July 25, 2023 12:42

gspencergoog approved these changes Jul 25, 2023

View reviewed changes

Fix TimePicker defaults for hourMinuteTextStyle and `dayPeriodTex…

095bc6a

…tColor`

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2023

auto-submit Bot merged commit 7d89617 into flutter:master Jul 28, 2023

TahaTesser deleted the time_picker_fixes branch July 28, 2023 14:11

TahaTesser mentioned this pull request Jul 28, 2023

TimePicker's hourMinuteTextStyle Material 3 token is incorrect #131247

Open

2 tasks done

This was referenced Jul 28, 2023

Roll Flutter from dd9764ec3447 to 7d89617a92b7 (20 revisions) flutter/packages#4581

Closed

Roll Flutter from dd9764ec3447 to e81907e07a38 (21 revisions) flutter/packages#4582

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2023

7d89617 Fix TimePicker defaults for hourMinuteTextStyle and `dayP…

70e7a31

…eriodTextColor` for Material 3 (flutter/flutter#131253)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2023

7d89617 Fix TimePicker defaults for hourMinuteTextStyle and `dayP…

832ce14

…eriodTextColor` for Material 3 (flutter/flutter#131253)

HansMuller mentioned this pull request Jul 28, 2023

Flutter Framework Team: Notable Commits #121415

Closed

TahaTesser mentioned this pull request Aug 3, 2023

Fix TimePicker token issue link #131863

Merged

7 of 8 tasks

auto-submit Bot pushed a commit that referenced this pull request Aug 3, 2023

Fix TimePicker token issue link (#131863)

0192f88

Fix issue reference for #131247 (it was added in the bug fix PR #131253)

TahaTesser mentioned this pull request Feb 20, 2024

Time selector separator in TimePicker is not centered vertically #143691

Closed

Navigation Menu

Repository navigation

Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor` for Material 3 - #131253

Fix `TimePicker` defaults for `hourMinuteTextStyle` and `dayPeriodTextColor` for Material 3#131253
auto-submit[bot] merged 1 commit into
flutter:masterfrom
TahaTesser:time_picker_fixes

TahaTesser commented Jul 25, 2023 •

edited

Loading

Uh oh!

gspencergoog left a comment

Uh oh!

TahaTesser commented Jul 27, 2023

Uh oh!

gspencergoog commented Jul 27, 2023

Uh oh!

TahaTesser commented Jul 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

TahaTesser commented Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Code sample

Before

After

Pre-launch Checklist

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

TahaTesser commented Jul 27, 2023

Uh oh!

gspencergoog commented Jul 27, 2023

Uh oh!

TahaTesser commented Jul 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

TahaTesser commented Jul 25, 2023 •

edited

Loading