Skip to content

Fix ios_add2app Podfile - #131263

Merged
dcharkes merged 4 commits into
masterfrom
fix-add2app-test
Jul 27, 2023
Merged

dcharkes merged 4 commits into
masterfrom
fix-add2app-test

Conversation

@dcharkes

Copy link
Copy Markdown
Contributor

@dcharkes
dcharkes requested a review from vashworth July 25, 2023 14:37
@dcharkes

Copy link
Copy Markdown
Contributor Author

@vashworth should we land this PR, or you'd rather only land changes if we actually enable this test again?

@vashworth vashworth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can land this, but can you remove the changes to the project.pbxproj? I believe part of the test is that it successfully automates updated it

@dcharkes
dcharkes requested a review from vashworth July 26, 2023 17:42

@vashworth vashworth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharkes dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 26, 2023
@dcharkes

Copy link
Copy Markdown
Contributor Author

Automerge doesn't work if "Google testing" doesn't run the test image.

Manually merging.

@dcharkes
dcharkes merged commit 4e609f1 into master Jul 27, 2023
@dcharkes
dcharkes deleted the fix-add2app-test branch July 27, 2023 16:37
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2023
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Jul 27, 2023
flutter/flutter@61fd11d...dd9764e

2023-07-27 [email protected] Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. (flutter/flutter#131306)
2023-07-27 [email protected] Fix ios_add2app Podfile (flutter/flutter#131263)
2023-07-27 [email protected] Add DeviceLab build+test separation doc (flutter/flutter#131365)
2023-07-27 [email protected] IgnoreBaseline widget (flutter/flutter#131220)
2023-07-27 [email protected] Add 'vm:keep-name' pragmas to platform channel classes (flutter/flutter#131271)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@61fd11d...dd9764e

2023-07-27 [email protected] Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. (flutter/flutter#131306)
2023-07-27 [email protected] Fix ios_add2app Podfile (flutter/flutter#131263)
2023-07-27 [email protected] Add DeviceLab build+test separation doc (flutter/flutter#131365)
2023-07-27 [email protected] IgnoreBaseline widget (flutter/flutter#131220)
2023-07-27 [email protected] Add 'vm:keep-name' pragmas to platform channel classes (flutter/flutter#131271)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter/flutter@61fd11d...dd9764e

2023-07-27 [email protected] Proposal to add barrier configs for showDatePicker, showTimePicker and showAboutDialog. (flutter/flutter#131306)
2023-07-27 [email protected] Fix ios_add2app Podfile (flutter/flutter#131263)
2023-07-27 [email protected] Add DeviceLab build+test separation doc (flutter/flutter#131365)
2023-07-27 [email protected] IgnoreBaseline widget (flutter/flutter#131220)
2023-07-27 [email protected] Add 'vm:keep-name' pragmas to platform channel classes (flutter/flutter#131271)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants