Skip to content

Revert "ImageDecoration.lerp" - #131347

Merged
Hixie merged 1 commit into
masterfrom
revert-130533-imagelerp
Jul 26, 2023
Merged

Hixie merged 1 commit into
masterfrom
revert-130533-imagelerp

Conversation

@Hixie

@Hixie Hixie commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Reverts #130533

Tree breakage.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Jul 26, 2023
@loic-sharma
loic-sharma self-requested a review July 26, 2023 18:06
@Hixie Hixie added warning: land on red to fix tree breakage autosubmit Merge PR when tree becomes green via auto submit App labels Jul 26, 2023
@Hixie
Hixie merged commit 27e9123 into master Jul 26, 2023
@Hixie
Hixie deleted the revert-130533-imagelerp branch July 26, 2023 18:10
@Hixie

Hixie commented Jul 26, 2023

Copy link
Copy Markdown
Contributor Author

looks like this was a false failure

auto-submit Bot pushed a commit that referenced this pull request Jul 26, 2023
This primarily implements DecorationImage.lerp().

It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation.

Fixes #12452

This was first landed in #130533 and reverted in #131347.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2023
tarrinneal pushed a commit to flutter/packages that referenced this pull request Jul 27, 2023
Manual roll requested by [email protected]

flutter/flutter@bae1ac2...61fd11d

2023-07-26 [email protected] Add the 'a:
desktop' label to labeler.yml (flutter/flutter#130933)
2023-07-26 [email protected] ImageDecoration.lerp (#130533)
(flutter/flutter#131349)
2023-07-26 [email protected] Minor adjustments on 2D APIs
(flutter/flutter#131358)
2023-07-26 [email protected] Revert "Update
Unit Tests for M2/M3" (flutter/flutter#131368)
2023-07-26 [email protected] Update Unit
Tests for M2/M3 (flutter/flutter#131292)
2023-07-26 [email protected] Revert "Run
benchmarks with `--omit-type-checks`" (flutter/flutter#131353)
2023-07-26 [email protected] Revert "ImageDecoration.lerp"
(flutter/flutter#131347)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 31, 2023
This primarily implements DecorationImage.lerp().

It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation.

Fixes flutter#12452

This was first landed in flutter#130533 and reverted in flutter#131347.
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
vashworth pushed a commit to vashworth/flutter that referenced this pull request Aug 2, 2023
This primarily implements DecorationImage.lerp().

It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation.

Fixes flutter#12452

This was first landed in flutter#130533 and reverted in flutter#131347.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
Manual roll requested by [email protected]

flutter/flutter@bae1ac2...61fd11d

2023-07-26 [email protected] Add the 'a:
desktop' label to labeler.yml (flutter/flutter#130933)
2023-07-26 [email protected] ImageDecoration.lerp (#130533)
(flutter/flutter#131349)
2023-07-26 [email protected] Minor adjustments on 2D APIs
(flutter/flutter#131358)
2023-07-26 [email protected] Revert "Update
Unit Tests for M2/M3" (flutter/flutter#131368)
2023-07-26 [email protected] Update Unit
Tests for M2/M3 (flutter/flutter#131292)
2023-07-26 [email protected] Revert "Run
benchmarks with `--omit-type-checks`" (flutter/flutter#131353)
2023-07-26 [email protected] Revert "ImageDecoration.lerp"
(flutter/flutter#131347)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
chunhtai pushed a commit to chunhtai/packages that referenced this pull request Jun 12, 2026
This primarily implements DecorationImage.lerp().

It also makes some minor tweaks, the main one of which is defering to dart:ui for `clampDouble` instead of duplicating it in package:foundation.

Fixes flutter/flutter#12452

This was first landed in flutter/flutter#130533 and reverted in flutter/flutter#131347.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Manual roll requested by [email protected]

flutter/flutter@bae1ac2...61fd11d

2023-07-26 [email protected] Add the 'a:
desktop' label to labeler.yml (flutter/flutter#130933)
2023-07-26 [email protected] ImageDecoration.lerp (#130533)
(flutter/flutter#131349)
2023-07-26 [email protected] Minor adjustments on 2D APIs
(flutter/flutter#131358)
2023-07-26 [email protected] Revert "Update
Unit Tests for M2/M3" (flutter/flutter#131368)
2023-07-26 [email protected] Update Unit
Tests for M2/M3 (flutter/flutter#131292)
2023-07-26 [email protected] Revert "Run
benchmarks with `--omit-type-checks`" (flutter/flutter#131353)
2023-07-26 [email protected] Revert "ImageDecoration.lerp"
(flutter/flutter#131347)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC
[email protected],[email protected],[email protected] on the
revert to ensure that a human
is aware of the problem.

To file a bug in Packages:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants