Repository navigation
Fix PopupMenuItem & CheckedPopupMenuItem has redundant ListTile padding and update default horizontal padding for Material 3 - #131609
Merged
auto-submit[bot] merged 1 commit intoAug 10, 2023
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
11 of 16 tasks
Contributor
Author
|
This is ready for review @QuncCccccc |
… padding and update default horizontal padding for Material 3
HansMuller
approved these changes
Aug 10, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 10, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
2 tasks done
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 15, 2023
…istTile` padding and update default horizontal padding for Material 3 (flutter/flutter#131609)
chunhtai
pushed a commit
to chunhtai/packages
that referenced
this pull request
Jun 12, 2026
…istTile` padding and update default horizontal padding for Material 3" (#132457) Reverts flutter/flutter#131609 b/295497265 - This broke Google Testing. We'll need the internal patch before landing as there's a large number of customer codebases impacted.
chunhtai
pushed a commit
to chunhtai/packages
that referenced
this pull request
Jun 12, 2026
This relands flutter/flutter#131609 --- fixes [`PopupMenuItem` adds redundant padding when using `ListItem`](flutter/flutter#128553)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes
PopupMenuItemadds redundant padding when usingListItemDescription
ListTilepadding when usingCheckedPopupMenuItemorPopupMenuItemwith theListTilechild for complex popup menu items as suggested in the docs.Code sample
expand to view the code sample
Before
ListTilenested by default inCheckedPopupMenuItemhas redundant paddingPopupMenuItemusingListTileas a child for complex menu items contains redundant padding.After
PopupMenuItem&CheckedPopupMenuItemoverrideListTilepadding (similar to howExpansionTileoverridesListTiletext and icon color.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.