Skip to content

Reland "[web] Migrate framework to fully use package:web (#128901)" - #132092

Merged
auto-submit[bot] merged 6 commits into
flutter:masterfrom
mdebbar:reland_package_web
Aug 9, 2023
Merged

Reland "[web] Migrate framework to fully use package:web (#128901)"#132092
auto-submit[bot] merged 6 commits into
flutter:masterfrom
mdebbar:reland_package_web

Conversation

@mdebbar

@mdebbar mdebbar commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

Relanding #128901

Part of #113402
Part of #127030

@mdebbar
mdebbar requested review from joshualitt and srujzs August 7, 2023 21:30
@flutter-dashboard

flutter-dashboard Bot commented Aug 7, 2023

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Aug 7, 2023
@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 9, 2023
@auto-submit
auto-submit Bot merged commit 632681d into flutter:master Aug 9, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
632681d Reland "[web] Migrate framework to fully use package:web (#12…
4f98165 
…8901)" (flutter/flutter#132092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
632681d Reland "[web] Migrate framework to fully use package:web (#12…
4613657 
…8901)" (flutter/flutter#132092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
632681d Reland "[web] Migrate framework to fully use package:web (#12…
648eb5d 
…8901)" (flutter/flutter#132092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
632681d Reland "[web] Migrate framework to fully use package:web (#12…
aac8266 
…8901)" (flutter/flutter#132092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
632681d Reland "[web] Migrate framework to fully use package:web (#12…
a342d3a 
…8901)" (flutter/flutter#132092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
632681d Reland "[web] Migrate framework to fully use package:web (#12…
dbe26e2 
…8901)" (flutter/flutter#132092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
632681d Reland "[web] Migrate framework to fully use package:web (#12…
72828d5 
…8901)" (flutter/flutter#132092)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
@engine-flutter-autoroll
632681d Reland "[web] Migrate framework to fully use package:web (#12…
cda5068 
…8901)" (flutter/flutter#132092)
@zanderso

zanderso commented Aug 15, 2023

Copy link
Copy Markdown
Member

SkiaPerf noted a regression on this commit: https://flutter-flutter-perf.skia.org/e/?begin=1691594079&end=1691627453&keys=X9ae1a616c4345809e5c78967935e2685&num_commits=50&request_type=1&xbaroffset=36214

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
632681d Reland "[web] Migrate framework to fully use package:web (#12…
8a012e9 
…8901)" (flutter/flutter#132092)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshualitt joshualitt joshualitt approved these changes
@srujzs srujzs srujzs approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mdebbar @zanderso @joshualitt @srujzs