Skip to content

Reland: Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus - #132273

Closed
justinmc wants to merge 10 commits into
flutter:masterfrom
justinmc:reland-can-request-focus-dropdown
Closed

Reland: Replace TextField.canRequestFocus with TextField.focusNode.canRequestFocus#132273
justinmc wants to merge 10 commits into
flutter:masterfrom
justinmc:reland-can-request-focus-dropdown

Conversation

@justinmc

@justinmc justinmc commented Aug 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Relands #130164 by reverting #132106.

It seems like there were legitimate Google test failures that I'll probably need to fix with a g3fix.

Fixes #130011

@justinmc justinmc self-assigned this Aug 9, 2023
@justinmc justinmc mentioned this pull request Aug 9, 2023
Closed
@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Aug 9, 2023
@goderbauer

goderbauer commented Nov 17, 2023

Copy link
Copy Markdown
Member

@LongCatIsLooong @Renzo-Olivares This came up during triage the other day. Do you happen to know if this is still something we plan to do?

@LongCatIsLooong

LongCatIsLooong commented Nov 17, 2023

Copy link
Copy Markdown
Contributor

Not sure but the change makes sense to me. I can try relanding this.

@justinmc
justinmc force-pushed the reland-can-request-focus-dropdown branch from 575ffaa to 7748d34 Compare February 5, 2024 18:24
@flutter-dashboard

flutter-dashboard Bot commented Mar 20, 2024

Copy link
Copy Markdown

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@justinmc justinmc mentioned this pull request May 24, 2024
Open
@justinmc

justinmc commented May 24, 2024

Copy link
Copy Markdown
Contributor Author

I'm closing this as I'm unable to fix the Google failures, unfortunately. I've created an issue to track this for the future. #149067

@justinmc justinmc closed this May 24, 2024
@justinmc
justinmc deleted the reland-can-request-focus-dropdown branch May 24, 2024 23:34
@loic-sharma loic-sharma mentioned this pull request Jan 7, 2026
Merged
4 tasks done
parlough pushed a commit to flutter/website that referenced this pull request Jan 7, 2026
@loic-sharma
Remove the TextField.canRequestFocus breaking change guide (#12893)
e538583 
We made a breaking change to remove `TextField.canRequestFocus`
(flutter/flutter#130164). However, this caused a
google3 failure and was reverted
(flutter/flutter#132104).

This removes the breaking change guide since we never relanded this
change:

* flutter/flutter#149067
* flutter/flutter#132273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@justinmc justinmc

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Broken selection on TextField if canRequestFocus: false

3 participants

@justinmc @goderbauer @LongCatIsLooong