Fix extent for null returning builder in GridView by Piinks · Pull Request #132511 · flutter/flutter

Piinks · 2023-08-14T18:46:37Z

This fixes an issue where a GridView/SliverGrid with a SliverChildBuilderDelegate would still reflect a max scroll extent of infinity after returning null from the builder. This change incorporates the same way we handle this case in SliverList:

flutter/packages/flutter/lib/src/rendering/sliver_list.dart

Lines 305 to 307 in 6d87a23

    
           if (reachedEnd) { 
        
             estimatedMaxScrollOffset = endScrollOffset; 
        
           } else {

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Co-authored-by: Taha Tesser <[email protected]>

AhmedLSayed9 · 2023-08-16T07:10:42Z

@Piinks Thanks!

…utter#132511)

flutter/flutter@f0e7c51...2502b51 2023-08-16 [email protected] Roll Flutter Engine from f186f1e9dc88 to 70b5700b79f6 (1 revision) (flutter/flutter#132655) 2023-08-16 [email protected] Roll Flutter Engine from e8670f03a9b1 to f186f1e9dc88 (2 revisions) (flutter/flutter#132649) 2023-08-16 [email protected] Fix flutter_tools use of --local-engine-host (flutter/flutter#132648) 2023-08-16 [email protected] Roll Flutter Engine from 7cc6a5832a0e to e8670f03a9b1 (3 revisions) (flutter/flutter#132623) 2023-08-16 [email protected] Roll Flutter Engine from decaccfc421d to 7cc6a5832a0e (1 revision) (flutter/flutter#132621) 2023-08-16 [email protected] Roll Flutter Engine from 659cdfc5a568 to decaccfc421d (6 revisions) (flutter/flutter#132618) 2023-08-16 [email protected] Roll Flutter Engine from 7409ce4ba0a8 to 659cdfc5a568 (1 revision) (flutter/flutter#132612) 2023-08-16 [email protected] Revert "Reorganize and clarify API doc generator" (flutter/flutter#132613) 2023-08-16 [email protected] Roll Flutter Engine from a9da7212eacf to 7409ce4ba0a8 (5 revisions) (flutter/flutter#132609) 2023-08-16 [email protected] Roll Flutter Engine from 22f03ffdc290 to a9da7212eacf (4 revisions) (flutter/flutter#132608) 2023-08-16 [email protected] [Reland] #131609 (flutter/flutter#132555) 2023-08-15 [email protected] Explain the keyboard manager protocol (flutter/flutter#132533) 2023-08-15 [email protected] Fix extent for null returning builder in GridView (flutter/flutter#132511) 2023-08-15 [email protected] Reorganize and clarify API doc generator (flutter/flutter#132353) 2023-08-15 [email protected] Fixing a memory leak in About box/dialog overlays (flutter/flutter#130842) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…utter#132511)

flutter/flutter@f0e7c51...2502b51 2023-08-16 [email protected] Roll Flutter Engine from f186f1e9dc88 to 70b5700b79f6 (1 revision) (flutter/flutter#132655) 2023-08-16 [email protected] Roll Flutter Engine from e8670f03a9b1 to f186f1e9dc88 (2 revisions) (flutter/flutter#132649) 2023-08-16 [email protected] Fix flutter_tools use of --local-engine-host (flutter/flutter#132648) 2023-08-16 [email protected] Roll Flutter Engine from 7cc6a5832a0e to e8670f03a9b1 (3 revisions) (flutter/flutter#132623) 2023-08-16 [email protected] Roll Flutter Engine from decaccfc421d to 7cc6a5832a0e (1 revision) (flutter/flutter#132621) 2023-08-16 [email protected] Roll Flutter Engine from 659cdfc5a568 to decaccfc421d (6 revisions) (flutter/flutter#132618) 2023-08-16 [email protected] Roll Flutter Engine from 7409ce4ba0a8 to 659cdfc5a568 (1 revision) (flutter/flutter#132612) 2023-08-16 [email protected] Revert "Reorganize and clarify API doc generator" (flutter/flutter#132613) 2023-08-16 [email protected] Roll Flutter Engine from a9da7212eacf to 7409ce4ba0a8 (5 revisions) (flutter/flutter#132609) 2023-08-16 [email protected] Roll Flutter Engine from 22f03ffdc290 to a9da7212eacf (4 revisions) (flutter/flutter#132608) 2023-08-16 [email protected] [Reland] #131609 (flutter/flutter#132555) 2023-08-15 [email protected] Explain the keyboard manager protocol (flutter/flutter#132533) 2023-08-15 [email protected] Fix extent for null returning builder in GridView (flutter/flutter#132511) 2023-08-15 [email protected] Reorganize and clarify API doc generator (flutter/flutter#132353) 2023-08-15 [email protected] Fixing a memory leak in About box/dialog overlays (flutter/flutter#130842) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fix extent for null returning builder in GridView

81606a7

Piinks added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Aug 14, 2023

TahaTesser approved these changes Aug 15, 2023

View reviewed changes

Comment thread packages/flutter/lib/src/rendering/sliver_grid.dart Outdated

Update packages/flutter/lib/src/rendering/sliver_grid.dart

6212c3f

Co-authored-by: Taha Tesser <[email protected]>

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2023

auto-submit Bot merged commit 9d94279 into flutter:master Aug 15, 2023

engine-flutter-autoroll mentioned this pull request Aug 16, 2023

Roll Flutter from f0e7c5181641 to 9f46ed744923 (14 revisions) flutter/packages#4721

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

9d94279 Fix extent for null returning builder in GridView (flutter/fl…

12168b2

…utter#132511)

engine-flutter-autoroll mentioned this pull request Aug 16, 2023

Roll Flutter from f0e7c5181641 to 2502b51f86c1 (15 revisions) flutter/packages#4722

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023

9d94279 Fix extent for null returning builder in GridView (flutter/fl…

518f84c

…utter#132511)

HansMuller mentioned this pull request Aug 25, 2023

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023

9d94279 Fix extent for null returning builder in GridView (flutter/fl…

0b4cab8

…utter#132511)

Navigation Menu

Repository navigation

Fix extent for null returning builder in GridView - #132511

Fix extent for null returning builder in GridView#132511
auto-submit[bot] merged 2 commits into
flutter:masterfrom
Piinks:easyGridFix

Piinks commented Aug 14, 2023

Uh oh!

Uh oh!

AhmedLSayed9 commented Aug 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	if (reachedEnd) {
	estimatedMaxScrollOffset = endScrollOffset;
	} else {

Conversation

Piinks commented Aug 14, 2023

Pre-launch Checklist

Uh oh!

Uh oh!

AhmedLSayed9 commented Aug 16, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants