Skip to content

Remove deprecated MaterialButtonWithIconMixin - #133173

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
Piinks:materialButtonMixin
Aug 23, 2023
Merged

Remove deprecated MaterialButtonWithIconMixin#133173
auto-submit[bot] merged 1 commit into
flutter:masterfrom
Piinks:materialButtonMixin

Conversation

@Piinks

@Piinks Piinks commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

Part of #133171

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. labels Aug 23, 2023
@Piinks
Piinks requested a review from HansMuller August 23, 2023 18:37
@Piinks Piinks mentioned this pull request Aug 23, 2023
Closed
HansMuller
HansMuller approved these changes Aug 23, 2023
View reviewed changes

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2023
@auto-submit
auto-submit Bot merged commit 8c69fd5 into flutter:master Aug 23, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 24, 2023
@engine-flutter-autoroll
8c69fd5 Remove deprecated MaterialButtonWithIconMixin (flutter/flutte…
2fb00c0 
…r#133173)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 24, 2023
@engine-flutter-autoroll
8c69fd5 Remove deprecated MaterialButtonWithIconMixin (flutter/flutte…
19b01bc 
…r#133173)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Aug 24, 2023
@engine-flutter-autoroll
Roll Flutter from bd836cc to deeb811 (17 revisions) (#4766)
76261da 
flutter/flutter@bd836cc...deeb811

2023-08-24 [email protected] Reverts "Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (#133224)" (flutter/flutter#133255)
2023-08-24 [email protected] Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (flutter/flutter#133224)
2023-08-24 [email protected] Roll Flutter Engine from 67e8b825cc91 to aa98a9d2e86f (4 revisions) (flutter/flutter#133220)
2023-08-24 [email protected] Roll Flutter Engine from 27d75f6221d2 to 67e8b825cc91 (1 revision) (flutter/flutter#133214)
2023-08-23 [email protected] Remove deprecated PlatformViewsService.synchronizeToNativeViewHierarchy (flutter/flutter#133175)
2023-08-23 [email protected] Roll Flutter Engine from 58dc868c26cb to 27d75f6221d2 (14 revisions) (flutter/flutter#133211)
2023-08-23 [email protected] Remove deprecated MaterialButtonWithIconMixin (flutter/flutter#133173)
2023-08-23 [email protected] Enable ChangeNotifier clients to dispatch event of object creation in constructor. (flutter/flutter#133060)
2023-08-23 [email protected] Enable literal_only_boolean_expressions (flutter/flutter#133186)
2023-08-23 [email protected] Add android analyzer commands for applinks (flutter/flutter#131009)
2023-08-23 [email protected] Bump memory usage in gradle for platform views (flutter/flutter#133155)
2023-08-23 [email protected] [flutter_tools] Fix legacy version file not being ensured (flutter/flutter#133097)
2023-08-23 [email protected] Remove deprecated *TestValues from TestWindow (flutter/flutter#131098)
2023-08-23 [email protected] Roll Flutter Engine from ac352ba95f43 to 58dc868c26cb (2 revisions) (flutter/flutter#133165)
2023-08-23 [email protected] [web] Remove unnecessary lint ignore (flutter/flutter#133164)
2023-08-23 [email protected] Add `--experimental-wasm-type-reflection` and support newer emscripten builds. (flutter/flutter#133084)
2023-08-23 [email protected] Roll Flutter Engine from 72a06427bd37 to ac352ba95f43 (2 revisions) (flutter/flutter#133158)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@HansMuller HansMuller mentioned this pull request Aug 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
8c69fd5 Remove deprecated MaterialButtonWithIconMixin (flutter/flutte…
2404a7d 
…r#133173)
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from bd836cc to deeb811 (17 revisions) (flutter#4766)
02c0b8c 
flutter/flutter@bd836cc...deeb811

2023-08-24 [email protected] Reverts "Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (#133224)" (flutter/flutter#133255)
2023-08-24 [email protected] Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (flutter/flutter#133224)
2023-08-24 [email protected] Roll Flutter Engine from 67e8b825cc91 to aa98a9d2e86f (4 revisions) (flutter/flutter#133220)
2023-08-24 [email protected] Roll Flutter Engine from 27d75f6221d2 to 67e8b825cc91 (1 revision) (flutter/flutter#133214)
2023-08-23 [email protected] Remove deprecated PlatformViewsService.synchronizeToNativeViewHierarchy (flutter/flutter#133175)
2023-08-23 [email protected] Roll Flutter Engine from 58dc868c26cb to 27d75f6221d2 (14 revisions) (flutter/flutter#133211)
2023-08-23 [email protected] Remove deprecated MaterialButtonWithIconMixin (flutter/flutter#133173)
2023-08-23 [email protected] Enable ChangeNotifier clients to dispatch event of object creation in constructor. (flutter/flutter#133060)
2023-08-23 [email protected] Enable literal_only_boolean_expressions (flutter/flutter#133186)
2023-08-23 [email protected] Add android analyzer commands for applinks (flutter/flutter#131009)
2023-08-23 [email protected] Bump memory usage in gradle for platform views (flutter/flutter#133155)
2023-08-23 [email protected] [flutter_tools] Fix legacy version file not being ensured (flutter/flutter#133097)
2023-08-23 [email protected] Remove deprecated *TestValues from TestWindow (flutter/flutter#131098)
2023-08-23 [email protected] Roll Flutter Engine from ac352ba95f43 to 58dc868c26cb (2 revisions) (flutter/flutter#133165)
2023-08-23 [email protected] [web] Remove unnecessary lint ignore (flutter/flutter#133164)
2023-08-23 [email protected] Add `--experimental-wasm-type-reflection` and support newer emscripten builds. (flutter/flutter#133084)
2023-08-23 [email protected] Roll Flutter Engine from 72a06427bd37 to ac352ba95f43 (2 revisions) (flutter/flutter#133158)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Roll Flutter from bd836cc to deeb811 (17 revisions) (flutter#4766)
76b18ec 
flutter/flutter@bd836cc...deeb811

2023-08-24 [email protected] Reverts "Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (#133224)" (flutter/flutter#133255)
2023-08-24 [email protected] Roll Flutter Engine from aa98a9d2e86f to 3b92bb6eda19 (4 revisions) (flutter/flutter#133224)
2023-08-24 [email protected] Roll Flutter Engine from 67e8b825cc91 to aa98a9d2e86f (4 revisions) (flutter/flutter#133220)
2023-08-24 [email protected] Roll Flutter Engine from 27d75f6221d2 to 67e8b825cc91 (1 revision) (flutter/flutter#133214)
2023-08-23 [email protected] Remove deprecated PlatformViewsService.synchronizeToNativeViewHierarchy (flutter/flutter#133175)
2023-08-23 [email protected] Roll Flutter Engine from 58dc868c26cb to 27d75f6221d2 (14 revisions) (flutter/flutter#133211)
2023-08-23 [email protected] Remove deprecated MaterialButtonWithIconMixin (flutter/flutter#133173)
2023-08-23 [email protected] Enable ChangeNotifier clients to dispatch event of object creation in constructor. (flutter/flutter#133060)
2023-08-23 [email protected] Enable literal_only_boolean_expressions (flutter/flutter#133186)
2023-08-23 [email protected] Add android analyzer commands for applinks (flutter/flutter#131009)
2023-08-23 [email protected] Bump memory usage in gradle for platform views (flutter/flutter#133155)
2023-08-23 [email protected] [flutter_tools] Fix legacy version file not being ensured (flutter/flutter#133097)
2023-08-23 [email protected] Remove deprecated *TestValues from TestWindow (flutter/flutter#131098)
2023-08-23 [email protected] Roll Flutter Engine from ac352ba95f43 to 58dc868c26cb (2 revisions) (flutter/flutter#133165)
2023-08-23 [email protected] [web] Remove unnecessary lint ignore (flutter/flutter#133164)
2023-08-23 [email protected] Add `--experimental-wasm-type-reflection` and support newer emscripten builds. (flutter/flutter#133084)
2023-08-23 [email protected] Roll Flutter Engine from 72a06427bd37 to ac352ba95f43 (2 revisions) (flutter/flutter#133158)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@HansMuller HansMuller HansMuller approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Piinks @HansMuller