Skip to content

Remove deprecated TestWindow.platformBrightnessTestValue/TestWindow.clearPlatformBrightnessTestValue - #133178

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
Renzo-Olivares:deprecate-platformBrightnessTestValue
Sep 1, 2023
Merged

Remove deprecated TestWindow.platformBrightnessTestValue/TestWindow.clearPlatformBrightnessTestValue#133178
auto-submit[bot] merged 1 commit into
flutter:masterfrom
Renzo-Olivares:deprecate-platformBrightnessTestValue

Conversation

@Renzo-Olivares

@Renzo-Olivares Renzo-Olivares commented Aug 23, 2023

Copy link
Copy Markdown
Contributor

Part of: #133171

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Aug 23, 2023
@Piinks Piinks mentioned this pull request Aug 23, 2023
Closed
@Renzo-Olivares Renzo-Olivares mentioned this pull request Aug 24, 2023
Merged
@Renzo-Olivares
Renzo-Olivares marked this pull request as ready for review August 30, 2023 13:46
@Renzo-Olivares
Renzo-Olivares requested a review from Piinks August 30, 2023 19:10
Piinks
Piinks approved these changes Aug 30, 2023
View reviewed changes

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is happy! :) Thanks!

@Renzo-Olivares Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 1, 2023
@auto-submit
auto-submit Bot merged commit b1f691c into flutter:master Sep 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
aecde06 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 2, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
bd832ca 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
3977053 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
31f97ee 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
9c77978 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
b7a051e 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
43cfe29 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
6972ca5 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
6a135f6 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
c137c48 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
c6d7c72 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
2348356 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
5b2c5c6 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
7edf44a 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
130b796 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
f9dc2f8 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
d0b86bd 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
9a3791e 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
0529b7b 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
b6a8e16 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
427c56b 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
74009c3 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
42ed4b3 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
b1f691c Remove deprecated TestWindow.platformBrightnessTestValue/Test…
80085f7 
…Window.clearPlatformBrightnessTestValue (flutter/flutter#133178)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Renzo-Olivares @Piinks