Skip to content

Revert "CupertinoAlertDialog should not create ScrollController on every build, if null values are passed in constructor." - #134071

Merged
auto-submit[bot] merged 1 commit into
masterfrom
revert-133918-ScrollController-fix
Sep 5, 2023
Merged

Revert "CupertinoAlertDialog should not create ScrollController on every build, if null values are passed in constructor."#134071
auto-submit[bot] merged 1 commit into
masterfrom
revert-133918-ScrollController-fix

Conversation

@polina-c

@polina-c polina-c commented Sep 5, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

@polina-c
Revert "CupertinoAlertDialog should not create ScrollController on ev…
772c00e 
…ery build, if null values are passed in constructor. (#133918)"

This reverts commit 7cdf314.
@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages p: cupertino_ui cupertino_ui package in flutter/packages labels Sep 5, 2023
@yusuf-goog yusuf-goog added the revert Autorevert PR (with "Reason for revert:" comment) label Sep 5, 2023
@auto-submit
auto-submit Bot merged commit a425e56 into master Sep 5, 2023
@auto-submit
auto-submit Bot deleted the revert-133918-ScrollController-fix branch September 5, 2023 21:03
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
0066e9b 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
f8756a3 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
a457ae5 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
c65e390 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
9cbdd58 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
af45bfa 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
8ae626e 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 6, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
16e1720 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
6b426b5 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
bcaded5 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
9d48b7f 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
66c4184 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
2a3d534 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 7, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
50ba224 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
@polina-c polina-c mentioned this pull request Sep 5, 2023
Merged
2 tasks done
auto-submit Bot pushed a commit that referenced this pull request Sep 8, 2023
@polina-c
CupertinoAlertDialog should not create ScrollController on every buil…
cc95ace 
…d, if null values are passed in constructor. (#134075)

Relanding of #134071

Verified failed tests succeeded now:
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
a425e56 Revert "CupertinoAlertDialog should not create ScrollControll…
cf81df2 
…er on every build, if null values are passed in constructor." (flutter/flutter#134071)
chunhtai pushed a commit to chunhtai/packages that referenced this pull request Jun 12, 2026
@polina-c
CupertinoAlertDialog should not create ScrollController on every buil…
c07c24a 
…d, if null values are passed in constructor. (#134075)

Relanding of flutter/flutter#134071

Verified failed tests succeeded now:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes
+1 more reviewer
@yusuf-goog yusuf-goog yusuf-goog approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@polina-c @fluttergithubbot @yusuf-goog