Skip to content

Revert "Resolve breaking change of adding a method to ChangeNotifier." - #134978

Merged
auto-submit[bot] merged 1 commit into
masterfrom
revert-134953-static-dispatch
Sep 18, 2023
Merged

auto-submit[bot] merged 1 commit into
masterfrom
revert-134953-static-dispatch

Conversation

@zanderso

Copy link
Copy Markdown
Member

Reverts #134953

Several failures on CI

@zanderso
zanderso requested a review from polina-c September 18, 2023 23:03
@zanderso zanderso added the revert Autorevert PR (with "Reason for revert:" comment) label Sep 18, 2023
@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. f: routes Navigator, Router, and related APIs. f: focus Focus traversal, gaining or losing focus labels Sep 18, 2023
@zanderso zanderso added warning: land on red to fix tree breakage and removed framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. f: routes Navigator, Router, and related APIs. f: focus Focus traversal, gaining or losing focus labels Sep 18, 2023
@auto-submit
auto-submit Bot merged commit a9183f6 into master Sep 18, 2023
@auto-submit
auto-submit Bot deleted the revert-134953-static-dispatch branch September 18, 2023 23:04
@zanderso

zanderso commented Sep 18, 2023 •

Copy link
Copy Markdown
Member Author
[2023-09-18 16:14:51.463282] [STDOUT] stdout:   error • Static members from supertypes must be qualified by the name of the defining type • packages/flutter/test/material/app_test.dart:1573:5 • unqualified_reference_to_non_local_static_member
[2023-09-18 16:14:51.463397] [STDOUT] stdout:   error • 1 positional argument expected by 'maybeDispatchObjectCreation', but 0 found • packages/flutter/test/material/app_test.dart:1573:33 • not_enough_positional_arguments

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2023
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Sep 19, 2023
flutter/flutter@b7d0e8c...8936504

2023-09-19 [email protected] Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998)
2023-09-19 [email protected] Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983)
2023-09-18 [email protected] Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978)
2023-09-18 [email protected] Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953)
2023-09-18 [email protected] Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954)
2023-09-18 [email protected] Access to fragment in router state on page refresh (flutter/flutter#131123)
2023-09-18 [email protected] Enable private field promotion for framework (flutter/flutter#134473)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #6 (flutter/flutter#134884)
2023-09-18 [email protected] Cover more tests with leak tracking. (flutter/flutter#134805)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking #5 (flutter/flutter#134869)
2023-09-18 [email protected] Don't uninstall before retrying to connect during app launch (flutter/flutter#134542)
2023-09-18 [email protected] [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955)
2023-09-18 [email protected] Fix memory leak in _DarwinViewState. (flutter/flutter#134938)
2023-09-18 [email protected] Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956)
2023-09-18 [email protected] Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@b7d0e8c...8936504

2023-09-19 [email protected] Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998)
2023-09-19 [email protected] Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983)
2023-09-18 [email protected] Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978)
2023-09-18 [email protected] Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953)
2023-09-18 [email protected] Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954)
2023-09-18 [email protected] Access to fragment in router state on page refresh (flutter/flutter#131123)
2023-09-18 [email protected] Enable private field promotion for framework (flutter/flutter#134473)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking flutter#6 (flutter/flutter#134884)
2023-09-18 [email protected] Cover more tests with leak tracking. (flutter/flutter#134805)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking flutter#5 (flutter/flutter#134869)
2023-09-18 [email protected] Don't uninstall before retrying to connect during app launch (flutter/flutter#134542)
2023-09-18 [email protected] [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955)
2023-09-18 [email protected] Fix memory leak in _DarwinViewState. (flutter/flutter#134938)
2023-09-18 [email protected] Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956)
2023-09-18 [email protected] Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter/flutter@b7d0e8c...8936504

2023-09-19 [email protected] Roll Flutter Engine from e1c784e3f841 to 589bde9a95c9 (16 revisions) (flutter/flutter#134998)
2023-09-19 [email protected] Reland Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134983)
2023-09-18 [email protected] Revert "Resolve breaking change of adding a method to ChangeNotifier." (flutter/flutter#134978)
2023-09-18 [email protected] Resolve breaking change of adding a method to ChangeNotifier. (flutter/flutter#134953)
2023-09-18 [email protected] Fixes focus traversal crash if the current node can't request focus (flutter/flutter#134954)
2023-09-18 [email protected] Access to fragment in router state on page refresh (flutter/flutter#131123)
2023-09-18 [email protected] Enable private field promotion for framework (flutter/flutter#134473)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking flutter#6 (flutter/flutter#134884)
2023-09-18 [email protected] Cover more tests with leak tracking. (flutter/flutter#134805)
2023-09-18 [email protected] Cover more test/widgets tests with leak tracking flutter#5 (flutter/flutter#134869)
2023-09-18 [email protected] Don't uninstall before retrying to connect during app launch (flutter/flutter#134542)
2023-09-18 [email protected] [flutter roll] Revert "LinkedText (Linkify)" (flutter/flutter#134955)
2023-09-18 [email protected] Fix memory leak in _DarwinViewState. (flutter/flutter#134938)
2023-09-18 [email protected] Roll Flutter Engine from be7a039c5451 to e1c784e3f841 (3 revisions) (flutter/flutter#134956)
2023-09-18 [email protected] Migrate the "Missing frames / speed related performance issues" issue template to use Github forms (flutter/flutter#134033)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants