Skip to content

Expose onAttach and onDetach in ScrollController subclasses - #135721

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
Piinks:pageController
Sep 29, 2023
Merged

Expose onAttach and onDetach in ScrollController subclasses#135721
auto-submit[bot] merged 1 commit into
flutter:masterfrom
Piinks:pageController

Conversation

@Piinks

@Piinks Piinks commented Sep 28, 2023

Copy link
Copy Markdown
Contributor

Fixes #135574
This exposes the onAttach and onDetach callbacks of ScrollController in all of its subclasses.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. a: quality A truly polished experience labels Sep 28, 2023
@Piinks Piinks mentioned this pull request Sep 28, 2023
Closed
2 tasks done
goderbauer
goderbauer approved these changes Sep 28, 2023
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 29, 2023
@auto-submit
auto-submit Bot merged commit 7c9feea into flutter:master Sep 29, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2023
@engine-flutter-autoroll
7c9feea Expose onAttach and onDetach in ScrollController subclasses (f…
08d2034 
…lutter/flutter#135721)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2023
@engine-flutter-autoroll
7c9feea Expose onAttach and onDetach in ScrollController subclasses (f…
6239d7b 
…lutter/flutter#135721)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 30, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2023
@engine-flutter-autoroll
7c9feea Expose onAttach and onDetach in ScrollController subclasses (f…
84db1fa 
…lutter/flutter#135721)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Sep 30, 2023
@engine-flutter-autoroll
Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (#5043)
e5fedee 
flutter/flutter@57b5c3c...d3df8f6

2023-09-30 [email protected] Roll Flutter Engine from 68fc1a567195 to 01fc3c6624ce (1 revision) (flutter/flutter#135808)
2023-09-30 [email protected] Roll Flutter Engine from 4ed733d99cd5 to 68fc1a567195 (1 revision) (flutter/flutter#135807)
2023-09-30 [email protected] Roll Flutter Engine from d814c69abe26 to 4ed733d99cd5 (1 revision) (flutter/flutter#135801)
2023-09-30 [email protected] Roll Flutter Engine from f726438d4d65 to d814c69abe26 (1 revision) (flutter/flutter#135799)
2023-09-30 [email protected] Roll Flutter Engine from 0b96a82cc874 to f726438d4d65 (1 revision) (flutter/flutter#135796)
2023-09-30 [email protected] Roll Flutter Engine from f3a4cab69962 to 0b96a82cc874 (1 revision) (flutter/flutter#135793)
2023-09-30 [email protected] Roll Flutter Engine from e719b7957763 to f3a4cab69962 (2 revisions) (flutter/flutter#135792)
2023-09-30 [email protected] Roll Flutter Engine from 8939f9c1f4e4 to e719b7957763 (2 revisions) (flutter/flutter#135789)
2023-09-30 [email protected] Roll Flutter Engine from 6a13607008ed to 8939f9c1f4e4 (1 revision) (flutter/flutter#135788)
2023-09-30 [email protected] Add device ready check (flutter/flutter#135526)
2023-09-30 [email protected] Temporarily disable NexusLowRes, version=29 (flutter/flutter#135785)
2023-09-30 [email protected] Cover more test/widgets tests with leak tracking #12. (flutter/flutter#135385)
2023-09-30 [email protected] DraggableScrollableController should dispatch creation in constructor. (flutter/flutter#135423)
2023-09-30 [email protected] Roll Flutter Engine from d203e349781c to 6a13607008ed (2 revisions) (flutter/flutter#135780)
2023-09-29 [email protected] Roll Flutter Engine from 48973d7f9beb to d203e349781c (5 revisions) (flutter/flutter#135776)
2023-09-29 [email protected] ViewportOffset should dispatch creation in constructor. (flutter/flutter#135420)
2023-09-29 [email protected] Use platform dill from the engine when compiling with dart2wasm. (flutter/flutter#134970)
2023-09-29 [email protected] Roll Flutter Engine from d5fcd78a879b to 48973d7f9beb (5 revisions) (flutter/flutter#135765)
2023-09-29 [email protected] Upgrade leak_tracker to fix flackiness. (flutter/flutter#135760)
2023-09-29 [email protected] Roll Flutter Engine from c52251a8b2d0 to d5fcd78a879b (2 revisions) (flutter/flutter#135755)
2023-09-29 [email protected] Update `Drawer` tests for M2/M3 (flutter/flutter#135752)
2023-09-29 [email protected] Expose onAttach and onDetach in ScrollController subclasses (flutter/flutter#135721)
2023-09-29 [email protected] Update the wasm bootstrap to allow access to the emscripten wrapper to skwasm. (flutter/flutter#135723)
2023-09-29 [email protected] Update logic for getting `Analytics` instance from package:unified_analytics (flutter/flutter#134756)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@Piinks @Mairramer
Expose onAttach and onDetach in ScrollController subclasses (flutter#…
2b33dfd 
…135721)

Fixes flutter#135574
This exposes the onAttach and onDetach callbacks of ScrollController in all of its subclasses.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter#5043)
691a25e 
flutter/flutter@57b5c3c...d3df8f6

2023-09-30 [email protected] Roll Flutter Engine from 68fc1a567195 to 01fc3c6624ce (1 revision) (flutter/flutter#135808)
2023-09-30 [email protected] Roll Flutter Engine from 4ed733d99cd5 to 68fc1a567195 (1 revision) (flutter/flutter#135807)
2023-09-30 [email protected] Roll Flutter Engine from d814c69abe26 to 4ed733d99cd5 (1 revision) (flutter/flutter#135801)
2023-09-30 [email protected] Roll Flutter Engine from f726438d4d65 to d814c69abe26 (1 revision) (flutter/flutter#135799)
2023-09-30 [email protected] Roll Flutter Engine from 0b96a82cc874 to f726438d4d65 (1 revision) (flutter/flutter#135796)
2023-09-30 [email protected] Roll Flutter Engine from f3a4cab69962 to 0b96a82cc874 (1 revision) (flutter/flutter#135793)
2023-09-30 [email protected] Roll Flutter Engine from e719b7957763 to f3a4cab69962 (2 revisions) (flutter/flutter#135792)
2023-09-30 [email protected] Roll Flutter Engine from 8939f9c1f4e4 to e719b7957763 (2 revisions) (flutter/flutter#135789)
2023-09-30 [email protected] Roll Flutter Engine from 6a13607008ed to 8939f9c1f4e4 (1 revision) (flutter/flutter#135788)
2023-09-30 [email protected] Add device ready check (flutter/flutter#135526)
2023-09-30 [email protected] Temporarily disable NexusLowRes, version=29 (flutter/flutter#135785)
2023-09-30 [email protected] Cover more test/widgets tests with leak tracking flutter#12. (flutter/flutter#135385)
2023-09-30 [email protected] DraggableScrollableController should dispatch creation in constructor. (flutter/flutter#135423)
2023-09-30 [email protected] Roll Flutter Engine from d203e349781c to 6a13607008ed (2 revisions) (flutter/flutter#135780)
2023-09-29 [email protected] Roll Flutter Engine from 48973d7f9beb to d203e349781c (5 revisions) (flutter/flutter#135776)
2023-09-29 [email protected] ViewportOffset should dispatch creation in constructor. (flutter/flutter#135420)
2023-09-29 [email protected] Use platform dill from the engine when compiling with dart2wasm. (flutter/flutter#134970)
2023-09-29 [email protected] Roll Flutter Engine from d5fcd78a879b to 48973d7f9beb (5 revisions) (flutter/flutter#135765)
2023-09-29 [email protected] Upgrade leak_tracker to fix flackiness. (flutter/flutter#135760)
2023-09-29 [email protected] Roll Flutter Engine from c52251a8b2d0 to d5fcd78a879b (2 revisions) (flutter/flutter#135755)
2023-09-29 [email protected] Update `Drawer` tests for M2/M3 (flutter/flutter#135752)
2023-09-29 [email protected] Expose onAttach and onDetach in ScrollController subclasses (flutter/flutter#135721)
2023-09-29 [email protected] Update the wasm bootstrap to allow access to the emscripten wrapper to skwasm. (flutter/flutter#135723)
2023-09-29 [email protected] Update logic for getting `Analytics` instance from package:unified_analytics (flutter/flutter#134756)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Roll Flutter from 57b5c3c to d3df8f6 (24 revisions) (flutter#5043)
2202cc9 
flutter/flutter@57b5c3c...d3df8f6

2023-09-30 [email protected] Roll Flutter Engine from 68fc1a567195 to 01fc3c6624ce (1 revision) (flutter/flutter#135808)
2023-09-30 [email protected] Roll Flutter Engine from 4ed733d99cd5 to 68fc1a567195 (1 revision) (flutter/flutter#135807)
2023-09-30 [email protected] Roll Flutter Engine from d814c69abe26 to 4ed733d99cd5 (1 revision) (flutter/flutter#135801)
2023-09-30 [email protected] Roll Flutter Engine from f726438d4d65 to d814c69abe26 (1 revision) (flutter/flutter#135799)
2023-09-30 [email protected] Roll Flutter Engine from 0b96a82cc874 to f726438d4d65 (1 revision) (flutter/flutter#135796)
2023-09-30 [email protected] Roll Flutter Engine from f3a4cab69962 to 0b96a82cc874 (1 revision) (flutter/flutter#135793)
2023-09-30 [email protected] Roll Flutter Engine from e719b7957763 to f3a4cab69962 (2 revisions) (flutter/flutter#135792)
2023-09-30 [email protected] Roll Flutter Engine from 8939f9c1f4e4 to e719b7957763 (2 revisions) (flutter/flutter#135789)
2023-09-30 [email protected] Roll Flutter Engine from 6a13607008ed to 8939f9c1f4e4 (1 revision) (flutter/flutter#135788)
2023-09-30 [email protected] Add device ready check (flutter/flutter#135526)
2023-09-30 [email protected] Temporarily disable NexusLowRes, version=29 (flutter/flutter#135785)
2023-09-30 [email protected] Cover more test/widgets tests with leak tracking flutter#12. (flutter/flutter#135385)
2023-09-30 [email protected] DraggableScrollableController should dispatch creation in constructor. (flutter/flutter#135423)
2023-09-30 [email protected] Roll Flutter Engine from d203e349781c to 6a13607008ed (2 revisions) (flutter/flutter#135780)
2023-09-29 [email protected] Roll Flutter Engine from 48973d7f9beb to d203e349781c (5 revisions) (flutter/flutter#135776)
2023-09-29 [email protected] ViewportOffset should dispatch creation in constructor. (flutter/flutter#135420)
2023-09-29 [email protected] Use platform dill from the engine when compiling with dart2wasm. (flutter/flutter#134970)
2023-09-29 [email protected] Roll Flutter Engine from d5fcd78a879b to 48973d7f9beb (5 revisions) (flutter/flutter#135765)
2023-09-29 [email protected] Upgrade leak_tracker to fix flackiness. (flutter/flutter#135760)
2023-09-29 [email protected] Roll Flutter Engine from c52251a8b2d0 to d5fcd78a879b (2 revisions) (flutter/flutter#135755)
2023-09-29 [email protected] Update `Drawer` tests for M2/M3 (flutter/flutter#135752)
2023-09-29 [email protected] Expose onAttach and onDetach in ScrollController subclasses (flutter/flutter#135721)
2023-09-29 [email protected] Update the wasm bootstrap to allow access to the emscripten wrapper to skwasm. (flutter/flutter#135723)
2023-09-29 [email protected] Update logic for getting `Analytics` instance from package:unified_analytics (flutter/flutter#134756)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: quality A truly polished experience autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expose onAttach and onDetach in PageController constructor

2 participants

@Piinks @goderbauer