Repository navigation
Record focus in route entry to move a11y focus to the last focused item - #135771
Merged
Merged
Conversation
github-actions
Bot
added
framework
hannah-hyj
changed the title
hannah-hyj
marked this pull request as ready for review
October 11, 2023 23:29
chunhtai
reviewed
Oct 17, 2023
chunhtai
left a comment
chunhtai
left a comment
Contributor
There was a problem hiding this comment.
Discussed offline, we should consider using the didGainAccessibility signel in the iOS and Android embedding to record the last focused semantics id, and use that to send focus event
hannah-hyj
force-pushed
the
focus97747
branch
from
October 25, 2023 23:52
b66a14c to
3b3268f
Compare
hannah-hyj
marked this pull request as draft
October 25, 2023 23:53
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
hannah-hyj
marked this pull request as ready for review
October 30, 2023 18:03
hannah-hyj
force-pushed
the
focus97747
branch
from
October 30, 2023 18:03
3b3268f to
01150a7
Compare
Merged
8 tasks
chunhtai
reviewed
Nov 1, 2023
Contributor
There was a problem hiding this comment.
What about if there are nested navigators
Member
Author
There was a problem hiding this comment.
i think handleDidPopNext should only be called once even if there are multiple navigators.
Contributor
There was a problem hiding this comment.
what if the lastFocusNode is outside of the inner navigator and the inner navigator didPopNext is called? Would this cause a re-announcement of the focused node?
hannah-hyj
added a commit
to flutter-team-archive/engine
that referenced
this pull request
Nov 17, 2023
…7114) issue:flutter/flutter#97747 framework pr:flutter/flutter#135771 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I signed the [CLA]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --------- Co-authored-by: Reid Baker <[email protected]>
Merged
8 tasks
hannah-hyj
force-pushed
the
focus97747
branch
2 times, most recently
from
November 22, 2023 02:26
75fefef to
65d8648
Compare
auto-submit Bot
pushed a commit
to flutter-team-archive/engine
that referenced
this pull request
Nov 27, 2023
issue: flutter/flutter#97747 framework pr :flutter/flutter#135771 android pr: #47114 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
hannah-hyj
added
the
autosubmit
auto-submit
Bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/135771, due to - The status or check suite Linux android views has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Update navigatort.dart 1 Update navigator_test.dart Update feedback.dart Update navigator.dart Update navigator.dart lint 1 Update navigator_test.dart Update feedback.dart Update navigator_test.dart Update navigator.dart lint 1
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 29, 2023
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
zhongdaiqi
pushed a commit
to zhongdaiqi/flutter_flutter
that referenced
this pull request
Oct 9, 2026
…utter-team-archive/engine#47114) issue:flutter/flutter#97747 framework pr:flutter/flutter#135771 ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [ ] I signed the [CLA]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --------- Co-authored-by: Reid Baker <[email protected]>
zhongdaiqi
pushed a commit
to zhongdaiqi/flutter_flutter
that referenced
this pull request
Oct 9, 2026
…r-team-archive/engine#48252) issue: flutter/flutter#97747 framework pr :flutter/flutter#135771 android pr: flutter-team-archive/engine#47114 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue: #97747
engine pr:flutter-team-archive/engine#47114
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.