Skip to content

Fix flakiness: finalize dropped gestures in tests to release resources, and update doc-comment. - #136136

Merged
polina-c merged 15 commits into
flutter:masterfrom
polina-c:full-fix
Oct 11, 2023
Merged

Fix flakiness: finalize dropped gestures in tests to release resources, and update doc-comment.#136136
polina-c merged 15 commits into
flutter:masterfrom
polina-c:full-fix

Conversation

@polina-c

@polina-c polina-c commented Oct 7, 2023

Copy link
Copy Markdown
Contributor

Fixes #136132

@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages f: scrolling Viewports, list views, slivers, etc. p: cupertino_ui cupertino_ui package in flutter/packages f: gestures flutter/packages/flutter/gestures repository. labels Oct 7, 2023
@polina-c polina-c added a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker and removed a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages f: scrolling Viewports, list views, slivers, etc. p: cupertino_ui cupertino_ui package in flutter/packages f: gestures flutter/packages/flutter/gestures repository. labels Oct 7, 2023
@polina-c polina-c changed the title Finalize dropped gesture across flutter tests to release resources and update doc-comment. Finalize dropped gesture in tests to release resources and update doc-comment. Oct 7, 2023
@polina-c polina-c mentioned this pull request Oct 7, 2023
Closed
4 tasks done
@github-actions github-actions Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages f: scrolling Viewports, list views, slivers, etc. p: cupertino_ui cupertino_ui package in flutter/packages f: gestures flutter/packages/flutter/gestures repository. labels Oct 7, 2023
@polina-c polina-c changed the title Finalize dropped gesture in tests to release resources and update doc-comment. Fix flakiness: finalize dropped gesture in tests to release resources and update doc-comment. Oct 7, 2023
@polina-c
polina-c marked this pull request as ready for review October 7, 2023 23:58
@polina-c
polina-c requested a review from jonahwilliams October 7, 2023 23:59
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
1c02baf 
…resources, and update doc-comment. (flutter/flutter#136136)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
9b27b64 
…resources, and update doc-comment. (flutter/flutter#136136)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
7d71ea9 
…resources, and update doc-comment. (flutter/flutter#136136)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
2e3bca7 
…resources, and update doc-comment. (flutter/flutter#136136)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
8f6ccab 
…resources, and update doc-comment. (flutter/flutter#136136)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
073c3fc 
…resources, and update doc-comment. (flutter/flutter#136136)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
df94194 
…resources, and update doc-comment. (flutter/flutter#136136)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
4a7cda4 
…resources, and update doc-comment. (flutter/flutter#136136)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
cdd5ff7 
…resources, and update doc-comment. (flutter/flutter#136136)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
acfbf21 
…resources, and update doc-comment. (flutter/flutter#136136)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
d8a8952 
…resources, and update doc-comment. (flutter/flutter#136136)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
bb1042c 
…resources, and update doc-comment. (flutter/flutter#136136)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
51a7c84 
…resources, and update doc-comment. (flutter/flutter#136136)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
ad05949 Fix flakiness: finalize dropped gestures in tests to release …
afc9c91 
…resources, and update doc-comment. (flutter/flutter#136136)
@HansMuller HansMuller mentioned this pull request Oct 13, 2023
Closed
@justinmc justinmc mentioned this pull request Jan 16, 2025
Merged
8 of 9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso Awaiting requested review from zanderso
1 more reviewer
@jonahwilliams jonahwilliams jonahwilliams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: text input Entering text in a text field or keyboard related problems f: gestures flutter/packages/flutter/gestures repository. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Leak tracking is flacky around tap down/up.

2 participants

@polina-c @jonahwilliams