Skip to content

Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match iOS; inadvertent scrolling when user lifts up finger" - #136905

Merged
auto-submit[bot] merged 1 commit into
masterfrom
revert-132291-github/issue/97761/ios-inadvertant-scrolling-finger-lift
Oct 19, 2023
Merged

Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match iOS; inadvertent scrolling when user lifts up finger"#136905
auto-submit[bot] merged 1 commit into
masterfrom
revert-132291-github/issue/97761/ios-inadvertant-scrolling-finger-lift

Conversation

@Piinks

@Piinks Piinks commented Oct 19, 2023

Copy link
Copy Markdown
Contributor

Reverts #132291

We have found this introduced flakiness in many of our tests.

Fixes #135728

@Piinks
Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does n…
589d744 
…ot match iOS; inadvertent scrolling when user lifts up finger (#132291)"

This reverts commit fffbbf2.
@Piinks
Piinks requested a review from yjbanov October 19, 2023 17:14
@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: gestures flutter/packages/flutter/gestures repository. labels Oct 19, 2023
@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 19, 2023
@auto-submit
auto-submit Bot merged commit 548843b into master Oct 19, 2023
@auto-submit
auto-submit Bot deleted the revert-132291-github/issue/97761/ios-inadvertant-scrolling-finger-lift branch October 19, 2023 22:10
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 20, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 20, 2023
@engine-flutter-autoroll
548843b Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrollin…
d051d8f 
…g does not match iOS; inadvertent scrolling when user lifts up finger" (flutter/flutter#136905)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 20, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 20, 2023
@engine-flutter-autoroll
548843b Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrollin…
5117416 
…g does not match iOS; inadvertent scrolling when user lifts up finger" (flutter/flutter#136905)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Oct 20, 2023
@engine-flutter-autoroll
Roll Flutter from c2bd2c1 to 0883cb2 (24 revisions) (#5192)
a673198 
flutter/flutter@c2bd2c1...0883cb2

2023-10-20 [email protected] Roll Packages from 09c6b11 to be915be (6 revisions) (flutter/flutter#136964)
2023-10-20 [email protected] Roll Flutter Engine from de780872533c to 9b88ff83fd82 (4 revisions) (flutter/flutter#136959)
2023-10-20 [email protected] Roll Flutter Engine from 1e107c21328a to de780872533c (1 revision) (flutter/flutter#136952)
2023-10-20 [email protected] Roll Flutter Engine from fd33e7e75eac to 1e107c21328a (1 revision) (flutter/flutter#136949)
2023-10-20 [email protected] Roll Flutter Engine from 9dd59f7fcff9 to fd33e7e75eac (1 revision) (flutter/flutter#136942)
2023-10-20 [email protected] Roll Flutter Engine from cc3356c0e68f to 9dd59f7fcff9 (1 revision) (flutter/flutter#136935)
2023-10-20 [email protected] Roll Flutter Engine from 504a99d93f42 to cc3356c0e68f (2 revisions) (flutter/flutter#136934)
2023-10-19 [email protected] Roll Flutter Engine from 503b84295462 to 504a99d93f42 (3 revisions) (flutter/flutter#136930)
2023-10-19 [email protected] Roll Flutter Engine from 3b0469b0c718 to 503b84295462 (1 revision) (flutter/flutter#136928)
2023-10-19 [email protected] Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match iOS; inadvertent scrolling when user lifts up finger" (flutter/flutter#136905)
2023-10-19 [email protected] [flutter_tools] move build_preview_test from commands/permeable to integration shard (flutter/flutter#136912)
2023-10-19 [email protected] Roll Flutter Engine from b40042ebb95b to 3b0469b0c718 (2 revisions) (flutter/flutter#136922)
2023-10-19 [email protected] do not include entries from `--dart-define-from-file` files in the gradle config or environment during build (flutter/flutter#136865)
2023-10-19 [email protected] Roll Flutter Engine from bfd2ffb9a8bc to b40042ebb95b (2 revisions) (flutter/flutter#136915)
2023-10-19 [email protected] Roll Flutter Engine from 9d49175618f5 to bfd2ffb9a8bc (2 revisions) (flutter/flutter#136910)
2023-10-19 [email protected] Allow users to customize search algorithm in `DropdownMenu` (flutter/flutter#136848)
2023-10-19 [email protected] Upgrade Flutter deps to pull in latest vm_service and dwds (flutter/flutter#136734)
2023-10-19 [email protected] [Reland] Skip injecting Bonjour settings when port publication is disabled (flutter/flutter#136842)
2023-10-19 [email protected] _DefaultTabControllerState should dispose all created TabContoller instances. (flutter/flutter#136608)
2023-10-19 [email protected] Reland: "Add code for updating `focusedChild` when removing grandchildren from scope" (flutter/flutter#136899)
2023-10-19 [email protected] Roll Flutter Engine from 418dce4feaf7 to 9d49175618f5 (1 revision) (flutter/flutter#136901)
2023-10-19 [email protected] Unmark linux_android platform_channels_benchmarks as flaky (flutter/flutter#136838)
2023-10-19 [email protected] Roll Packages from 14aa69e to 09c6b11 (4 revisions) (flutter/flutter#136896)
2023-10-19 [email protected] Roll Flutter Engine from 28cb2508b8e0 to 418dce4feaf7 (2 revisions) (flutter/flutter#136895)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
yjbanov added a commit to yjbanov/flutter that referenced this pull request Oct 24, 2023
@yjbanov
Reapply "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does …
fb07824 
…not match iOS; inadvertent scrolling when user lifts up finger" (flutter#136905)

This reverts commit 548843b.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from c2bd2c1 to 0883cb2 (24 revisions) (flutter#5192)
5c68d82 
flutter/flutter@c2bd2c1...0883cb2

2023-10-20 [email protected] Roll Packages from 09c6b11 to be915be (6 revisions) (flutter/flutter#136964)
2023-10-20 [email protected] Roll Flutter Engine from de780872533c to 9b88ff83fd82 (4 revisions) (flutter/flutter#136959)
2023-10-20 [email protected] Roll Flutter Engine from 1e107c21328a to de780872533c (1 revision) (flutter/flutter#136952)
2023-10-20 [email protected] Roll Flutter Engine from fd33e7e75eac to 1e107c21328a (1 revision) (flutter/flutter#136949)
2023-10-20 [email protected] Roll Flutter Engine from 9dd59f7fcff9 to fd33e7e75eac (1 revision) (flutter/flutter#136942)
2023-10-20 [email protected] Roll Flutter Engine from cc3356c0e68f to 9dd59f7fcff9 (1 revision) (flutter/flutter#136935)
2023-10-20 [email protected] Roll Flutter Engine from 504a99d93f42 to cc3356c0e68f (2 revisions) (flutter/flutter#136934)
2023-10-19 [email protected] Roll Flutter Engine from 503b84295462 to 504a99d93f42 (3 revisions) (flutter/flutter#136930)
2023-10-19 [email protected] Roll Flutter Engine from 3b0469b0c718 to 503b84295462 (1 revision) (flutter/flutter#136928)
2023-10-19 [email protected] Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match iOS; inadvertent scrolling when user lifts up finger" (flutter/flutter#136905)
2023-10-19 [email protected] [flutter_tools] move build_preview_test from commands/permeable to integration shard (flutter/flutter#136912)
2023-10-19 [email protected] Roll Flutter Engine from b40042ebb95b to 3b0469b0c718 (2 revisions) (flutter/flutter#136922)
2023-10-19 [email protected] do not include entries from `--dart-define-from-file` files in the gradle config or environment during build (flutter/flutter#136865)
2023-10-19 [email protected] Roll Flutter Engine from bfd2ffb9a8bc to b40042ebb95b (2 revisions) (flutter/flutter#136915)
2023-10-19 [email protected] Roll Flutter Engine from 9d49175618f5 to bfd2ffb9a8bc (2 revisions) (flutter/flutter#136910)
2023-10-19 [email protected] Allow users to customize search algorithm in `DropdownMenu` (flutter/flutter#136848)
2023-10-19 [email protected] Upgrade Flutter deps to pull in latest vm_service and dwds (flutter/flutter#136734)
2023-10-19 [email protected] [Reland] Skip injecting Bonjour settings when port publication is disabled (flutter/flutter#136842)
2023-10-19 [email protected] _DefaultTabControllerState should dispose all created TabContoller instances. (flutter/flutter#136608)
2023-10-19 [email protected] Reland: "Add code for updating `focusedChild` when removing grandchildren from scope" (flutter/flutter#136899)
2023-10-19 [email protected] Roll Flutter Engine from 418dce4feaf7 to 9d49175618f5 (1 revision) (flutter/flutter#136901)
2023-10-19 [email protected] Unmark linux_android platform_channels_benchmarks as flaky (flutter/flutter#136838)
2023-10-19 [email protected] Roll Packages from 14aa69e to 09c6b11 (4 revisions) (flutter/flutter#136896)
2023-10-19 [email protected] Roll Flutter Engine from 28cb2508b8e0 to 418dce4feaf7 (2 revisions) (flutter/flutter#136895)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Roll Flutter from c2bd2c1 to 0883cb2 (24 revisions) (flutter#5192)
c9adc1d 
flutter/flutter@c2bd2c1...0883cb2

2023-10-20 [email protected] Roll Packages from 07b3ff6 to c88cba8 (6 revisions) (flutter/flutter#136964)
2023-10-20 [email protected] Roll Flutter Engine from de780872533c to 9b88ff83fd82 (4 revisions) (flutter/flutter#136959)
2023-10-20 [email protected] Roll Flutter Engine from 1e107c21328a to de780872533c (1 revision) (flutter/flutter#136952)
2023-10-20 [email protected] Roll Flutter Engine from fd33e7e75eac to 1e107c21328a (1 revision) (flutter/flutter#136949)
2023-10-20 [email protected] Roll Flutter Engine from 9dd59f7fcff9 to fd33e7e75eac (1 revision) (flutter/flutter#136942)
2023-10-20 [email protected] Roll Flutter Engine from cc3356c0e68f to 9dd59f7fcff9 (1 revision) (flutter/flutter#136935)
2023-10-20 [email protected] Roll Flutter Engine from 504a99d93f42 to cc3356c0e68f (2 revisions) (flutter/flutter#136934)
2023-10-19 [email protected] Roll Flutter Engine from 503b84295462 to 504a99d93f42 (3 revisions) (flutter/flutter#136930)
2023-10-19 [email protected] Roll Flutter Engine from 3b0469b0c718 to 503b84295462 (1 revision) (flutter/flutter#136928)
2023-10-19 [email protected] Revert "[Velocity Tracker] Fix: Issue 97761: Flutter Scrolling does not match iOS; inadvertent scrolling when user lifts up finger" (flutter/flutter#136905)
2023-10-19 [email protected] [flutter_tools] move build_preview_test from commands/permeable to integration shard (flutter/flutter#136912)
2023-10-19 [email protected] Roll Flutter Engine from b40042ebb95b to 3b0469b0c718 (2 revisions) (flutter/flutter#136922)
2023-10-19 [email protected] do not include entries from `--dart-define-from-file` files in the gradle config or environment during build (flutter/flutter#136865)
2023-10-19 [email protected] Roll Flutter Engine from bfd2ffb9a8bc to b40042ebb95b (2 revisions) (flutter/flutter#136915)
2023-10-19 [email protected] Roll Flutter Engine from 9d49175618f5 to bfd2ffb9a8bc (2 revisions) (flutter/flutter#136910)
2023-10-19 [email protected] Allow users to customize search algorithm in `DropdownMenu` (flutter/flutter#136848)
2023-10-19 [email protected] Upgrade Flutter deps to pull in latest vm_service and dwds (flutter/flutter#136734)
2023-10-19 [email protected] [Reland] Skip injecting Bonjour settings when port publication is disabled (flutter/flutter#136842)
2023-10-19 [email protected] _DefaultTabControllerState should dispose all created TabContoller instances. (flutter/flutter#136608)
2023-10-19 [email protected] Reland: "Add code for updating `focusedChild` when removing grandchildren from scope" (flutter/flutter#136899)
2023-10-19 [email protected] Roll Flutter Engine from 418dce4feaf7 to 9d49175618f5 (1 revision) (flutter/flutter#136901)
2023-10-19 [email protected] Unmark linux_android platform_channels_benchmarks as flaky (flutter/flutter#136838)
2023-10-19 [email protected] Roll Packages from 0073df0 to 07b3ff6 (4 revisions) (flutter/flutter#136896)
2023-10-19 [email protected] Roll Flutter Engine from 28cb2508b8e0 to 418dce4feaf7 (2 revisions) (flutter/flutter#136895)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes
@cbracken cbracken cbracken approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: gestures flutter/packages/flutter/gestures repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web] persistent_bottom_sheet_test.dart is infrequently flaky

3 participants

@Piinks @yjbanov @cbracken