Skip to content

Reland coverableLineCache optimisation (#136851) - #137385

Merged
liamappelbe merged 3 commits into
flutter:masterfrom
liamappelbe:covoptreland
Oct 29, 2023
Merged

Reland coverableLineCache optimisation (#136851)#137385
liamappelbe merged 3 commits into
flutter:masterfrom
liamappelbe:covoptreland

Conversation

@liamappelbe

@liamappelbe liamappelbe commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

Relands #136851, which was rolled back in #137121

package:coverage has been rolled, so the breakages should be fixed. Also, in this reland I've changed the coverableLineCache parameter to be optional, which is safer.

@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 27, 2023
@liamappelbe liamappelbe added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 27, 2023
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 27, 2023
@auto-submit

auto-submit Bot commented Oct 27, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/137385, due to - The status or check suite Mac_arm64 run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

  • The status or check suite Mac run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac channels_integration_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac native_ui_tests_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_arm64 tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_x64 tool_host_cross_arch_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac plugin_dependencies_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac module_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac dart_plugin_registry_test has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_4_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_3_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_2_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_ios_framework_module_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@liamappelbe
liamappelbe merged commit e12d1a7 into flutter:master Oct 29, 2023
@liamappelbe
liamappelbe deleted the covoptreland branch October 29, 2023 22:00
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 30, 2023
@engine-flutter-autoroll
e12d1a7 Reland coverableLineCache optimisation (#136851) (flutter/f…
9c118c0 
…lutter#137385)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 30, 2023
@engine-flutter-autoroll
e12d1a7 Reland coverableLineCache optimisation (#136851) (flutter/f…
68493a1 
…lutter#137385)
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Oct 30, 2023
@engine-flutter-autoroll
Roll Flutter from a4ec627 to e12d1a7 (3 revisions) (#5267)
21a585f 
flutter/flutter@a4ec627...e12d1a7

2023-10-29 [email protected] Reland `coverableLineCache` optimisation (#136851) (flutter/flutter#137385)
2023-10-28 [email protected] Instrument RestorationBucket, _RouteEntry and DisposableBuildContext for leak tracking. (flutter/flutter#137477)
2023-10-28 [email protected] BannerPainter should dispatch creation and disposal events.  (flutter/flutter#137472)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Oct 31, 2023
@liamappelbe @ksokolovskyi
Reland coverableLineCache optimisation (flutter#136851) (flutter#13…
5bbc84e 
…7385)

Relands flutter#136851, which was rolled back in flutter#137121

package:coverage has been rolled, so the breakages should be fixed.
Also, in this reland I've changed the `coverableLineCache` parameter to
be optional, which is safer.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
e12d1a7 Reland coverableLineCache optimisation (#136851) (flutter/f…
e69c5de 
…lutter#137385)
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@engine-flutter-autoroll
Roll Flutter from a4ec627 to e12d1a7 (3 revisions) (flutter#5267)
c2362ff 
flutter/flutter@a4ec627...e12d1a7

2023-10-29 [email protected] Reland `coverableLineCache` optimisation (#136851) (flutter/flutter#137385)
2023-10-28 [email protected] Instrument RestorationBucket, _RouteEntry and DisposableBuildContext for leak tracking. (flutter/flutter#137477)
2023-10-28 [email protected] BannerPainter should dispatch creation and disposal events.  (flutter/flutter#137472)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@engine-flutter-autoroll
Roll Flutter from a4ec627 to e12d1a7 (3 revisions) (flutter#5267)
15b4789 
flutter/flutter@a4ec627...e12d1a7

2023-10-29 [email protected] Reland `coverableLineCache` optimisation (#136851) (flutter/flutter#137385)
2023-10-28 [email protected] Instrument RestorationBucket, _RouteEntry and DisposableBuildContext for leak tracking. (flutter/flutter#137477)
2023-10-28 [email protected] BannerPainter should dispatch creation and disposal events.  (flutter/flutter#137472)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CaseyHillers CaseyHillers CaseyHillers approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liamappelbe @CaseyHillers