Skip to content

Adds useRootNavigator property to PopupMenuButton widget. - #137453

Merged
auto-submit[bot] merged 4 commits into
flutter:masterfrom
piedcipher:feature/popUpMenuButton-useRootNavigator
Nov 10, 2023
Merged

Adds useRootNavigator property to PopupMenuButton widget.#137453
auto-submit[bot] merged 4 commits into
flutter:masterfrom
piedcipher:feature/popUpMenuButton-useRootNavigator

Conversation

@piedcipher

@piedcipher piedcipher commented Oct 27, 2023

Copy link
Copy Markdown
Member

Adds useRootNavigator property to PopupMenuButton widget.

Fixes #95425

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Oct 27, 2023
@piedcipher

piedcipher commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

Not sure why tests are failing, earlier it didn't. Seems flaky

@HansMuller
HansMuller requested a review from chunhtai November 3, 2023 21:39
chunhtai
chunhtai approved these changes Nov 9, 2023
View reviewed changes

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/flutter/lib/src/material/popup_menu.dart Outdated
@chunhtai
chunhtai requested a review from gspencergoog November 9, 2023 19:03
gspencergoog
gspencergoog approved these changes Nov 9, 2023
View reviewed changes

@gspencergoog gspencergoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 9, 2023
@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 9, 2023
@auto-submit

auto-submit Bot commented Nov 9, 2023

Copy link
Copy Markdown
Contributor

auto label is removed for flutter/flutter/137453, due to - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label.

@chunhtai

chunhtai commented Nov 9, 2023

Copy link
Copy Markdown
Contributor

looks like a format error

/b/s/w/ir/x/w/Á flutter sdk/packages/flutter/lib/src/material/popup_menu.dart:1298: trailing U+0020 space character

@piedcipher

piedcipher commented Nov 10, 2023

Copy link
Copy Markdown
Member Author

looks like a format error

/b/s/w/ir/x/w/Á flutter sdk/packages/flutter/lib/src/material/popup_menu.dart:1298: trailing U+0020 space character

Fixed ✅

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 10, 2023
@auto-submit
auto-submit Bot merged commit 983b2f6 into flutter:master Nov 10, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
db1e260 
…flutter/flutter#137453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
65b73eb 
…flutter/flutter#137453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
3f615d0 
…flutter/flutter#137453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
7c8bb25 
…flutter/flutter#137453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
c9bb963 
…flutter/flutter#137453)
@piedcipher
piedcipher deleted the feature/popUpMenuButton-useRootNavigator branch November 10, 2023 20:16
@HansMuller HansMuller mentioned this pull request Nov 10, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
de25b42 
…flutter/flutter#137453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
a50d031 
…flutter/flutter#137453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
d733cc3 
…flutter/flutter#137453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
ddbf80b 
…flutter/flutter#137453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
476d67f 
…flutter/flutter#137453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
3bbca01 
…flutter/flutter#137453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
a50005a 
…flutter/flutter#137453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
ed1a30f 
…flutter/flutter#137453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
f2c384e 
…flutter/flutter#137453)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
7633c8e 
…flutter/flutter#137453)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
3e441ea 
…flutter/flutter#137453)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
6c18f8f 
…flutter/flutter#137453)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
983b2f6 Adds useRootNavigator property to PopupMenuButton widget. (…
4c2ebf0 
…flutter/flutter#137453)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes
@chunhtai chunhtai chunhtai approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PopupMenuButton should expose useRootNavigator argument

3 participants

@piedcipher @chunhtai @gspencergoog