Skip to content

Marks Windows_arm64 plugin_test_windows to be unflaky - #137675

Merged
auto-submit[bot] merged 3 commits into
flutter:masterfrom
fluttergithubbot:brP4Wkko28
Jan 30, 2024
Merged

auto-submit[bot] merged 3 commits into
flutter:masterfrom
fluttergithubbot:brP4Wkko28

Conversation

@fluttergithubbot

Copy link
Copy Markdown
Contributor

The issue #134083 has been closed, and the test has been passing for 50 consecutive runs.
This test can be marked as unflaky.

@flutter-dashboard flutter-dashboard Bot added c: flake Tests that sometimes, but not always, incorrectly pass c: tech-debt Technical debt, code quality, testing, etc. labels Nov 1, 2023
@goderbauer

Copy link
Copy Markdown
Member

(triage) Spoke to @loic-sharma and he says he will follow up on this change.

@loic-sharma

Copy link
Copy Markdown
Member

Root cause for failure: #141986
Workaround: #141987

@github-actions github-actions Bot removed the c: tech-debt Technical debt, code quality, testing, etc. label Jan 29, 2024
@loic-sharma

Copy link
Copy Markdown
Member

#141987 landed, this should be unblocked now...

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 30, 2024
@auto-submit
auto-submit Bot merged commit bd71503 into flutter:master Jan 30, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 1, 2024
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Feb 1, 2024
Manual roll requested by [email protected]

flutter/flutter@75a2e5b...c65ab4d

2024-01-31 [email protected] Roll Flutter Engine from 2d2d88068a23 to 8e7df85f7d11 (2 revisions) (flutter/flutter#142583)
2024-01-31 [email protected] Add `DropdownMenu.focusNode` (flutter/flutter#142516)
2024-01-31 [email protected] Marks Windows_android native_assets_android to be unflaky (flutter/flutter#140042)
2024-01-31 [email protected] Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller_gles__timeline_summary to be unflaky (flutter/flutter#140039)
2024-01-31 [email protected] Marks Linux_android native_assets_android to be unflaky (flutter/flutter#140040)
2024-01-31 [email protected] Marks Mac_android native_assets_android to be unflaky (flutter/flutter#140041)
2024-01-31 [email protected] Marks Mac flavors_test_macos to be unflaky (flutter/flutter#140647)
2024-01-31 [email protected] Roll Flutter Engine from 588f06b02664 to 2d2d88068a23 (1 revision) (flutter/flutter#142569)
2024-01-31 [email protected] Roll Flutter Engine from e6e1d6b3d035 to 588f06b02664 (1 revision) (flutter/flutter#142566)
2024-01-31 [email protected] M3 - Fix Chip icon and label colors (flutter/flutter#140573)
2024-01-31 [email protected] Roll Flutter Engine from d20ed240ace9 to e6e1d6b3d035 (3 revisions) (flutter/flutter#142564)
2024-01-30 [email protected] Be less verbose in CI for customer_testing, and revert old timeout hack (flutter/flutter#139611)
2024-01-30 [email protected] use PDI to end the isolated scope for RLI (flutter/flutter#141345)
2024-01-30 [email protected] Style correctness improvements for toStrings and related fixes (flutter/flutter#142485)
2024-01-30 [email protected] Roll Flutter Engine from 500ae6c4d947 to d20ed240ace9 (1 revision) (flutter/flutter#142554)
2024-01-30 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.5 to 3.1.6 (flutter/flutter#142553)
2024-01-30 [email protected] Roll Flutter Engine from cd12316a0883 to 500ae6c4d947 (1 revision) (flutter/flutter#142551)
2024-01-30 [email protected] Roll Flutter Engine from 0e4342c5a1f2 to cd12316a0883 (6 revisions) (flutter/flutter#142548)
2024-01-30 [email protected] Roll Flutter Engine from 438e9b4d7d4e to 0e4342c5a1f2 (11 revisions) (flutter/flutter#142543)
2024-01-30 [email protected] Fix: selection handles do not inherit color from local `Theme` widget (flutter/flutter#142476)
2024-01-30 [email protected] Marks Windows_arm64 plugin_test_windows to be unflaky (flutter/flutter#137675)
2024-01-30 [email protected] Revert "Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions)" (flutter/flutter#142533)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
)

Manual roll requested by [email protected]

flutter/flutter@75a2e5b...c65ab4d

2024-01-31 [email protected] Roll Flutter Engine from 2d2d88068a23 to 8e7df85f7d11 (2 revisions) (flutter/flutter#142583)
2024-01-31 [email protected] Add `DropdownMenu.focusNode` (flutter/flutter#142516)
2024-01-31 [email protected] Marks Windows_android native_assets_android to be unflaky (flutter/flutter#140042)
2024-01-31 [email protected] Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller_gles__timeline_summary to be unflaky (flutter/flutter#140039)
2024-01-31 [email protected] Marks Linux_android native_assets_android to be unflaky (flutter/flutter#140040)
2024-01-31 [email protected] Marks Mac_android native_assets_android to be unflaky (flutter/flutter#140041)
2024-01-31 [email protected] Marks Mac flavors_test_macos to be unflaky (flutter/flutter#140647)
2024-01-31 [email protected] Roll Flutter Engine from 588f06b02664 to 2d2d88068a23 (1 revision) (flutter/flutter#142569)
2024-01-31 [email protected] Roll Flutter Engine from e6e1d6b3d035 to 588f06b02664 (1 revision) (flutter/flutter#142566)
2024-01-31 [email protected] M3 - Fix Chip icon and label colors (flutter/flutter#140573)
2024-01-31 [email protected] Roll Flutter Engine from d20ed240ace9 to e6e1d6b3d035 (3 revisions) (flutter/flutter#142564)
2024-01-30 [email protected] Be less verbose in CI for customer_testing, and revert old timeout hack (flutter/flutter#139611)
2024-01-30 [email protected] use PDI to end the isolated scope for RLI (flutter/flutter#141345)
2024-01-30 [email protected] Style correctness improvements for toStrings and related fixes (flutter/flutter#142485)
2024-01-30 [email protected] Roll Flutter Engine from 500ae6c4d947 to d20ed240ace9 (1 revision) (flutter/flutter#142554)
2024-01-30 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.5 to 3.1.6 (flutter/flutter#142553)
2024-01-30 [email protected] Roll Flutter Engine from cd12316a0883 to 500ae6c4d947 (1 revision) (flutter/flutter#142551)
2024-01-30 [email protected] Roll Flutter Engine from 0e4342c5a1f2 to cd12316a0883 (6 revisions) (flutter/flutter#142548)
2024-01-30 [email protected] Roll Flutter Engine from 438e9b4d7d4e to 0e4342c5a1f2 (11 revisions) (flutter/flutter#142543)
2024-01-30 [email protected] Fix: selection handles do not inherit color from local `Theme` widget (flutter/flutter#142476)
2024-01-30 [email protected] Marks Windows_arm64 plugin_test_windows to be unflaky (flutter/flutter#137675)
2024-01-30 [email protected] Revert "Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions)" (flutter/flutter#142533)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
)

Manual roll requested by [email protected]

flutter/flutter@75a2e5b...c65ab4d

2024-01-31 [email protected] Roll Flutter Engine from 2d2d88068a23 to 8e7df85f7d11 (2 revisions) (flutter/flutter#142583)
2024-01-31 [email protected] Add `DropdownMenu.focusNode` (flutter/flutter#142516)
2024-01-31 [email protected] Marks Windows_android native_assets_android to be unflaky (flutter/flutter#140042)
2024-01-31 [email protected] Marks Linux_pixel_7pro complex_layout_scroll_perf_impeller_gles__timeline_summary to be unflaky (flutter/flutter#140039)
2024-01-31 [email protected] Marks Linux_android native_assets_android to be unflaky (flutter/flutter#140040)
2024-01-31 [email protected] Marks Mac_android native_assets_android to be unflaky (flutter/flutter#140041)
2024-01-31 [email protected] Marks Mac flavors_test_macos to be unflaky (flutter/flutter#140647)
2024-01-31 [email protected] Roll Flutter Engine from 588f06b02664 to 2d2d88068a23 (1 revision) (flutter/flutter#142569)
2024-01-31 [email protected] Roll Flutter Engine from e6e1d6b3d035 to 588f06b02664 (1 revision) (flutter/flutter#142566)
2024-01-31 [email protected] M3 - Fix Chip icon and label colors (flutter/flutter#140573)
2024-01-31 [email protected] Roll Flutter Engine from d20ed240ace9 to e6e1d6b3d035 (3 revisions) (flutter/flutter#142564)
2024-01-30 [email protected] Be less verbose in CI for customer_testing, and revert old timeout hack (flutter/flutter#139611)
2024-01-30 [email protected] use PDI to end the isolated scope for RLI (flutter/flutter#141345)
2024-01-30 [email protected] Style correctness improvements for toStrings and related fixes (flutter/flutter#142485)
2024-01-30 [email protected] Roll Flutter Engine from 500ae6c4d947 to d20ed240ace9 (1 revision) (flutter/flutter#142554)
2024-01-30 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.5 to 3.1.6 (flutter/flutter#142553)
2024-01-30 [email protected] Roll Flutter Engine from cd12316a0883 to 500ae6c4d947 (1 revision) (flutter/flutter#142551)
2024-01-30 [email protected] Roll Flutter Engine from 0e4342c5a1f2 to cd12316a0883 (6 revisions) (flutter/flutter#142548)
2024-01-30 [email protected] Roll Flutter Engine from 438e9b4d7d4e to 0e4342c5a1f2 (11 revisions) (flutter/flutter#142543)
2024-01-30 [email protected] Fix: selection handles do not inherit color from local `Theme` widget (flutter/flutter#142476)
2024-01-30 [email protected] Marks Windows_arm64 plugin_test_windows to be unflaky (flutter/flutter#137675)
2024-01-30 [email protected] Revert "Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions)" (flutter/flutter#142533)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: flake Tests that sometimes, but not always, incorrectly pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants