Repository navigation
Try to work better on NFS - #13955
Merged
Merged
Conversation
amirh
reviewed
Jan 8, 2018
Contributor
There was a problem hiding this comment.
I don't understand the trickery going on here.
Can you add comments explaining this?
What does hash flock do? Why are we locking fd 3?
Contributor
Author
There was a problem hiding this comment.
Added some comments, PTAL. :-)
(untested)
Contributor
Author
|
will land on green |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
(untested)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't tested if this fixes NFS. I have tested that the locking still works on ext3.
cc @amirh for review