Merge flutter_goldens_client into flutter_goldens by Hixie · Pull Request #141900 · flutter/flutter

Hixie · 2024-01-19T20:51:12Z

This is part 1 of a broken down version of the #140101 refactor.

flutter-dashboard · 2024-01-19T20:51:15Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Hixie · 2024-01-19T20:51:29Z

test-exempt: code refactor with no semantic change

Hixie · 2024-01-19T20:51:34Z

cc @Piinks

This is part 1 of a broken down version of the flutter#140101 refactor.

Swiftaxe

LGTM!

Piinks · 2024-01-23T20:23:08Z

@Swiftaxe please do not merge changes manually. The bot will merge them when checks have completed. The Google test shard only executes after a change is approved.

Hixie · 2024-01-23T20:46:53Z

@Swiftaxe definitely don't merge other people's PRs, ever. Let the person who wrote the PR have final say on whether to land or not.
For example in this particular case I would never have landed this without @Piinks's LGTM since she owns this area of the code, and we have had a bad experience trying to land this refactor in the past so being extra careful is especially warranted.

@Piinks let me know if you would like me to revert for now.

Piinks · 2024-01-23T20:53:31Z

I think we can leave this in @Hixie. Thanks for checking. :)

Swiftaxe · 2024-01-24T06:13:03Z

@Swiftaxe please do not merge changes manually. The bot will merge them when checks have completed. The Google test shard only executes after a change is approved.

Thanks

@Swiftaxe definitely don't merge other people's PRs, ever. Let the person who wrote the PR have final say on whether to land or not. For example in this particular case I would never have landed this without @Piinks's LGTM since she owns this area of the code, and we have had a bad experience trying to land this refactor in the past so being extra careful is especially warranted.

@Piinks let me know if you would like me to revert for now.

Thank you @Piinks and @Hixie for reminding me! I was unsure about the procedure as I have mostly been committing fixes myself. Sorry for this. 🙈

The shiny green button was tempting – I guess. 🙃

You are the best! 🤓💚

…utter#141900)

flutter/flutter@5b673c2...19b06f4 2024-01-24 [email protected] Roll Flutter Engine from 7c592dbfa032 to ba3a70ce7722 (2 revisions) (flutter/flutter#142130) 2024-01-24 [email protected] Roll Flutter Engine from 700235c85d4a to 7c592dbfa032 (2 revisions) (flutter/flutter#142108) 2024-01-24 [email protected] Roll Flutter Engine from da96f9de3f69 to 700235c85d4a (1 revision) (flutter/flutter#142100) 2024-01-24 [email protected] Roll Flutter Engine from 220416cfa6ca to da96f9de3f69 (5 revisions) (flutter/flutter#142098) 2024-01-24 [email protected] Don't change the height of the Textfield's labelStyle when it focused. (flutter/flutter#141943) 2024-01-24 [email protected] Ignore a leak. (flutter/flutter#141737) 2024-01-24 [email protected] [github actions] FINALLY fix the mysterious token error in github actions (flutter/flutter#142058) 2024-01-24 [email protected] Revert "Add abifilters to our gradle templates" (flutter/flutter#142089) 2024-01-23 [email protected] Roll Flutter Engine from 0b9b538bd458 to 220416cfa6ca (2 revisions) (flutter/flutter#142079) 2024-01-23 [email protected] Add abifilters to our gradle templates (flutter/flutter#135529) 2024-01-23 [email protected] Roll Flutter Engine from 11a16d83ab6c to 0b9b538bd458 (2 revisions) (flutter/flutter#142076) 2024-01-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.2.0 to 4.3.0 (flutter/flutter#142075) 2024-01-23 [email protected] consolidate AssetBundle::entries and AssetBundle::entryKinds into a new type, `AssetBundleEntry` (flutter/flutter#142029) 2024-01-23 [email protected] Roll Flutter Engine from 57d6b518f920 to 11a16d83ab6c (4 revisions) (flutter/flutter#142071) 2024-01-23 [email protected] Roll Flutter Engine from 994054143fc3 to 57d6b518f920 (3 revisions) (flutter/flutter#142067) 2024-01-23 [email protected] [flutter_tools] fix language_version_test and enable shuffle (flutter/flutter#142009) 2024-01-23 [email protected] Merge flutter_goldens_client into flutter_goldens (flutter/flutter#141900) 2024-01-23 [email protected] Allow overriding the native assets yaml file in the resident runner. (flutter/flutter#142016) 2024-01-23 [email protected] Roll Flutter Engine from b229878c57f5 to 994054143fc3 (1 revision) (flutter/flutter#142059) 2024-01-23 [email protected] Update material banner maxScaleFactor to meet GAR requirement (flutter/flutter#142015) 2024-01-23 [email protected] Add tooltip for the clear button on `SearchAnchor`'s search view (flutter/flutter#141804) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions Bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jan 19, 2024

Hixie force-pushed the golden_refactor_journey_1 branch from 69d5c22 to bb07e0f Compare January 19, 2024 21:10

Hixie added 2 commits January 19, 2024 13:12

Merge flutter_goldens_client into flutter_goldens

8bc4dc9

This is part 1 of a broken down version of the flutter#140101 refactor.

Roll dependencies

6600001

Hixie force-pushed the golden_refactor_journey_1 branch from bb07e0f to 6600001 Compare January 19, 2024 21:13

Swiftaxe approved these changes Jan 23, 2024

View reviewed changes

Swiftaxe merged commit 574e598 into flutter:master Jan 23, 2024

engine-flutter-autoroll mentioned this pull request Jan 24, 2024

Roll Flutter from 5b673c28e4ac to 19b06f4ee9a0 (21 revisions) flutter/packages#5968

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2024

574e598 Merge flutter_goldens_client into flutter_goldens (flutter/fl…

e4c836b

…utter#141900)

Navigation Menu

Repository navigation

Merge flutter_goldens_client into flutter_goldens - #141900

Merge flutter_goldens_client into flutter_goldens#141900
Swiftaxe merged 2 commits into
flutter:masterfrom
Hixie:golden_refactor_journey_1

Hixie commented Jan 19, 2024

Uh oh!

flutter-dashboard Bot commented Jan 19, 2024

Uh oh!

Hixie commented Jan 19, 2024

Uh oh!

Hixie commented Jan 19, 2024

Uh oh!

Swiftaxe left a comment

Uh oh!

Piinks commented Jan 23, 2024

Uh oh!

Hixie commented Jan 23, 2024

Uh oh!

Piinks commented Jan 23, 2024

Uh oh!

Swiftaxe commented Jan 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Hixie commented Jan 19, 2024

Uh oh!

flutter-dashboard Bot commented Jan 19, 2024

Uh oh!

Hixie commented Jan 19, 2024

Uh oh!

Hixie commented Jan 19, 2024

Uh oh!

Swiftaxe left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks commented Jan 23, 2024

Uh oh!

Hixie commented Jan 23, 2024

Uh oh!

Piinks commented Jan 23, 2024

Uh oh!

Swiftaxe commented Jan 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants