Skip to content

Run gradle_plugin_*_apk_test on presubmit on flutter_tool changes. - #142090

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
eyebrowsoffire:gradle_plugin_presubmit
Mar 15, 2024
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
eyebrowsoffire:gradle_plugin_presubmit

Conversation

@eyebrowsoffire

Copy link
Copy Markdown
Contributor

These tests were failing in postsubmit after a change to packages/flutter_tools. We should run these in presubmit when packages/flutter_tools changes.

@flutter-dashboard

Copy link
Copy Markdown

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 15, 2024
@auto-submit
auto-submit Bot merged commit a97af20 into flutter:master Mar 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@eyebrowsoffire
eyebrowsoffire deleted the gradle_plugin_presubmit branch December 12, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants