Organize leak tracking TODOs. by polina-c · Pull Request #142460 · flutter/flutter

polina-c · 2024-01-29T18:12:10Z

Prerequisite: https://github.com/flutter/flutter/issues/141119m should merge to G3 (done).

This PR:

Adds/removes opt outs for leak tracking
Adds tag [leaks-to-clean] to all remaining opt outs that should be fixed, to make the search easier

…n-opt-out

goderbauer · 2024-01-30T00:08:59Z

  - name: Windows framework_tests_libraries_leak_tracking
    recipe: flutter/flutter_drone
-    bringup: true # New target: https://github.com/flutter/flutter/issues/140414
+    # bringup: true # New target: https://github.com/flutter/flutter/issues/140414


Is this change supposed to be in here?

goderbauer · 2024-01-30T00:10:32Z


  testWidgets('Should show event indicator for pointer events with setSurfaceSize',
-  // TODO(polina-c): clean up leaks, https://github.com/flutter/flutter/issues/134787
+  // TODO(polina-c): clean up leaks, https://github.com/flutter/flutter/issues/134787 [leaks-to-clean]


Looks like they all have the same issue attached, could you just search for that?

Nope, they are different. There are at least two (141388 and 134787). And, when we start investigating, new ones will show up.

…n-opt-out

goderbauer

LGTM

flutter/flutter@ace9181...75a2e5b 2024-01-30 [email protected] Reset framesEnabled to default value at the end of each test (flutter/flutter#141844) 2024-01-30 [email protected] Fix SliverMainAxisGroup geometry cacheExtent (flutter/flutter#142482) 2024-01-30 [email protected] Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions) (flutter/flutter#142528) 2024-01-30 [email protected] Roll Packages from 516648a to 25abb5d (6 revisions) (flutter/flutter#142527) 2024-01-30 [email protected] Roll Flutter Engine from 438e9b4d7d4e to 0e586d1c28c8 (4 revisions) (flutter/flutter#142515) 2024-01-30 [email protected] Using `initExpensiveAndroidView` for Android Hybrid Composition Mode (flutter/flutter#142399) 2024-01-30 [email protected] Roll Flutter Engine from ed73d40a8c93 to 438e9b4d7d4e (1 revision) (flutter/flutter#142508) 2024-01-30 [email protected] Organize leak tracking TODOs. (flutter/flutter#142460) 2024-01-30 [email protected] Roll Flutter Engine from 5584a78a439b to ed73d40a8c93 (1 revision) (flutter/flutter#142504) 2024-01-30 [email protected] Roll Flutter Engine from df5f1afd4991 to 5584a78a439b (2 revisions) (flutter/flutter#142503) 2024-01-30 [email protected] Roll Flutter Engine from 65bf8b1db4d1 to df5f1afd4991 (1 revision) (flutter/flutter#142501) 2024-01-30 [email protected] Roll Flutter Engine from c9268c7db03c to 65bf8b1db4d1 (1 revision) (flutter/flutter#142496) 2024-01-30 [email protected] Roll Flutter Engine from e21208583956 to c9268c7db03c (1 revision) (flutter/flutter#142492) 2024-01-29 [email protected] Roll Flutter Engine from bedafa8794b6 to e21208583956 (1 revision) (flutter/flutter#142483) 2024-01-29 [email protected] Revert "Reland: "Fix how Gradle resolves Android plugin" (#137115)" (flutter/flutter#142464) 2024-01-29 [email protected] Marks Mac_pixel_7pro native_assets_android to be unflaky (flutter/flutter#141675) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutter/flutter@ace9181...75a2e5b 2024-01-30 [email protected] Reset framesEnabled to default value at the end of each test (flutter/flutter#141844) 2024-01-30 [email protected] Fix SliverMainAxisGroup geometry cacheExtent (flutter/flutter#142482) 2024-01-30 [email protected] Roll Flutter Engine from 0e586d1c28c8 to f02a4a80a77e (3 revisions) (flutter/flutter#142528) 2024-01-30 [email protected] Roll Packages from 5818d32 to b37621c (6 revisions) (flutter/flutter#142527) 2024-01-30 [email protected] Roll Flutter Engine from 438e9b4d7d4e to 0e586d1c28c8 (4 revisions) (flutter/flutter#142515) 2024-01-30 [email protected] Using `initExpensiveAndroidView` for Android Hybrid Composition Mode (flutter/flutter#142399) 2024-01-30 [email protected] Roll Flutter Engine from ed73d40a8c93 to 438e9b4d7d4e (1 revision) (flutter/flutter#142508) 2024-01-30 [email protected] Organize leak tracking TODOs. (flutter/flutter#142460) 2024-01-30 [email protected] Roll Flutter Engine from 5584a78a439b to ed73d40a8c93 (1 revision) (flutter/flutter#142504) 2024-01-30 [email protected] Roll Flutter Engine from df5f1afd4991 to 5584a78a439b (2 revisions) (flutter/flutter#142503) 2024-01-30 [email protected] Roll Flutter Engine from 65bf8b1db4d1 to df5f1afd4991 (1 revision) (flutter/flutter#142501) 2024-01-30 [email protected] Roll Flutter Engine from c9268c7db03c to 65bf8b1db4d1 (1 revision) (flutter/flutter#142496) 2024-01-30 [email protected] Roll Flutter Engine from e21208583956 to c9268c7db03c (1 revision) (flutter/flutter#142492) 2024-01-29 [email protected] Roll Flutter Engine from bedafa8794b6 to e21208583956 (1 revision) (flutter/flutter#142483) 2024-01-29 [email protected] Revert "Reland: "Fix how Gradle resolves Android plugin" (#137115)" (flutter/flutter#142464) 2024-01-29 [email protected] Marks Mac_pixel_7pro native_assets_android to be unflaky (flutter/flutter#141675) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

polina-c added 3 commits January 29, 2024 10:04

-

99236d3

-

9c0146e

-

6db8a1c

polina-c marked this pull request as draft January 29, 2024 18:13

polina-c added 2 commits January 29, 2024 12:16

Merge branch 'master' of https://github.com/flutter/flutter into clea…

06eba07

…n-opt-out

-

989ec2a

polina-c marked this pull request as ready for review January 29, 2024 23:18

polina-c requested review from goderbauer and kenzieschmoll and removed request for goderbauer January 29, 2024 23:18

goderbauer reviewed Jan 30, 2024

View reviewed changes

polina-c added 2 commits January 29, 2024 16:27

Update .ci.yaml

ba16d47

Merge branch 'master' of https://github.com/flutter/flutter into clea…

a5722b1

…n-opt-out

polina-c requested a review from goderbauer January 30, 2024 00:29

goderbauer approved these changes Jan 30, 2024

View reviewed changes

polina-c merged commit 6dff3da into flutter:master Jan 30, 2024

polina-c deleted the clean-opt-out branch January 30, 2024 05:21

engine-flutter-autoroll mentioned this pull request Jan 30, 2024

Roll Flutter from 2f6fdf2650d4 to ccb2b4439a43 (68 revisions) flutter/packages#6014

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2024

6dff3da Organize leak tracking TODOs. (flutter/flutter#142460)

29b5d55

engine-flutter-autoroll mentioned this pull request Jan 30, 2024

Roll Flutter from 2f6fdf2650d4 to 72dc162ff052 (69 revisions) flutter/packages#6015

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2024

6dff3da Organize leak tracking TODOs. (flutter/flutter#142460)

a5e0336

engine-flutter-autoroll mentioned this pull request Jan 30, 2024

Roll Flutter from ace9181172b6 to 461f0bfb4b84 (13 revisions) flutter/packages#6016

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2024

6dff3da Organize leak tracking TODOs. (flutter/flutter#142460)

f9cafde

engine-flutter-autoroll mentioned this pull request Jan 30, 2024

Roll Flutter from ace9181172b6 to 75a2e5b4932a (16 revisions) flutter/packages#6017

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2024

6dff3da Organize leak tracking TODOs. (flutter/flutter#142460)

f83b778

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

6dff3da Organize leak tracking TODOs. (flutter/flutter#142460)

4dec145

Navigation Menu

Repository navigation

Organize leak tracking TODOs. - #142460

Organize leak tracking TODOs.#142460
polina-c merged 7 commits into
flutter:masterfrom
polina-c:clean-opt-out

polina-c commented Jan 29, 2024 •

edited

Loading

Uh oh!

goderbauer Jan 30, 2024

Uh oh!

goderbauer Jan 30, 2024

Uh oh!

polina-c Jan 30, 2024 •

edited

Loading

Uh oh!

goderbauer left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

polina-c commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

goderbauer Jan 30, 2024

Choose a reason for hiding this comment

Uh oh!

goderbauer Jan 30, 2024

Choose a reason for hiding this comment

Uh oh!

polina-c Jan 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

polina-c commented Jan 29, 2024 •

edited

Loading

polina-c Jan 30, 2024 •

edited

Loading