Skip to content

Fix chips constructor docs for callbacks - #143361

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
TahaTesser:fix_chips_constructor_docs
Feb 13, 2024
Merged

Fix chips constructor docs for callbacks#143361
auto-submit[bot] merged 1 commit into
flutter:masterfrom
TahaTesser:fix_chips_constructor_docs

Conversation

@TahaTesser

@TahaTesser TahaTesser commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

fixes ActionChip constructor documentation does not match class documentation

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages labels Feb 13, 2024
@TahaTesser
TahaTesser marked this pull request as ready for review February 13, 2024 09:12
HansMuller
HansMuller approved these changes Feb 13, 2024
View reviewed changes

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HansMuller HansMuller added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 13, 2024
@auto-submit
auto-submit Bot merged commit 2adbc2b into flutter:master Feb 13, 2024
@TahaTesser
TahaTesser deleted the fix_chips_constructor_docs branch February 13, 2024 19:14
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
2adbc2b Fix chips constructor docs for callbacks (flutter/flutter#143361
e36107c 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
2adbc2b Fix chips constructor docs for callbacks (flutter/flutter#143361
f82a5af 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2024
@engine-flutter-autoroll
2adbc2b Fix chips constructor docs for callbacks (flutter/flutter#143361
3d11dac 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024
@engine-flutter-autoroll
2adbc2b Fix chips constructor docs for callbacks (flutter/flutter#143361
d244109 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024
@engine-flutter-autoroll
2adbc2b Fix chips constructor docs for callbacks (flutter/flutter#143361
8399769 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024
@engine-flutter-autoroll
2adbc2b Fix chips constructor docs for callbacks (flutter/flutter#143361
f65465b 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
2adbc2b Fix chips constructor docs for callbacks (flutter/flutter#143361
b0ab518 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
2adbc2b Fix chips constructor docs for callbacks (flutter/flutter#143361
dc8331b 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
2adbc2b Fix chips constructor docs for callbacks (flutter/flutter#143361
77d2a45 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@HansMuller HansMuller HansMuller approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ActionChip constructor documentation does not match class documentation

2 participants

@TahaTesser @HansMuller