Repository navigation
fix rare flutter_tools logging crash in daemon mode - #14401
Merged
Merged
Conversation
jcollins-g
changed the title
devoncarew
approved these changes
Feb 1, 2018
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Populate AnsiTerminal in context for daemon launches * Strip out AnsiTerminal additions to context since they are no longer needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13993. Implements the simpler solution described in this comment, forcing
terminalto return an AnsiTerminal in the case where context doesn't populate it. To be sure that this works, I removed manual population of AnsiTerminal from all the relevant places to make sure it would be obvious if the fallback didn't function.I'm open to doing the larger refactor described, but it might take some time -- also open to other suggestions on how to accomplish this in a bulletproof manner.