Skip to content

Revert "Reduce noise in xcodebuild stdout" - #14605

Merged
xster merged 1 commit into
masterfrom
revert-14586-xcode-stdout-cleanup-1
Feb 9, 2018
Merged

xster merged 1 commit into
masterfrom
revert-14586-xcode-stdout-cleanup-1

Conversation

@xster

@xster xster commented Feb 9, 2018

Copy link
Copy Markdown
Member

Breaks device lab. There's some unwanted concurrency somewhere in there but I can't figure out where.

Reverts #14586

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xster

xster commented Feb 9, 2018

Copy link
Copy Markdown
Member Author

Submitting on red to unbreak head.

Not sure why it's referring to #14602 since it's not affecting that file.

@xster
xster force-pushed the revert-14586-xcode-stdout-cleanup-1 branch from b96a56b to 2afe35b Compare February 9, 2018 22:27
@xster

xster commented Feb 9, 2018

Copy link
Copy Markdown
Member Author

Rebased to get rid of the #14602 reference.

@xster
xster merged commit 8e2278b into master Feb 9, 2018
@xster
xster deleted the revert-14586-xcode-stdout-cleanup-1 branch February 9, 2018 22:28
xster added a commit to xster/flutter that referenced this pull request Feb 10, 2018
xster added a commit that referenced this pull request Feb 11, 2018
* Revert "Revert "Reduce noise in xcodebuild stdout (#14586)" (#14605)"

This reverts commit 8e2278b.

* Specify the build config when cleaning
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
* Revert "Revert "Reduce noise in xcodebuild stdout (flutter#14586)" (flutter#14605)"

This reverts commit 8e2278b.

* Specify the build config when cleaning
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants