Repository navigation
[CP-beta]Copy part files and sourcemaps when building with dart2js. - #146361
Merged
Conversation
…46356) This fixes flutter#145653 When dart2js emits deferred part files, they need to be copied from the build folder to the output folder.
Contributor
Author
|
@eyebrowsoffire please fill out the PR description above, afterwards the release team will review this request. |
github-actions
Bot
added
the
tool
Contributor
|
LGTM |
yjbanov
approved these changes
Apr 5, 2024
godofredoc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
liuyq
pushed a commit
to liuyq/flutter
that referenced
this pull request
Jan 26, 2026
…lutter#146361) This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/wiki/Flutter-Cherrypick-Process#automatically-creates-a-cherry-pick-request) flutter#145653 Fixes and issue where dart2js deferred part files were not being properly emitted by a web build. Users who use deferred loading in dart2js will not have any of the deferred JS files copied to their build directory. Users can manually copy the part files out of the `.dart_tool/flutter_build` directory into their `build/web` folder. What is the risk level of this cherry-pick? Are you confident that your fix is well-tested by automated tests? Follow the repro steps listed in flutter#145653. Ensure that the `build/web` folder contains the `main.dart.js_1.part.js` and `main.dart.js_1.part.js.map` files.
flutteractionsbot
deleted the
cp-beta-75ae44df77aef3d109add07abfd88438732bbee8
branch
July 20, 2026 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Issue Link:
#145653
Changelog Description:
Fixes and issue where dart2js deferred part files were not being properly emitted by a web build.
Impact Description:
Users who use deferred loading in dart2js will not have any of the deferred JS files copied to their build directory.
Workaround:
Users can manually copy the part files out of the
.dart_tool/flutter_builddirectory into theirbuild/webfolder.Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
Follow the repro steps listed in #145653.
Ensure that the
build/webfolder contains themain.dart.js_1.part.jsandmain.dart.js_1.part.js.mapfiles.