Skip to content

Roll Flutter Engine from 932c55025b87 to 0226114d5c54 (2 revisions) - #146475

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
engine-flutter-autoroll:flutter-engine-flutter-autoroll-5daaf2fe-bd7b-4221-af4e-1e770d1ee083-1712627181
Apr 9, 2024
Merged

auto-submit[bot] merged 2 commits into
flutter:masterfrom
engine-flutter-autoroll:flutter-engine-flutter-autoroll-5daaf2fe-bd7b-4221-af4e-1e770d1ee083-1712627181

Conversation

@engine-flutter-autoroll

Copy link
Copy Markdown
Contributor

flutter-team-archive/engine@932c550...0226114

2024-04-09 [email protected] Use Impeller geometry classes in DLMatrixClipTracker (flutter-team-archive/engine#51919)
2024-04-09 [email protected] Roll Dart SDK from 28b5735ad7dc to 78174b41ab0f (1 revision) (flutter-team-archive/engine#51976)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@engine-flutter-autoroll engine-flutter-autoroll added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2024
@github-actions github-actions Bot added the engine flutter/engine related. See also e: labels. label Apr 9, 2024
@auto-submit
auto-submit Bot merged commit c13e3fe into flutter:master Apr 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2024
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Apr 9, 2024
flutter/flutter@533d04d...4967a94

2024-04-09 [email protected] Fix Flutter `README.md` image sources (flutter/flutter#146430)
2024-04-09 [email protected] Roll Flutter Engine from 0226114d5c54 to 5a824e22deb2 (1 revision) (flutter/flutter#146477)
2024-04-09 [email protected] Roll Flutter Engine from 932c55025b87 to 0226114d5c54 (2 revisions) (flutter/flutter#146475)
2024-04-09 [email protected] Roll Flutter Engine from 8701a9a7fa41 to 932c55025b87 (1 revision) (flutter/flutter#146468)
2024-04-08 [email protected] Roll Flutter Engine from 269aa69f47df to 8701a9a7fa41 (4 revisions) (flutter/flutter#146463)
2024-04-08 [email protected] Roll Flutter Engine from ceb5fa2c8651 to 269aa69f47df (1 revision) (flutter/flutter#146449)
2024-04-08 [email protected] Text editing inside of Transformed.scale (flutter/flutter#146019)
2024-04-08 [email protected] Fix DropdownButtonFormField throws when onChange is null (flutter/flutter#146342)
2024-04-08 [email protected] Roll Flutter Engine from 1e88b2dbc7f7 to ceb5fa2c8651 (3 revisions) (flutter/flutter#146447)
2024-04-08 [email protected] Roll Flutter Engine from cc741b5ee89d to 1e88b2dbc7f7 (1 revision) (flutter/flutter#146445)
2024-04-08 [email protected] Roll pub packages (flutter/flutter#146444)
2024-04-08 [email protected] Add a custom shape example for `AppBar.shape` (flutter/flutter#146421)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@engine-flutter-autoroll
engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-5daaf2fe-bd7b-4221-af4e-1e770d1ee083-1712627181 branch April 16, 2024 02:29
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
…6475)

flutter-team-archive/engine@932c550...0226114

2024-04-09 [email protected] Use Impeller geometry classes in DLMatrixClipTracker (flutter-team-archive/engine#51919)
2024-04-09 [email protected] Roll Dart SDK from 28b5735ad7dc to 78174b41ab0f (1 revision) (flutter-team-archive/engine#51976)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@533d04d...4967a94

2024-04-09 [email protected] Fix Flutter `README.md` image sources (flutter/flutter#146430)
2024-04-09 [email protected] Roll Flutter Engine from 0226114d5c54 to 5a824e22deb2 (1 revision) (flutter/flutter#146477)
2024-04-09 [email protected] Roll Flutter Engine from 932c55025b87 to 0226114d5c54 (2 revisions) (flutter/flutter#146475)
2024-04-09 [email protected] Roll Flutter Engine from 8701a9a7fa41 to 932c55025b87 (1 revision) (flutter/flutter#146468)
2024-04-08 [email protected] Roll Flutter Engine from 269aa69f47df to 8701a9a7fa41 (4 revisions) (flutter/flutter#146463)
2024-04-08 [email protected] Roll Flutter Engine from ceb5fa2c8651 to 269aa69f47df (1 revision) (flutter/flutter#146449)
2024-04-08 [email protected] Text editing inside of Transformed.scale (flutter/flutter#146019)
2024-04-08 [email protected] Fix DropdownButtonFormField throws when onChange is null (flutter/flutter#146342)
2024-04-08 [email protected] Roll Flutter Engine from 1e88b2dbc7f7 to ceb5fa2c8651 (3 revisions) (flutter/flutter#146447)
2024-04-08 [email protected] Roll Flutter Engine from cc741b5ee89d to 1e88b2dbc7f7 (1 revision) (flutter/flutter#146445)
2024-04-08 [email protected] Roll pub packages (flutter/flutter#146444)
2024-04-08 [email protected] Add a custom shape example for `AppBar.shape` (flutter/flutter#146421)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
flutter/flutter@533d04d...4967a94

2024-04-09 [email protected] Fix Flutter `README.md` image sources (flutter/flutter#146430)
2024-04-09 [email protected] Roll Flutter Engine from 0226114d5c54 to 5a824e22deb2 (1 revision) (flutter/flutter#146477)
2024-04-09 [email protected] Roll Flutter Engine from 932c55025b87 to 0226114d5c54 (2 revisions) (flutter/flutter#146475)
2024-04-09 [email protected] Roll Flutter Engine from 8701a9a7fa41 to 932c55025b87 (1 revision) (flutter/flutter#146468)
2024-04-08 [email protected] Roll Flutter Engine from 269aa69f47df to 8701a9a7fa41 (4 revisions) (flutter/flutter#146463)
2024-04-08 [email protected] Roll Flutter Engine from ceb5fa2c8651 to 269aa69f47df (1 revision) (flutter/flutter#146449)
2024-04-08 [email protected] Text editing inside of Transformed.scale (flutter/flutter#146019)
2024-04-08 [email protected] Fix DropdownButtonFormField throws when onChange is null (flutter/flutter#146342)
2024-04-08 [email protected] Roll Flutter Engine from 1e88b2dbc7f7 to ceb5fa2c8651 (3 revisions) (flutter/flutter#146447)
2024-04-08 [email protected] Roll Flutter Engine from cc741b5ee89d to 1e88b2dbc7f7 (1 revision) (flutter/flutter#146445)
2024-04-08 [email protected] Roll pub packages (flutter/flutter#146444)
2024-04-08 [email protected] Add a custom shape example for `AppBar.shape` (flutter/flutter#146421)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
flutter/flutter@533d04d...4967a94

2024-04-09 [email protected] Fix Flutter `README.md` image sources (flutter/flutter#146430)
2024-04-09 [email protected] Roll Flutter Engine from 0226114d5c54 to 5a824e22deb2 (1 revision) (flutter/flutter#146477)
2024-04-09 [email protected] Roll Flutter Engine from 932c55025b87 to 0226114d5c54 (2 revisions) (flutter/flutter#146475)
2024-04-09 [email protected] Roll Flutter Engine from 8701a9a7fa41 to 932c55025b87 (1 revision) (flutter/flutter#146468)
2024-04-08 [email protected] Roll Flutter Engine from 269aa69f47df to 8701a9a7fa41 (4 revisions) (flutter/flutter#146463)
2024-04-08 [email protected] Roll Flutter Engine from ceb5fa2c8651 to 269aa69f47df (1 revision) (flutter/flutter#146449)
2024-04-08 [email protected] Text editing inside of Transformed.scale (flutter/flutter#146019)
2024-04-08 [email protected] Fix DropdownButtonFormField throws when onChange is null (flutter/flutter#146342)
2024-04-08 [email protected] Roll Flutter Engine from 1e88b2dbc7f7 to ceb5fa2c8651 (3 revisions) (flutter/flutter#146447)
2024-04-08 [email protected] Roll Flutter Engine from cc741b5ee89d to 1e88b2dbc7f7 (1 revision) (flutter/flutter#146445)
2024-04-08 [email protected] Roll pub packages (flutter/flutter#146444)
2024-04-08 [email protected] Add a custom shape example for `AppBar.shape` (flutter/flutter#146421)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
NassarAlshabi1 pushed a commit to NassarAlshabi1/marina-hotel-wit-app that referenced this pull request Aug 3, 2026
…cution)

CI run #30859315731 (commit 80063d4) proved that removing DateTime.now()
tests did NOT fix the segfault. New evidence:

  Log: 22:41:30.982Z  loading time_extended_test.dart [E]
       22:41:30.982Z  Shell subprocess crashed with segmentation fault.
  Context: segfault happens during LOADING (compilation), not execution.

Root cause: flutter_tools bug with --coverage flag + concurrency=2.
The test file itself is fine (pure unit tests with fixed DateTime values).
The segfault is in FlutterTesterTestDevice.finished/kill — the subprocess
crashes when flutter_tools tries to collect coverage from it.

This is a known issue:
  flutter/flutter#146475
  'flutter test --coverage segfaults on Linux CI runners'

Decision: re-add @Skip with updated root cause documentation.
The booking_price_adjustment_test.dart fix (calculationTime parameter)
remains valid and is NOT reverted — those 6 tests should now pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App engine flutter/engine related. See also e: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants